From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Marco Felsch <m.felsch@pengutronix.de>,
Support Opensource <Support.Opensource@diasemi.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: [RESEND PATCH v3 2/3] mfd: da9062: add support for the DA9062 GPIOs in the core
Date: Thu, 12 Dec 2019 16:45:46 +0000 [thread overview]
Message-ID: <AM5PR1001MB099464F0AD7334D0AE67011C80550@AM5PR1001MB0994.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20191212160413.15232-3-m.felsch@pengutronix.de>
On 12 December 2019 16:04, Marco Felsch wrote:
> Currently the da9062 GPIO's aren't available. The patch adds the support
> to make these available by adding a gpio device with the corresponding
> irq resources. Furthermore the patch fixes a minor style issue for the
> onkey device.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> ---
> drivers/mfd/da9062-core.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
> index e69626867c26..5290bdc0ddcd 100644
> --- a/drivers/mfd/da9062-core.c
> +++ b/drivers/mfd/da9062-core.c
> @@ -233,6 +233,14 @@ static struct resource da9062_onkey_resources[] = {
> DEFINE_RES_NAMED(DA9062_IRQ_ONKEY, 1, "ONKEY",
> IORESOURCE_IRQ),
> };
>
> +static struct resource da9062_gpio_resources[] = {
> + DEFINE_RES_NAMED(DA9062_IRQ_GPI0, 1, "GPI0", IORESOURCE_IRQ),
> + DEFINE_RES_NAMED(DA9062_IRQ_GPI1, 1, "GPI1", IORESOURCE_IRQ),
> + DEFINE_RES_NAMED(DA9062_IRQ_GPI2, 1, "GPI2", IORESOURCE_IRQ),
> + DEFINE_RES_NAMED(DA9062_IRQ_GPI3, 1, "GPI3", IORESOURCE_IRQ),
> + DEFINE_RES_NAMED(DA9062_IRQ_GPI4, 1, "GPI4", IORESOURCE_IRQ),
> +};
> +
> static const struct mfd_cell da9062_devs[] = {
> {
> .name = "da9062-core",
> @@ -266,7 +274,13 @@ static const struct mfd_cell da9062_devs[] = {
> .name = "da9062-onkey",
> .num_resources = ARRAY_SIZE(da9062_onkey_resources),
> .resources = da9062_onkey_resources,
> - .of_compatible = "dlg,da9062-onkey",
> + .of_compatible = "dlg,da9062-onkey",
> + },
> + {
> + .name = "da9062-gpio",
> + .num_resources = ARRAY_SIZE(da9062_gpio_resources),
> + .resources = da9062_gpio_resources,
> + .of_compatible = "dlg,da9062-gpio",
> },
> };
>
> --
> 2.20.1
next prev parent reply other threads:[~2019-12-12 16:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 16:04 [RESEND PATCH v3 0/3] Add DA9062 GPIO support Marco Felsch
2019-12-12 16:04 ` [RESEND PATCH v3 1/3] dt-bindings: mfd: da9062: add gpio bindings Marco Felsch
2019-12-12 16:45 ` Adam Thomson
2019-12-13 10:38 ` Lee Jones
2019-12-18 21:54 ` Rob Herring
2019-12-12 16:04 ` [RESEND PATCH v3 2/3] mfd: da9062: add support for the DA9062 GPIOs in the core Marco Felsch
2019-12-12 16:45 ` Adam Thomson [this message]
2019-12-13 10:37 ` Lee Jones
2019-12-12 16:04 ` [RESEND PATCH v3 3/3] pinctrl: da9062: add driver support Marco Felsch
2019-12-12 16:48 ` Adam Thomson
2019-12-16 7:47 ` Marco Felsch
2019-12-16 10:33 ` Linus Walleij
2019-12-17 6:40 ` Marco Felsch
2019-12-17 9:55 ` Adam Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM5PR1001MB099464F0AD7334D0AE67011C80550@AM5PR1001MB0994.EURPRD10.PROD.OUTLOOK.COM \
--to=adam.thomson.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).