From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B566CC2D0A3 for ; Wed, 4 Nov 2020 13:45:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 534562222C for ; Wed, 4 Nov 2020 13:45:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sartura-hr.20150623.gappssmtp.com header.i=@sartura-hr.20150623.gappssmtp.com header.b="ZhgOwDzO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730018AbgKDNpJ (ORCPT ); Wed, 4 Nov 2020 08:45:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726608AbgKDNpJ (ORCPT ); Wed, 4 Nov 2020 08:45:09 -0500 Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0D5EC0613D3 for ; Wed, 4 Nov 2020 05:45:08 -0800 (PST) Received: by mail-oi1-x243.google.com with SMTP id j7so22144757oie.12 for ; Wed, 04 Nov 2020 05:45:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura-hr.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tjiKTafBvqhyHu+XrblZM0qTc82uTpcV2NnP3xiexks=; b=ZhgOwDzOMctQUKpELCF6xCfAiCAnFc6zk2q+FcTcjlWq5EpTui0t6wNd3SDZHPo4JJ 0iwSfk3vA/4xK0orZjkWmbAMwsGd1nUmruRW6SkQy76kp2ucIb2ryFgooJoJTfnNUe34 xZmTwa+9BGhk9B3aPPRVEIgf/CWx1PvcC7w/iDMLY7S/cKdLZ6oU+0ZvdlEV4ZbrEZPP H/TGzVLNfonL5tVkiBxsOUAe+5MjFgE+D+98gKxWPdCFifWjiqlzxj60SusVxKrBCLz0 17fl02kiPFxXngNJ/mJr2pPrznCUcWuBgb1OBglhLjyWEfM8HlERCbKsbN7V8OA0WJjM u5TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tjiKTafBvqhyHu+XrblZM0qTc82uTpcV2NnP3xiexks=; b=QOcJtvfoZodHMEUbKnLGq58qy54r5XylL6xeMEwWwCEeeAvKCU/85QqY5T21U2esxL ZLZ3nl+b2UyaGnocZp0Ohk9DF+uGTiT8A7hPkbuyQ5qYRHctt/rLhtF2nPbJm1o1809y caqX1SCmqS2VTJAmHxveiB45I0GMKbsTFfIf18KPgTpqTW5OmaoI4AjQXgL/zMiDgOeT E8EGOziI0br5KoDsLX6L4iLaEexM/VcPtMsHiYVs/wLNxPZtlALS9pon5nDxc2NY6M9G ckOoSJ+2/XFuaAR9aktNv3rMIMZiYvbjYaoher/6lG7XhHFArEUNgjO+yuv7dV6Vpl5e Kwrw== X-Gm-Message-State: AOAM530vF8zUGx3PoU9oKzc7xAeAlFJcBdncFkpV1k/vMC+tvjFq4F11 tBHCsDyPJNiPDeGKUFIgUCYDZypDP48a1fWHnstV0g== X-Google-Smtp-Source: ABdhPJw/I69T9sXsTerkq96XXMF5qviBr0D4q8GyIjoyXXpCO8JCusvbseV9st/kEeUgyejwLokLFcam2B8RifsTGBQ= X-Received: by 2002:aca:570d:: with SMTP id l13mr2651297oib.96.1604497508034; Wed, 04 Nov 2020 05:45:08 -0800 (PST) MIME-Version: 1.0 References: <20200909163831.1894142-1-robert.marko@sartura.hr> In-Reply-To: <20200909163831.1894142-1-robert.marko@sartura.hr> From: Robert Marko Date: Wed, 4 Nov 2020 14:44:57 +0100 Message-ID: Subject: Re: [PATCH v8] ARM: dts: qcom: ipq4019: add USB devicetree nodes To: Andy Gross , Bjorn Andersson , robh+dt@kernel.org, linux-arm-msm , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: John Crispin , Luka Perkov , Vinod Koul Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Sep 9, 2020 at 6:38 PM Robert Marko wrote: > > From: John Crispin > > Since we now have driver for the USB PHY, and USB controller is already supported by the DWC3 driver lets add the necessary nodes to DTSI. > > Signed-off-by: John Crispin > Signed-off-by: Robert Marko > Cc: Luka Perkov > Reviewed-by: Vinod Koul > --- > Changes from v7 to v8: > * Add labels for usb2 and usb3 nodes > Changes from v6 to v7: > * Remove changes to qcom-ipq4019-ap.dk01.1.dtsi > It has slipped in unwanted, we only want to add > nodes to the DTSI. > > arch/arm/boot/dts/qcom-ipq4019.dtsi | 74 +++++++++++++++++++++++++++++ > 1 file changed, 74 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi > index 74d8e2c8e4b3..4a973253024a 100644 > --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi > @@ -605,5 +605,79 @@ ethphy4: ethernet-phy@4 { > reg = <4>; > }; > }; > + > + usb3_ss_phy: ssphy@9a000 { > + compatible = "qcom,usb-ss-ipq4019-phy"; > + #phy-cells = <0>; > + reg = <0x9a000 0x800>; > + reg-names = "phy_base"; > + resets = <&gcc USB3_UNIPHY_PHY_ARES>; > + reset-names = "por_rst"; > + status = "disabled"; > + }; > + > + usb3_hs_phy: hsphy@a6000 { > + compatible = "qcom,usb-hs-ipq4019-phy"; > + #phy-cells = <0>; > + reg = <0xa6000 0x40>; > + reg-names = "phy_base"; > + resets = <&gcc USB3_HSPHY_POR_ARES>, <&gcc USB3_HSPHY_S_ARES>; > + reset-names = "por_rst", "srif_rst"; > + status = "disabled"; > + }; > + > + usb3: usb3@8af8800 { > + compatible = "qcom,dwc3"; > + reg = <0x8af8800 0x100>; > + #address-cells = <1>; > + #size-cells = <1>; > + clocks = <&gcc GCC_USB3_MASTER_CLK>, > + <&gcc GCC_USB3_SLEEP_CLK>, > + <&gcc GCC_USB3_MOCK_UTMI_CLK>; > + clock-names = "master", "sleep", "mock_utmi"; > + ranges; > + status = "disabled"; > + > + dwc3@8a00000 { > + compatible = "snps,dwc3"; > + reg = <0x8a00000 0xf8000>; > + interrupts = ; > + phys = <&usb3_hs_phy>, <&usb3_ss_phy>; > + phy-names = "usb2-phy", "usb3-phy"; > + dr_mode = "host"; > + }; > + }; > + > + usb2_hs_phy: hsphy@a8000 { > + compatible = "qcom,usb-hs-ipq4019-phy"; > + #phy-cells = <0>; > + reg = <0xa8000 0x40>; > + reg-names = "phy_base"; > + resets = <&gcc USB2_HSPHY_POR_ARES>, <&gcc USB2_HSPHY_S_ARES>; > + reset-names = "por_rst", "srif_rst"; > + status = "disabled"; > + }; > + > + usb2: usb2@60f8800 { > + compatible = "qcom,dwc3"; > + reg = <0x60f8800 0x100>; > + #address-cells = <1>; > + #size-cells = <1>; > + clocks = <&gcc GCC_USB2_MASTER_CLK>, > + <&gcc GCC_USB2_SLEEP_CLK>, > + <&gcc GCC_USB2_MOCK_UTMI_CLK>; > + clock-names = "master", "sleep", "mock_utmi"; > + ranges; > + status = "disabled"; > + > + dwc3@6000000 { > + compatible = "snps,dwc3"; > + reg = <0x6000000 0xf8000>; > + interrupts = ; > + phys = <&usb2_hs_phy>; > + phy-names = "usb2-phy"; > + dr_mode = "host"; > + }; > + }; > }; > }; > -- > 2.26.2 Hi, Any chance of reviewing this? Regards, Robert >