From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C2FC07E98 for ; Mon, 5 Jul 2021 08:09:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1740613C2 for ; Mon, 5 Jul 2021 08:09:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230073AbhGEIMI (ORCPT ); Mon, 5 Jul 2021 04:12:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230032AbhGEIMG (ORCPT ); Mon, 5 Jul 2021 04:12:06 -0400 Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86686C061762 for ; Mon, 5 Jul 2021 01:09:30 -0700 (PDT) Received: by mail-io1-xd2e.google.com with SMTP id u7so17800598ion.3 for ; Mon, 05 Jul 2021 01:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6ZBH9ykzeoMrqSlrgZpvseA7xgJC3UHZbKlTJSyxYYE=; b=vMJVUcrQnNHyGr1e2E/BBoCJ6Ml9vmYjG8w3y4ezQrmHEogj/M4Ky5n/R11b3OUHP+ GA0To8jdS+EcmI5/P9/WIwMSOKXzdcpQ56ciPZXsLuzhCebjrvgAjKMVj0ZSx/Rh9bv+ oXlnbv/La5iOfvDexZJU47ZVPg07ff2LAUCfOgs6Y1t84ZdmUZwHHXcFdMnDGr08ohIi jAg4g2iJ6DEwZqa8bdRZInOXHa9ciiu9rr19zEl8/2xix+m5y77dPZvww9IhHTwvkUIg fume5Bf4qhsquNTGV8+6wI8MJW55gP3FMqs1E+rG3ZTrB4s3NzG7t1aErBKD70HBEFdZ dY8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6ZBH9ykzeoMrqSlrgZpvseA7xgJC3UHZbKlTJSyxYYE=; b=tRQF5fbUGuOsCGhU125B63PZRa8PaYLCLcx0KrFTWQsPV6qo+YD4paSBJicptX+3/V hEL1661kw91t2yg1Dy3+RcR1jlAYc+zJVg5x/EVT45ZX1jMAOn5fSI29/ELnH8I8Tr4H ODvSCbr4HFhuEI5y2GJMdjPi8XzZuj9IdCmA6KH2dItHymitQKMsPycklKrtNU6f96hD i3DfeZDgmzsuwC+73Oo94qH1V26idTcO5bXd7FA9lHOro9/8NX6DUHEkcPdQ0zYXQ7jc jtAcEz5VkFE/YFjLj6hnt0rlJ9dyKFTMFv9ilLjGWwWfynN7Tx9UAAI7/juKQYP1BMoG FYuQ== X-Gm-Message-State: AOAM533PXEHZS+1nR4bbrTy4a270v9jPd8xmisc9X/PtBzAtqtV8RJRA eq5WdV4YzsOyVMWNmydJhWTv+6vV7gP3gR5oSm0NDQ== X-Google-Smtp-Source: ABdhPJwhLvFCwfzhhvvHGLbA3HvWk2qBShYvoOt9KTiT7lVNLd4KXAYWkrfEYA95oI9qjWhL1m8bENMubRJRcwBEMEc= X-Received: by 2002:a5e:a612:: with SMTP id q18mr10954029ioi.76.1625472569703; Mon, 05 Jul 2021 01:09:29 -0700 (PDT) MIME-Version: 1.0 References: <1624428350-1424-1-git-send-email-kyrie.wu@mediatek.com> <1624428350-1424-2-git-send-email-kyrie.wu@mediatek.com> <1625039759.22769.3.camel@mhfsdcap03> In-Reply-To: <1625039759.22769.3.camel@mhfsdcap03> From: Tzung-Bi Shih Date: Mon, 5 Jul 2021 16:09:18 +0800 Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: mtk-jpeg: Add binding for MT8195 JPG To: "kyrie.wu" Cc: Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Rick Chang , Bin Liu , Matthias Brugger , Tzung-Bi Shih , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Tomasz Figa , xia.jiang@mediatek.com, maoguang.meng@mediatek.com, srv_heupstream@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jun 30, 2021 at 3:56 PM kyrie.wu wrote: > Mt8195 has two hardwares, "mediatek,mt8195-jpgenc0" for hw0 and > "mediatek,mt8195-jpgenc1" for HW1. These two nodes will register > hardware interrupt, initialize clock, power domain, remap register base > addr and other operations. But the device node is not registered. > "mediatek,mt8195-jpgenc" will register the device node to represent jpeg > encode device. Then the component framework is used to manage the above > two hardwares. Please don't top-posting. Inline your replies so that people can easily follow the discussion. I still don't quite understand why it needs to introduce 2 compatible strings. If hw0 and hw1 are different from interrupts, clocks, power domain, and etc, couldn't you use the same compatible string (e.g. "mt8195-jpgenc") and provide them different DT attributes? > On Fri, 2021-06-25 at 17:18 +0800, Tzung-Bi Shih wrote: > > On Wed, Jun 23, 2021 at 2:06 PM kyrie.wu wrote: > > > Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.txt | 3 +++ > > > 1 file changed, 3 insertions(+) > > Note: the patch won't apply after [1]. > > > > [1]: https://lore.kernel.org/patchwork/patch/1445298/ > > > > > Required properties: > > > - compatible : "mediatek,mt2701-jpgenc" > > > +- compatible : "mediatek,mt8195-jpgenc" > > > +- compatible : "mediatek,mt8195-jpgenc0" > > > +- compatible : "mediatek,mt8195-jpgenc1" > > Why it needs 3 compatible strings?