From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96C43C55179 for ; Fri, 30 Oct 2020 09:23:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 392E42076E for ; Fri, 30 Oct 2020 09:23:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UO5IfL8R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725790AbgJ3JXW (ORCPT ); Fri, 30 Oct 2020 05:23:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725888AbgJ3JXW (ORCPT ); Fri, 30 Oct 2020 05:23:22 -0400 Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FB84C0613D4 for ; Fri, 30 Oct 2020 02:23:22 -0700 (PDT) Received: by mail-io1-xd41.google.com with SMTP id k6so6815513ior.2 for ; Fri, 30 Oct 2020 02:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CBA+zo6LaSoFeL0OA7IbUTdbUJNI/GOykxoTxkhm2nk=; b=UO5IfL8R5QFcwjro3zMCatag08rvnj7MG+rIfVf8CZY1PLx4Z0SoVQtu3DvG/0uf2N YIRVCW8AOfZZVXKBcMTqoLCPZMQ5Kdr+w2h4Jyf/fzhu6jZud64aAlrfyOQbqcC7FZig 6RxtRmtJurOtE9CKuMpk1+tU/vGvKGRNHkDxmw8yP7WTwOpd+GVyHY20Brqmw6oBEwuq QvZM45AWJDmHUwcapmaYrBa+pQ32oebVFliheC058EYqeCLz6IBmN6i+RIW2LIsORGah PPcv4Mf1Xo6nq/dRGbcCEpsqtymMwkMc30l3lLgjDsRtVNql2yXNOini1QEbK9TJHv/h xoFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CBA+zo6LaSoFeL0OA7IbUTdbUJNI/GOykxoTxkhm2nk=; b=QWn/MWfsGyFfwNFaM49Ndoe7Zv4o+3GqRQahk/hKyYbvEArwEoBWRMXmQ1i13YbCvX 4Z+Moo6TVrgRgKiFhItuEj6LR64ilroBBDc5LB7kjMDKOP7CqM0JzluF570sCSjCQ7Ry XJDnxUzhsyxmXWUTKjfRyLB7oJGAh2UDNPrSP8m0Kn8KSyo8et169jWapB4qtB7EiW2J UIFc7pl1az5yyI66frdZUeB+HHH4rJXH+IlTeGI5ICq18ScK+tNB40wonI5EHRmRbk+G VSHUxYtSe1njgxwrcOENZ/QihTy2daoLDG47HWfMoaU8f51mAyQr9/uykDAYLNEmdDb9 VYYw== X-Gm-Message-State: AOAM532MQH0q1s2NTPpoR7xKhMz0xmSWKvgPvcctWqzqpUAA4Ar6VoHc VwSzW0khKf5linc6P1U6yXTbdNhaAV2vC6Uxx+YoaA== X-Google-Smtp-Source: ABdhPJyH+9c8dw1FcU0h83mbgXToEcZDNuIgSVvIgnpkYquj90LicUxQtsuxCBKhNY9sYkw8F9Rt7qhEa3t2HuwKEyA= X-Received: by 2002:a6b:c8c1:: with SMTP id y184mr1050821iof.109.1604049801372; Fri, 30 Oct 2020 02:23:21 -0700 (PDT) MIME-Version: 1.0 References: <20201030075724.1616766-1-ajye_huang@compal.corp-partner.google.com> <20201030075724.1616766-3-ajye_huang@compal.corp-partner.google.com> In-Reply-To: <20201030075724.1616766-3-ajye_huang@compal.corp-partner.google.com> From: Tzung-Bi Shih Date: Fri, 30 Oct 2020 17:23:10 +0800 Message-ID: Subject: Re: [PATCH v2 2/2] ASoC: qcom: sc7180: Modify machine driver for 2mic To: Ajye Huang Cc: Linux Kernel Mailing List , Mark Brown , Rohit kumar , Banajit Goswami , Patrick Lai , Srinivasa Rao Mandadapu , Srini Kandagatla , Andy Gross , Bjorn Andersson , Liam Girdwood , Rob Herring , Jaroslav Kysela , Cheng-Yi Chiang , Tzung-Bi Shih , Douglas Anderson , "moderated list:ARM/Mediatek SoC support" , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , ALSA development , Ajye Huang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Oct 30, 2020 at 3:57 PM Ajye Huang wrote: > +static struct gpio_desc *dmic_sel; > +static int dmic_switch; If you really need them, you should put them in struct sc7180_snd_data. > +static int dmic_set(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + if (dmic_sel) { if (IS_ERR(dmic_sel)) But I think you don't need to check dmic_sel. Suppose your _probe() already returned error, the code here shouldn't be called. > + dmic_switch = ucontrol->value.integer.value[0]; Looks like it can be a local variable. You don't need to save dmic_switch.