devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: iwg22d-sodimm: Fix dt nodes sorting
@ 2020-07-29 12:26 Biju Das
  2020-07-29 20:38 ` Lad, Prabhakar
  2020-08-05 11:41 ` Geert Uytterhoeven
  0 siblings, 2 replies; 4+ messages in thread
From: Biju Das @ 2020-07-29 12:26 UTC (permalink / raw)
  To: Rob Herring
  Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, linux-renesas-soc,
	devicetree, Chris Paterson, Biju Das, Prabhakar Mahadev Lad

Some device nodes in the r8a7745-iwg22d-sodimm.dts are not sorted
alphabetically. This patch fixes the sorting of nodes and also fixes a
typo in the stmpe node.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
This patch is tested against renesas-devel
---
 arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts | 104 ++++++++++----------
 1 file changed, 52 insertions(+), 52 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
index b15b1b088a32..5f7f230de529 100644
--- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
+++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
@@ -53,6 +53,25 @@
 		clock-frequency = <26000000>;
 	};
 
+	backlight_lcd: backlight {
+		compatible = "pwm-backlight";
+		pwms = <&tpu 3 5000000 PWM_POLARITY_INVERTED>;
+		brightness-levels = <0 4 8 16 32 64 128 255>;
+		default-brightness-level = <7>;
+	};
+
+	lcd_panel: lcd {
+		compatible = "edt,etm043080dh6gp";
+		power-supply = <&vccq_panel>;
+		backlight = <&backlight_lcd>;
+
+		port {
+			lcd_in: endpoint {
+				remote-endpoint = <&du_out_rgb0>;
+			};
+		};
+	};
+
 	rsnd_sgtl5000: sound {
 		compatible = "simple-audio-card";
 		simple-audio-card,format = "i2s";
@@ -68,18 +87,6 @@
 		};
 	};
 
-	vccq_sdhi0: regulator-vccq-sdhi0 {
-		compatible = "regulator-gpio";
-
-		regulator-name = "SDHI0 VccQ";
-		regulator-min-microvolt = <1800000>;
-		regulator-max-microvolt = <3300000>;
-
-		gpios = <&gpio0 20 GPIO_ACTIVE_LOW>;
-		gpios-states = <1>;
-		states = <3300000 1>, <1800000 0>;
-	};
-
 	vccq_panel: regulator-vccq-panel {
 		compatible = "regulator-fixed";
 		regulator-name = "Panel VccQ";
@@ -89,38 +96,16 @@
 		enable-active-high;
 	};
 
-	backlight_lcd: backlight {
-		compatible = "pwm-backlight";
-		pwms = <&tpu 3 5000000 PWM_POLARITY_INVERTED>;
-		brightness-levels = <0 4 8 16 32 64 128 255>;
-		default-brightness-level = <7>;
-	};
-
-	lcd_panel: lcd {
-		compatible = "edt,etm043080dh6gp";
-		power-supply = <&vccq_panel>;
-		backlight = <&backlight_lcd>;
-
-		port {
-			lcd_in: endpoint {
-				remote-endpoint = <&du_out_rgb0>;
-			};
-		};
-	};
-};
-
-&du {
-	pinctrl-0 = <&du0_pins>;
-	pinctrl-names = "default";
+	vccq_sdhi0: regulator-vccq-sdhi0 {
+		compatible = "regulator-gpio";
 
-	status = "okay";
+		regulator-name = "SDHI0 VccQ";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <3300000>;
 
-	ports {
-		port@0 {
-			endpoint {
-				remote-endpoint = <&lcd_in>;
-			};
-		};
+		gpios = <&gpio0 20 GPIO_ACTIVE_LOW>;
+		gpios-states = <1>;
+		states = <3300000 1>, <1800000 0>;
 	};
 };
 
@@ -150,6 +135,21 @@
 	status = "okay";
 };
 
+&du {
+	pinctrl-0 = <&du0_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+
+	ports {
+		port@0 {
+			endpoint {
+				remote-endpoint = <&lcd_in>;
+			};
+		};
+	};
+};
+
 &hscif1 {
 	pinctrl-0 = <&hscif1_pins>;
 	pinctrl-names = "default";
@@ -171,6 +171,15 @@
 	status = "okay";
 	clock-frequency = <400000>;
 
+	sgtl5000: codec@a {
+		compatible = "fsl,sgtl5000";
+		#sound-dai-cells = <0>;
+		reg = <0x0a>;
+		clocks = <&audio_clock>;
+		VDDA-supply = <&reg_3p3v>;
+		VDDIO-supply = <&reg_3p3v>;
+	};
+
 	stmpe811@44 {
 		compatible = "st,stmpe811";
 		reg = <0x44>;
@@ -179,7 +188,7 @@
 
 		/* 3.25 MHz ADC clock speed */
 		st,adc-freq = <1>;
-		/* ADC converstion time: 80 clocks */
+		/* ADC conversion time: 80 clocks */
 		st,sample-time = <4>;
 		/* 12-bit ADC */
 		st,mod-12b = <1>;
@@ -203,15 +212,6 @@
 			st,touch-det-delay = <5>;
 		};
 	};
-
-	sgtl5000: codec@a {
-		compatible = "fsl,sgtl5000";
-		#sound-dai-cells = <0>;
-		reg = <0x0a>;
-		clocks = <&audio_clock>;
-		VDDA-supply = <&reg_3p3v>;
-		VDDIO-supply = <&reg_3p3v>;
-	};
 };
 
 &pci1 {
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: iwg22d-sodimm: Fix dt nodes sorting
  2020-07-29 12:26 [PATCH] ARM: dts: iwg22d-sodimm: Fix dt nodes sorting Biju Das
@ 2020-07-29 20:38 ` Lad, Prabhakar
  2020-08-05 11:41 ` Geert Uytterhoeven
  1 sibling, 0 replies; 4+ messages in thread
From: Lad, Prabhakar @ 2020-07-29 20:38 UTC (permalink / raw)
  To: Biju Das
  Cc: Rob Herring, Geert Uytterhoeven, Magnus Damm, Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Biju Das, Prabhakar Mahadev Lad

Hi Biju,

Thank you for the patch.

On Wed, Jul 29, 2020 at 1:26 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
>
> Some device nodes in the r8a7745-iwg22d-sodimm.dts are not sorted
> alphabetically. This patch fixes the sorting of nodes and also fixes a
> typo in the stmpe node.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> This patch is tested against renesas-devel
> ---
>  arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts | 104 ++++++++++----------
>  1 file changed, 52 insertions(+), 52 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> index b15b1b088a32..5f7f230de529 100644
> --- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> +++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> @@ -53,6 +53,25 @@
>                 clock-frequency = <26000000>;
>         };
>
> +       backlight_lcd: backlight {
> +               compatible = "pwm-backlight";
> +               pwms = <&tpu 3 5000000 PWM_POLARITY_INVERTED>;
> +               brightness-levels = <0 4 8 16 32 64 128 255>;
> +               default-brightness-level = <7>;
> +       };
> +
> +       lcd_panel: lcd {
> +               compatible = "edt,etm043080dh6gp";
> +               power-supply = <&vccq_panel>;
> +               backlight = <&backlight_lcd>;
> +
> +               port {
> +                       lcd_in: endpoint {
> +                               remote-endpoint = <&du_out_rgb0>;
> +                       };
> +               };
> +       };
> +
>         rsnd_sgtl5000: sound {
>                 compatible = "simple-audio-card";
>                 simple-audio-card,format = "i2s";
> @@ -68,18 +87,6 @@
>                 };
>         };
>
> -       vccq_sdhi0: regulator-vccq-sdhi0 {
> -               compatible = "regulator-gpio";
> -
> -               regulator-name = "SDHI0 VccQ";
> -               regulator-min-microvolt = <1800000>;
> -               regulator-max-microvolt = <3300000>;
> -
> -               gpios = <&gpio0 20 GPIO_ACTIVE_LOW>;
> -               gpios-states = <1>;
> -               states = <3300000 1>, <1800000 0>;
> -       };
> -
>         vccq_panel: regulator-vccq-panel {
>                 compatible = "regulator-fixed";
>                 regulator-name = "Panel VccQ";
> @@ -89,38 +96,16 @@
>                 enable-active-high;
>         };
>
> -       backlight_lcd: backlight {
> -               compatible = "pwm-backlight";
> -               pwms = <&tpu 3 5000000 PWM_POLARITY_INVERTED>;
> -               brightness-levels = <0 4 8 16 32 64 128 255>;
> -               default-brightness-level = <7>;
> -       };
> -
> -       lcd_panel: lcd {
> -               compatible = "edt,etm043080dh6gp";
> -               power-supply = <&vccq_panel>;
> -               backlight = <&backlight_lcd>;
> -
> -               port {
> -                       lcd_in: endpoint {
> -                               remote-endpoint = <&du_out_rgb0>;
> -                       };
> -               };
> -       };
> -};
> -
> -&du {
> -       pinctrl-0 = <&du0_pins>;
> -       pinctrl-names = "default";
> +       vccq_sdhi0: regulator-vccq-sdhi0 {
> +               compatible = "regulator-gpio";
>
> -       status = "okay";
> +               regulator-name = "SDHI0 VccQ";
> +               regulator-min-microvolt = <1800000>;
> +               regulator-max-microvolt = <3300000>;
>
> -       ports {
> -               port@0 {
> -                       endpoint {
> -                               remote-endpoint = <&lcd_in>;
> -                       };
> -               };
> +               gpios = <&gpio0 20 GPIO_ACTIVE_LOW>;
> +               gpios-states = <1>;
> +               states = <3300000 1>, <1800000 0>;
>         };
>  };
>
> @@ -150,6 +135,21 @@
>         status = "okay";
>  };
>
> +&du {
> +       pinctrl-0 = <&du0_pins>;
> +       pinctrl-names = "default";
> +
> +       status = "okay";
> +
> +       ports {
> +               port@0 {
> +                       endpoint {
> +                               remote-endpoint = <&lcd_in>;
> +                       };
> +               };
> +       };
> +};
> +
>  &hscif1 {
>         pinctrl-0 = <&hscif1_pins>;
>         pinctrl-names = "default";
> @@ -171,6 +171,15 @@
>         status = "okay";
>         clock-frequency = <400000>;
>
> +       sgtl5000: codec@a {
> +               compatible = "fsl,sgtl5000";
> +               #sound-dai-cells = <0>;
> +               reg = <0x0a>;
> +               clocks = <&audio_clock>;
> +               VDDA-supply = <&reg_3p3v>;
> +               VDDIO-supply = <&reg_3p3v>;
> +       };
> +
>         stmpe811@44 {
>                 compatible = "st,stmpe811";
>                 reg = <0x44>;
> @@ -179,7 +188,7 @@
>
>                 /* 3.25 MHz ADC clock speed */
>                 st,adc-freq = <1>;
> -               /* ADC converstion time: 80 clocks */
> +               /* ADC conversion time: 80 clocks */
>                 st,sample-time = <4>;
>                 /* 12-bit ADC */
>                 st,mod-12b = <1>;
> @@ -203,15 +212,6 @@
>                         st,touch-det-delay = <5>;
>                 };
>         };
> -
> -       sgtl5000: codec@a {
> -               compatible = "fsl,sgtl5000";
> -               #sound-dai-cells = <0>;
> -               reg = <0x0a>;
> -               clocks = <&audio_clock>;
> -               VDDA-supply = <&reg_3p3v>;
> -               VDDIO-supply = <&reg_3p3v>;
> -       };
>  };
>
>  &pci1 {
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: iwg22d-sodimm: Fix dt nodes sorting
  2020-07-29 12:26 [PATCH] ARM: dts: iwg22d-sodimm: Fix dt nodes sorting Biju Das
  2020-07-29 20:38 ` Lad, Prabhakar
@ 2020-08-05 11:41 ` Geert Uytterhoeven
  2020-08-05 12:16   ` Biju Das
  1 sibling, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2020-08-05 11:41 UTC (permalink / raw)
  To: Biju Das
  Cc: Rob Herring, Magnus Damm, Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Biju Das, Prabhakar Mahadev Lad

Hi Biju,

On Wed, Jul 29, 2020 at 2:26 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Some device nodes in the r8a7745-iwg22d-sodimm.dts are not sorted
> alphabetically. This patch fixes the sorting of nodes and also fixes a
> typo in the stmpe node.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Thanks for your patch!

> --- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> +++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> @@ -53,6 +53,25 @@
>                 clock-frequency = <26000000>;
>         };
>
> +       backlight_lcd: backlight {
> +               compatible = "pwm-backlight";
> +               pwms = <&tpu 3 5000000 PWM_POLARITY_INVERTED>;
> +               brightness-levels = <0 4 8 16 32 64 128 255>;
> +               default-brightness-level = <7>;
> +       };
> +
> +       lcd_panel: lcd {
> +               compatible = "edt,etm043080dh6gp";
> +               power-supply = <&vccq_panel>;
> +               backlight = <&backlight_lcd>;
> +
> +               port {
> +                       lcd_in: endpoint {
> +                               remote-endpoint = <&du_out_rgb0>;
> +                       };
> +               };
> +       };
> +
>         rsnd_sgtl5000: sound {

Shouldn't the sound node be moved below the regulator nodes?

>                 compatible = "simple-audio-card";
>                 simple-audio-card,format = "i2s";
> @@ -68,18 +87,6 @@
>                 };
>         };
>
> -       vccq_sdhi0: regulator-vccq-sdhi0 {
> -               compatible = "regulator-gpio";
> -
> -               regulator-name = "SDHI0 VccQ";
> -               regulator-min-microvolt = <1800000>;
> -               regulator-max-microvolt = <3300000>;
> -
> -               gpios = <&gpio0 20 GPIO_ACTIVE_LOW>;
> -               gpios-states = <1>;
> -               states = <3300000 1>, <1800000 0>;
> -       };
> -
>         vccq_panel: regulator-vccq-panel {
>                 compatible = "regulator-fixed";
>                 regulator-name = "Panel VccQ";

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [PATCH] ARM: dts: iwg22d-sodimm: Fix dt nodes sorting
  2020-08-05 11:41 ` Geert Uytterhoeven
@ 2020-08-05 12:16   ` Biju Das
  0 siblings, 0 replies; 4+ messages in thread
From: Biju Das @ 2020-08-05 12:16 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Rob Herring, Magnus Damm, Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Biju Das, Prabhakar Mahadev Lad

Hi Geert,

Thanks for the feedback.


> Subject: Re: [PATCH] ARM: dts: iwg22d-sodimm: Fix dt nodes sorting
>
> Hi Biju,
>
> On Wed, Jul 29, 2020 at 2:26 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > Some device nodes in the r8a7745-iwg22d-sodimm.dts are not sorted
> > alphabetically. This patch fixes the sorting of nodes and also fixes a
> > typo in the stmpe node.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> > +++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> > @@ -53,6 +53,25 @@
> >                 clock-frequency = <26000000>;
> >         };
> >
> > +       backlight_lcd: backlight {
> > +               compatible = "pwm-backlight";
> > +               pwms = <&tpu 3 5000000 PWM_POLARITY_INVERTED>;
> > +               brightness-levels = <0 4 8 16 32 64 128 255>;
> > +               default-brightness-level = <7>;
> > +       };
> > +
> > +       lcd_panel: lcd {
> > +               compatible = "edt,etm043080dh6gp";
> > +               power-supply = <&vccq_panel>;
> > +               backlight = <&backlight_lcd>;
> > +
> > +               port {
> > +                       lcd_in: endpoint {
> > +                               remote-endpoint = <&du_out_rgb0>;
> > +                       };
> > +               };
> > +       };
> > +
> >         rsnd_sgtl5000: sound {
>
> Shouldn't the sound node be moved below the regulator nodes?

Yes I agree. sorting should be as per node names, not based on the labels. I will send V2.

Regards,
Biju

> >                 compatible = "simple-audio-card";
> >                 simple-audio-card,format = "i2s"; @@ -68,18 +87,6 @@
> >                 };
> >         };
> >
> > -       vccq_sdhi0: regulator-vccq-sdhi0 {
> > -               compatible = "regulator-gpio";
> > -
> > -               regulator-name = "SDHI0 VccQ";
> > -               regulator-min-microvolt = <1800000>;
> > -               regulator-max-microvolt = <3300000>;
> > -
> > -               gpios = <&gpio0 20 GPIO_ACTIVE_LOW>;
> > -               gpios-states = <1>;
> > -               states = <3300000 1>, <1800000 0>;
> > -       };
> > -
> >         vccq_panel: regulator-vccq-panel {
> >                 compatible = "regulator-fixed";
> >                 regulator-name = "Panel VccQ";
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-05 17:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-29 12:26 [PATCH] ARM: dts: iwg22d-sodimm: Fix dt nodes sorting Biju Das
2020-07-29 20:38 ` Lad, Prabhakar
2020-08-05 11:41 ` Geert Uytterhoeven
2020-08-05 12:16   ` Biju Das

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).