From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Rob Herring <robh+dt@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-iio@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: Add binding documentation for Renesas RZ/G2L A/D converter
Date: Wed, 14 Jul 2021 10:11:49 +0100 [thread overview]
Message-ID: <CA+V-a8uzeepfd+8Wfd2n2EXeXQ9QJZhR+X8j29Y7DGNu8+aH+g@mail.gmail.com> (raw)
In-Reply-To: <20210703181937.510ec0fa@jic23-huawei>
Hi Jonathan,
Thank you for the review.
On Sat, Jul 3, 2021 at 6:17 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Tue, 29 Jun 2021 23:03:27 +0100
> Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
>
> > Add binding documentation for Renesas RZ/G2L A/D converter block.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> Hi,
>
> See inline
>
> Jonathan
>
> > ---
> > .../bindings/iio/adc/renesas,rzg2l-adc.yaml | 121 ++++++++++++++++++
> > 1 file changed, 121 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml b/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml
> > new file mode 100644
> > index 000000000000..db935d6d59eb
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml
> > @@ -0,0 +1,121 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/adc/renesas,rzg2l-adc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Renesas RZ/G2L ADC
> > +
> > +maintainers:
> > + - Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > +
> > +description: |
> > + A/D Converter block is a successive approximation analog-to-digital converter
> > + with a 12-bit accuracy. Up to eight analog input channels can be selected.
> > + Conversions can be performed in single or repeat mode. Result of the ADC is
> > + stored in a 32-bit data register corresponding to each channel.
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - enum:
> > + - renesas,r9a07g044-adc # RZ/G2{L,LC}
> > + - const: renesas,rzg2l-adc
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + items:
> > + - description: converter clock
> > + - description: peripheral clock
> > +
> > + clock-names:
> > + items:
> > + - const: adclk
> > + - const: pclk
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > + resets:
> > + maxItems: 2
> > +
> > + reset-names:
> > + items:
> > + - const: presetn
> > + - const: adrst-n
> > +
> > + renesas-rzg2l,adc-trigger-mode:
> > + $ref: /schemas/types.yaml#/definitions/uint8
> > + description: Trigger mode for A/D converter
> > + enum:
> > + - 0 # Software trigger mode (Defaults)
> > + - 1 # Asynchronous trigger using ADC_TRG trigger input pin
> > + - 2 # Synchronous trigger (Trigger from MTU3a/GPT)
>
> Is this a function of the board in some fashion? If not it sounds like
> something that should be in control of userspace. Normally we'd
> do that by having the driver register some iio_triggers and depending
> on which one is selected do the equivalent of what you have here.
>
Agreed for Asynchronous and Synchronous triggers. WRT Software trigger
should this be registered as a iio_triggers too or read_raw()
callback (with IIO_CHAN_INFO_RAW case) should be treated as Software
trigger?
> > + default: 0
> > +
> > + gpios:
> > + description:
> > + ADC_TRG trigger input pin
> > + maxItems: 1
> Why is this mode useful? I'm assuming the gpio write would take a register
> write and the software trigger mode also requires a register write.
>
Yes gpio write would take a register write.
> Normally the reason for a pin like this is to support synchronising with
> external hardware. If that's the case, we should call that out here.
> often the pin isn't even connected to a gpio in our control.
> (i.e. it's a trigger signal from some other device.)
>
So just setting the GPIO pin as input should do the trick.
> > +
> > + renesas-rzg2l,adc-channels:
> > + $ref: /schemas/types.yaml#/definitions/uint8-array
> > + description: Input channels available on platform
> > + uniqueItems: true
> > + minItems: 1
> > + maxItems: 8
> > + items:
> > + enum: [0, 1, 2, 3, 4, 5, 6, 7]
>
> Is this a function of different devices (should have different compatibles)
> or of what is wired up. If it's what is wired up, then how do you know which
Its channels which are wired, for example if channels 0-5 are wired up
the board dts would include the property "renesas-rzg2l,adc-channels =
/bits/ 8 <0 1 2 3 4 5>;"
> subset of channels are connected? We have the generic adc channel binding
> in iio/adc/adc.yaml for the case where we only want to expose those channels
> that are wired up. It uses a node per channel.
>
Agreed will do that and drop the custom "renesas-rzg2l,adc-channels"
Cheers,
Prabhakar
> > +
> > + "#io-channel-cells":
> > + const: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - clocks
> > + - clock-names
> > + - power-domains
> > + - resets
> > + - reset-names
> > + - renesas-rzg2l,adc-channels
> > + - "#io-channel-cells"
> > +
> > +allOf:
> > + - if:
> > + properties:
> > + renesas-rzg2l,adc-trigger-mode:
> > + const: 1
> > + then:
> > + required:
> > + - gpios
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/r9a07g044-cpg.h>
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > + adc: adc@10059000 {
> > + compatible = "renesas,r9a07g044-adc", "renesas,rzg2l-adc";
> > + reg = <0x10059000 0x400>;
> > + interrupts = <GIC_SPI 347 IRQ_TYPE_EDGE_RISING>;
> > + clocks = <&cpg CPG_MOD R9A07G044_ADC_ADCLK>,
> > + <&cpg CPG_MOD R9A07G044_ADC_PCLK>;
> > + clock-names = "adclk", "pclk";
> > + power-domains = <&cpg>;
> > + resets = <&cpg R9A07G044_ADC_PRESETN>,
> > + <&cpg R9A07G044_ADC_ADRST_N>;
> > + reset-names = "presetn", "adrst-n";
> > + #io-channel-cells = <1>;
> > + renesas-rzg2l,adc-trigger-mode = /bits/ 8 <0>;
> > + renesas-rzg2l,adc-channels = /bits/ 8 <0 1 2 3 4 5 6>;
> > + };
>
next prev parent reply other threads:[~2021-07-14 9:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 22:03 [PATCH 0/2] Renesas RZ/G2L ADC driver support Lad Prabhakar
2021-06-29 22:03 ` [PATCH 1/2] dt-bindings: iio: adc: Add binding documentation for Renesas RZ/G2L A/D converter Lad Prabhakar
2021-07-01 14:02 ` Rob Herring
2021-07-01 20:21 ` Rob Herring
2021-07-13 16:00 ` Lad, Prabhakar
2021-07-13 16:32 ` Geert Uytterhoeven
2021-07-13 16:39 ` Lad, Prabhakar
2021-07-03 17:19 ` Jonathan Cameron
2021-07-14 9:11 ` Lad, Prabhakar [this message]
2021-07-14 12:39 ` Jonathan Cameron
2021-07-14 18:24 ` Lad, Prabhakar
2021-07-15 13:02 ` Jonathan Cameron
2021-07-16 15:45 ` Lad, Prabhakar
2021-06-29 22:03 ` [PATCH 2/2] iio: adc: Add driver " Lad Prabhakar
2021-07-01 10:28 ` Alexandru Ardelean
2021-07-03 17:41 ` Jonathan Cameron
2021-07-14 21:31 ` Lad, Prabhakar
2021-07-14 21:25 ` Lad, Prabhakar
2021-07-03 17:21 ` [PATCH 0/2] Renesas RZ/G2L ADC driver support Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+V-a8uzeepfd+8Wfd2n2EXeXQ9QJZhR+X8j29Y7DGNu8+aH+g@mail.gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).