* [PATCH v4 1/2] dt-bindings: input: cros-ec-keyb: Add a new property
@ 2021-01-07 23:42 Philip Chen
2021-01-12 2:10 ` Stephen Boyd
0 siblings, 1 reply; 4+ messages in thread
From: Philip Chen @ 2021-01-07 23:42 UTC (permalink / raw)
To: LKML, dmitry.torokhov
Cc: swboyd, dianders, Philip Chen, Benson Leung,
Enric Balletbo i Serra, Guenter Roeck, Rob Herring, Simon Glass,
devicetree, linux-input
This patch adds a new property `function-row-physmap` to the
device tree for the custom keyboard top row design.
The property describes the rows/columns of the top row keys
from left to right.
Signed-off-by: Philip Chen <philipchen@chromium.org>
---
(no changes since v2)
Changes in v2:
- add `function-row-physmap` instead of `google,custom-keyb-top-row`
.../devicetree/bindings/input/google,cros-ec-keyb.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
index 8e50c14a9d778..7acdb33781d30 100644
--- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
+++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
@@ -31,6 +31,16 @@ properties:
if the EC does not have its own logic or hardware for this.
type: boolean
+ function-row-physmap:
+ $ref: '/schemas/types.yaml#/definitions/uint32-array'
+ description: |
+ An ordered u32 array describing the rows/columns (in the scan matrix)
+ of top row keys from physical left (KEY_F1) to right. Each entry
+ encodes the row/column as:
+ (((row) & 0xFF) << 24) | (((column) & 0xFF) << 16)
+ where the lower 16 bits are reserved. This property is specified only
+ when the keyboard has a custom design for the top row keys.
+
required:
- compatible
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: input: cros-ec-keyb: Add a new property
2021-01-07 23:42 [PATCH v4 1/2] dt-bindings: input: cros-ec-keyb: Add a new property Philip Chen
@ 2021-01-12 2:10 ` Stephen Boyd
2021-01-12 23:29 ` Philip Chen
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2021-01-12 2:10 UTC (permalink / raw)
To: LKML, Philip Chen, dmitry.torokhov
Cc: dianders, Philip Chen, Benson Leung, Enric Balletbo i Serra,
Guenter Roeck, Rob Herring, Simon Glass, devicetree, linux-input
Quoting Philip Chen (2021-01-07 15:42:08)
> This patch adds a new property `function-row-physmap` to the
From Documentation/process/submitting-patches.rst
Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour.
> device tree for the custom keyboard top row design.
>
> The property describes the rows/columns of the top row keys
> from left to right.
>
> Signed-off-by: Philip Chen <philipchen@chromium.org>
> ---
> diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> index 8e50c14a9d778..7acdb33781d30 100644
> --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> @@ -31,6 +31,16 @@ properties:
> if the EC does not have its own logic or hardware for this.
> type: boolean
>
> + function-row-physmap:
Is there any minimum/maximum number of elements possible?
> + $ref: '/schemas/types.yaml#/definitions/uint32-array'
> + description: |
> + An ordered u32 array describing the rows/columns (in the scan matrix)
> + of top row keys from physical left (KEY_F1) to right. Each entry
> + encodes the row/column as:
> + (((row) & 0xFF) << 24) | (((column) & 0xFF) << 16)
> + where the lower 16 bits are reserved. This property is specified only
> + when the keyboard has a custom design for the top row keys.
> +
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: input: cros-ec-keyb: Add a new property
2021-01-12 2:10 ` Stephen Boyd
@ 2021-01-12 23:29 ` Philip Chen
2021-01-13 6:52 ` Stephen Boyd
0 siblings, 1 reply; 4+ messages in thread
From: Philip Chen @ 2021-01-12 23:29 UTC (permalink / raw)
To: Stephen Boyd
Cc: LKML, Dmitry Torokhov, Douglas Anderson, Benson Leung,
Enric Balletbo i Serra, Guenter Roeck, Rob Herring, Simon Glass,
devicetree, linux-input
On Mon, Jan 11, 2021 at 6:10 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Philip Chen (2021-01-07 15:42:08)
> > This patch adds a new property `function-row-physmap` to the
>
> From Documentation/process/submitting-patches.rst
>
> Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
> instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
> to do frotz", as if you are giving orders to the codebase to change
> its behaviour.
I was aware of this guideline, but I thought it only applies to the
summary line.
I'll apply the guideline to the whole description.
Thanks!
>
> > device tree for the custom keyboard top row design.
> >
> > The property describes the rows/columns of the top row keys
> > from left to right.
> >
> > Signed-off-by: Philip Chen <philipchen@chromium.org>
> > ---
> > diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > index 8e50c14a9d778..7acdb33781d30 100644
> > --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > @@ -31,6 +31,16 @@ properties:
> > if the EC does not have its own logic or hardware for this.
> > type: boolean
> >
> > + function-row-physmap:
>
> Is there any minimum/maximum number of elements possible?
The maximum is 15.
There is no definition for the minimum - we can probably say the minimum is 1.
>
> > + $ref: '/schemas/types.yaml#/definitions/uint32-array'
> > + description: |
> > + An ordered u32 array describing the rows/columns (in the scan matrix)
> > + of top row keys from physical left (KEY_F1) to right. Each entry
> > + encodes the row/column as:
> > + (((row) & 0xFF) << 24) | (((column) & 0xFF) << 16)
> > + where the lower 16 bits are reserved. This property is specified only
> > + when the keyboard has a custom design for the top row keys.
> > +
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: input: cros-ec-keyb: Add a new property
2021-01-12 23:29 ` Philip Chen
@ 2021-01-13 6:52 ` Stephen Boyd
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2021-01-13 6:52 UTC (permalink / raw)
To: Philip Chen
Cc: LKML, Dmitry Torokhov, Douglas Anderson, Benson Leung,
Enric Balletbo i Serra, Guenter Roeck, Rob Herring, Simon Glass,
devicetree, linux-input
Quoting Philip Chen (2021-01-12 15:29:11)
> On Mon, Jan 11, 2021 at 6:10 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > Quoting Philip Chen (2021-01-07 15:42:08)
> > > ---
> > > diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > > index 8e50c14a9d778..7acdb33781d30 100644
> > > --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > > +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > > @@ -31,6 +31,16 @@ properties:
> > > if the EC does not have its own logic or hardware for this.
> > > type: boolean
> > >
> > > + function-row-physmap:
> >
> > Is there any minimum/maximum number of elements possible?
> The maximum is 15.
> There is no definition for the minimum - we can probably say the minimum is 1.
Ok cool. Please add min/max of 1 to 15 to the binding.
> >
> > > + $ref: '/schemas/types.yaml#/definitions/uint32-array'
> > > + description: |
> > > + An ordered u32 array describing the rows/columns (in the scan matrix)
> > > + of top row keys from physical left (KEY_F1) to right. Each entry
> > > + encodes the row/column as:
> > > + (((row) & 0xFF) << 24) | (((column) & 0xFF) << 16)
> > > + where the lower 16 bits are reserved. This property is specified only
> > > + when the keyboard has a custom design for the top row keys.
> > > +
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-13 6:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 23:42 [PATCH v4 1/2] dt-bindings: input: cros-ec-keyb: Add a new property Philip Chen
2021-01-12 2:10 ` Stephen Boyd
2021-01-12 23:29 ` Philip Chen
2021-01-13 6:52 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).