From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C72DC56202 for ; Thu, 12 Nov 2020 12:41:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F44B2224B for ; Thu, 12 Nov 2020 12:41:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iW1jERex" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727035AbgKLMlz (ORCPT ); Thu, 12 Nov 2020 07:41:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727899AbgKLMly (ORCPT ); Thu, 12 Nov 2020 07:41:54 -0500 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF81AC0613D6 for ; Thu, 12 Nov 2020 04:41:53 -0800 (PST) Received: by mail-oi1-x241.google.com with SMTP id o25so6207989oie.5 for ; Thu, 12 Nov 2020 04:41:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1xPF1Lz4nYrB6C/anWXLAqDEnq22PRnhe5LG+L020aI=; b=iW1jERexvQ1poJctwFKEjsfG+AJO62Hu/YEdjGXy5qhtBWMORngcS19a8CUANUQJBZ cPjxno1FNV04E3Oa+SJdWZY6UcMprEdExZfqX0TJ6OrU+98QlL1XGh4+toNkUNMs3O1a o0P2Z91VkVXGOHCvy03gUcX82Qus0Omid6PqXUBcFqzqi3IKloRCef/lbtm8+VfmiYK3 ACTozLts8w7s8uy6dEOxr+Tf11PxT0wIdSK+hFlNTUwIcdz5Wod/xY+QeOtqZQc+dmUu 1BINXe0cqdPnh2Lwq284JAljvQ/XrjTUE08qcnM4PSrvsvN/O5LPgpFU6HVUDOblug4h XB9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1xPF1Lz4nYrB6C/anWXLAqDEnq22PRnhe5LG+L020aI=; b=aAxk3lA148O5br810Asf/6FZgeZYAfKf/bw6bEmFxIMHOXHwrPVWRbDG9Xr2aJzIOT gcpeiXbXzGfajt40SPsdJMcneXHtm73DQPIvoZIOjXleh8nNxjqlY3x7F4PwgFq2HPYt Lcqhxf0eKYoBlfFxG2DEMOAXF15EArp1/HfqFbKFHV/akuWKYU/cXrD6QaZqRGBVjHVQ yiYKZ6rEZE+WrxDqN0d7S+IBzoupQNTPOxf/ojY6hA77j4Grlyw+buhNh+nWd/CI2jgA PUhew2GLm2BTl9fGv4QgOiHq6P6r6Kpcyc6TPcQQiQn5ALBEZ/xXCMKzOjM+hEeqXcfF ImvQ== X-Gm-Message-State: AOAM531fZgwMs+hGUgN2Rn000RBUNwgg1g54IJpdtu6etnH3CaoGoeh5 fWQfIEuYspGTV1JkIPykD85mKyEIdl4qNSDiE5hwbQ== X-Google-Smtp-Source: ABdhPJzmjcStUcQx4ZEKaJfl4Ln54yI5c7yw8uIsCn/EiLI5nf+UwJP1vwZCHYtEjWBk7fQxjf5W9lFvqudbY503C/E= X-Received: by 2002:aca:548e:: with SMTP id i136mr5532382oib.177.1605184913361; Thu, 12 Nov 2020 04:41:53 -0800 (PST) MIME-Version: 1.0 References: <20201102174950.1148498-1-dmitry.baryshkov@linaro.org> In-Reply-To: From: Dmitry Baryshkov Date: Thu, 12 Nov 2020 15:41:42 +0300 Message-ID: Subject: Re: [PATCH v9 00/15] qcom: pm8150: add support for thermal monitoring To: Daniel Lezcano Cc: Andy Gross , Bjorn Andersson , Rob Herring , Zhang Rui , Amit Kucheria , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , "open list:DRM DRIVER FOR MSM ADRENO GPU" , linux-pm@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-iio@vger.kernel.org, Manivannan Sadhasivam , Jishnu Prakash Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 12 Nov 2020 at 14:39, Daniel Lezcano wr= ote: > > > Shall I take patch 1/15 and 12/15 ? 12/15 will not compile without several previous patches, so it might be better to take all of them through the single tree. > > > > On 02/11/2020 18:49, Dmitry Baryshkov wrote: > > This patch serie adds support for thermal monitoring block on Qualcomm'= s > > PMIC5 chips. PM8150{,b,l} and sm8250-mtp board device trees are extende= d > > to support thermal zones provided by this thermal monitoring block. > > Unlike the rest of PMIC thermal senses, these thermal zones describe > > particular thermistors, which differ between from board to board. > > > > Changes since v8: > > - Simplified qcom_vadc_map_voltage_temp() code by removing ascending > > tables support > > - Simplified qcom-vadc-common volt/temp mapping code > > - Implement suggestions by Matthias Kaehlcke: message formatting, > > rewrite comments, remove unused variable initialization. > > > > Changes since v7: > > - Move qcom-vadc-common.h header to include/linux/iio/adc/ dir. > > - Use explicit sizeof(var) instead of hand-coding 1 when accessing > > adc-tm registers. > > - Remove buffer read from adc_tm5_init(). > > - Remove extra on-stack var from adc_tm5_get_temp(). > > - Minor formatting changes as suggested Daniel. > > > > Changes since v6: > > - Added include as noted by Jishnu Prakash. > > > > Changes since v5: > > - Reworked DT bindings: > > * Removed qcom,adc-channel, instead it is parsed from io-channels > > * Renamed qcom,hw-settle-time to include -us suffix > > - Re-added monitor enabling which got lost during refactored. Noted by > > Jishnu Prakash. > > - Use threaded IRQ handler as susggested by Jishnu. > > > > Changes since v4: > > - Added kernel-doc comments to ADC-TM structures > > - Used several sizeof(buf) instead of hand-conding register size > > > > Changes since v3: > > - Fix DT description to spell "thermal monitoring" instead of just TM > > - Fix warnings in DT example > > - Add EXPORT_SYMBOL_GPL(of_iio_channel_get_by_name) > > - Fixed whitespace chanes in qcom-vadc-common.c > > - Removed error message if IIO chanel get returns -EPROBE_DEFER > > > > Changes since v2: > > - IIO: export of_iio_channel_get_by_name() function > > - dt-bindings: move individual io-channels to each thermal monitoring > > channel rather than listing them all in device node > > - added fallback defaults to of_device_get_match_data calls in > > qcom-spmi-adc5 and qcom-spmi-adc-tm5 drivers > > - minor typo fixes > > > > Changes since v1: > > - Introduce fixp_linear_interpolate() by Craig Tatlor > > - Lots of syntax/whitespace changes > > - Cleaned up register definitions per Jonathan's suggestion > > - Implemented most of the suggestions from Bjorn's and Jonathan's > > review > > > > > > > -- > Linaro.org =E2=94=82 Open source software for AR= M SoCs > > Follow Linaro: Facebook | > Twitter | > Blog --=20 With best wishes Dmitry