From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DED3CA0FE5 for ; Fri, 1 Sep 2023 14:24:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349978AbjIAOYe (ORCPT ); Fri, 1 Sep 2023 10:24:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349965AbjIAOYd (ORCPT ); Fri, 1 Sep 2023 10:24:33 -0400 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3E2CCC5 for ; Fri, 1 Sep 2023 07:24:30 -0700 (PDT) Received: by mail-yb1-xb2d.google.com with SMTP id 3f1490d57ef6-d7bb34576b9so1617487276.3 for ; Fri, 01 Sep 2023 07:24:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693578270; x=1694183070; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4JTq3QyNvEDgshksBGAuADiMeaDa0EKwLIahQgHW96c=; b=g8dj3tbrowzKoX3GNoQ0+h6daW1xO9Fyk6FnoUKFNpIFQmXax3E+XyIViPHEl5jfNo GHJUeDjUEG9g8KEMbCvWV2Ap4BIxaHhbblI83sk/20nboZs8xutjMiOyAfjthfQPbFSW r/Nv3YzwCBaJMOiyDKtn1YPIAs3E0uDnRrjeyzdYwKQFQhavzLp04cDAubWNPORLaelB 24HiHlovsCO09/Pemg4Wfxl3s00fpq/UGdSru92PmdpaxuKm110we9/+p1mHzpjs0jJE McE/Aa9g9NCNjNAqGw2D0o5axBdvMeCsJoToYQCmyJ+mzzANxDoCKnnfA9+gRI2Iy7zW 0iEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693578270; x=1694183070; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4JTq3QyNvEDgshksBGAuADiMeaDa0EKwLIahQgHW96c=; b=Ybf50H8+PXoDI8XJoByAd4XHRL5hA/13UoPBGiSbFxugrRs+6Bmu7EpaEymBHq9l1r XxGMFQeTRQ6H8D91T0Bks1F0dxz3i3R77xVYkAJFqoyHAHlqXA2ODl4TKkWptiI3sxn7 aa/Pkwjz2fu0kcfySuTT9eWt3hgZDfI1aB2PQgZdEzyWFNYAjQ2kYHP8i8k890AWwwoh GLPJZnHIVBs8NW7hVLZslZx6+puaXdJYRxKgZnshVJmgx90KY9s2A6CreG/p8oKFiTBY f5DLnmRluDGpLEK00juuzAFRUPZkiE43vo9Sn/um9kbuAoAvSoHV2lpf/7FK14PI4OtO lvWw== X-Gm-Message-State: AOJu0YxjrZBPhuTsJhEgySzRNEuEUyhB1HqfLXw9iT6sOvYgD8jybX7r 1Va/PLzvdjz5ATqLK1PnuydODpZfjO1B4ULt1C4v+w== X-Google-Smtp-Source: AGHT+IHYBbed9QoyEbl7nDLpZlbr4GZ0M/NYtjSG2pehE4nSWsii7WiwuTpje80SdlHsY6HjPJArMMUKjrm3BVULFH4= X-Received: by 2002:a25:d14:0:b0:d7a:8e37:6d4d with SMTP id 20-20020a250d14000000b00d7a8e376d4dmr2820258ybn.43.1693578269933; Fri, 01 Sep 2023 07:24:29 -0700 (PDT) MIME-Version: 1.0 References: <20230324202244.744271-1-krzysztof.kozlowski@linaro.org> <20230324202244.744271-2-krzysztof.kozlowski@linaro.org> <99045d3e-53b4-dd75-fe57-9a3465d49b6c@linaro.org> In-Reply-To: <99045d3e-53b4-dd75-fe57-9a3465d49b6c@linaro.org> From: Dmitry Baryshkov Date: Fri, 1 Sep 2023 17:24:18 +0300 Message-ID: Subject: Re: [PATCH 2/5] arm64: dts: qcom: apq8096-db820c: drop simple-bus from clocks To: Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 1 Sept 2023 at 11:04, Krzysztof Kozlowski wrote: > > On 31/08/2023 11:04, Dmitry Baryshkov wrote: > > On Fri, 24 Mar 2023 at 22:23, Krzysztof Kozlowski > > wrote: > >> > >> 'clocks' node is not a bus, but just a placeholder for clocks: > >> > >> apq8096-db820c.dtb: clocks: $nodename:0: 'clocks' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$' > >> From schema: dtschema/schemas/simple-bus.yaml > >> apq8096-db820c.dtb: clocks: xo-board: {'compatible': ['fixed-clock'], '#clock-cells': [[0]], ... > >> From schema: dtschema/schemas/simple-bus.yaml > >> > >> Signed-off-by: Krzysztof Kozlowski > > > > This patch broke audio support on DB820c. Now the divclk1 clock is not > > registered, as drivers/clk/clk-gpio.c doesn't have CLK_OF_DECLARE(). > > > > Stephen, What would be the best way to fix this? Add CLK_OF_DECLARE > > support to clk-gpio.c? Or simply move divclk1 from /clocks into a > > separate device? > > > > What is the rule, which clock drivers must support such device-less > > binding using /clocks/foo nodes? > > Uh, sorry for that, I think my patch is incomplete. I did not notice > that not all clocks have CLK_OF_DECLARE. How about moving all the clocks > out of "clocks" node to the root? Then they should be instantiated, > regardless of having CLK_OF_DECLARE. We can do this, but first I'd like to understand the rule with /clocks/. -- With best wishes Dmitry