From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH 2/5] arm64: dts: qcom: apq8096-db820c: drop simple-bus from clocks
Date: Thu, 31 Aug 2023 12:04:00 +0300 [thread overview]
Message-ID: <CAA8EJprF==p87oN+RiwAiNeURF1JcHGfL2Ez5zxqYPRRbN-hhg@mail.gmail.com> (raw)
In-Reply-To: <20230324202244.744271-2-krzysztof.kozlowski@linaro.org>
On Fri, 24 Mar 2023 at 22:23, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> 'clocks' node is not a bus, but just a placeholder for clocks:
>
> apq8096-db820c.dtb: clocks: $nodename:0: 'clocks' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
> From schema: dtschema/schemas/simple-bus.yaml
> apq8096-db820c.dtb: clocks: xo-board: {'compatible': ['fixed-clock'], '#clock-cells': [[0]], ...
> From schema: dtschema/schemas/simple-bus.yaml
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
This patch broke audio support on DB820c. Now the divclk1 clock is not
registered, as drivers/clk/clk-gpio.c doesn't have CLK_OF_DECLARE().
Stephen, What would be the best way to fix this? Add CLK_OF_DECLARE
support to clk-gpio.c? Or simply move divclk1 from /clocks into a
separate device?
What is the rule, which clock drivers must support such device-less
binding using /clocks/foo nodes?
> ---
> arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> index 4476e2e22816..b599909c4463 100644
> --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> @@ -63,7 +63,6 @@ chosen {
> };
>
> clocks {
> - compatible = "simple-bus";
> divclk4: divclk4 {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> --
> 2.34.1
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-08-31 9:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 20:22 [PATCH 1/5] arm64: dts: qcom: msm8916-thwc-ufi001c: add function to pin config Krzysztof Kozlowski
2023-03-24 20:22 ` [PATCH 2/5] arm64: dts: qcom: apq8096-db820c: drop simple-bus from clocks Krzysztof Kozlowski
2023-03-25 12:03 ` Konrad Dybcio
2023-08-31 9:04 ` Dmitry Baryshkov [this message]
2023-09-01 8:04 ` Krzysztof Kozlowski
2023-09-01 14:24 ` Dmitry Baryshkov
2023-03-24 20:22 ` [PATCH 3/5] arm64: dts: qcom: msm8994-msft-lumia: " Krzysztof Kozlowski
2023-03-25 12:03 ` Konrad Dybcio
2023-03-24 20:22 ` [PATCH 4/5] arm64: dts: qcom: msm8996-xiaomi: " Krzysztof Kozlowski
2023-03-25 12:03 ` Konrad Dybcio
2023-03-24 20:22 ` [PATCH 5/5] arm64: dts: qcom: sdm630: move DSI opp-table into DSI node Krzysztof Kozlowski
2023-03-25 12:04 ` Konrad Dybcio
2023-03-25 12:10 ` Krzysztof Kozlowski
2023-03-25 12:02 ` [PATCH 1/5] arm64: dts: qcom: msm8916-thwc-ufi001c: add function to pin config Konrad Dybcio
2023-03-26 3:04 ` (subset) " Bjorn Andersson
2023-04-07 19:26 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA8EJprF==p87oN+RiwAiNeURF1JcHGfL2Ez5zxqYPRRbN-hhg@mail.gmail.com' \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).