From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9303C433E0 for ; Mon, 1 Jun 2020 18:45:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA88C20659 for ; Mon, 1 Jun 2020 18:45:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="eMwUwSMm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730183AbgFASpi (ORCPT ); Mon, 1 Jun 2020 14:45:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730181AbgFASpb (ORCPT ); Mon, 1 Jun 2020 14:45:31 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCE9BC03E96B for ; Mon, 1 Jun 2020 11:45:30 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id mb16so10192968ejb.4 for ; Mon, 01 Jun 2020 11:45:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G1VMPDaeJfT8+NmaRje7sflS/Zy0f/09GM/fygivpDo=; b=eMwUwSMmFyEn7DmLF4myi59y7ESt2HQDfbtUySBAfQf+MVQoCAq2ISQG8jRaF4we3D EDsTMPkk77N3GGd43Kw601vDoU1sLinW5DaqzZqH9oHiGqEB+0a6nTXaw0b055PVIEEV NQtwRu5bwRqWwQkLq43ahZjfuqUrc7H5hFtF0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G1VMPDaeJfT8+NmaRje7sflS/Zy0f/09GM/fygivpDo=; b=oWuGt9W3tbIZh0YCG/I4+D9s0Y+LvOjzF4HDa1zQ8Cc5WFNFKVszxnVI+x+h60PWWE JP/Fjz6enyqleII9NQLoyhY+UugWDPPqVX/VUFpGxmCMorOGyfFiMBveRBSbzYA4ixqI beTXNZRyRP9ArKT4XBz0em3vmRtJFlBX7O8lHCB4Y/WS0/OhA+WMtI/dgjRMXDavdPBF emHre/d9zFIGFwPhtSOr19EA/NlWlThz8TSKgbX2fD1yeSCNtD+AXWHBWJfzVtG77Hfc ELTLXQlUX8nzTXB2L4mPQNTIFnuJ/+Mrqm67i+lfpDpXb1Mxpa2zI8xT5anLKyYhl66u K/aQ== X-Gm-Message-State: AOAM530V/+nVEiHqz5ZDROoYZW9AApmh//RbH2XcudOtadPoGkRQZeYn SEnKCCvheIficBls37FvY0M3N0S3Ro0drg== X-Google-Smtp-Source: ABdhPJytlTWNO6OajFSSlN2fp+j6hhZQYAhg1Hyi7VGuiMlo4kE5Bkai/NZzjxIs4gIOldh/MEHuTw== X-Received: by 2002:a17:906:2a41:: with SMTP id k1mr10544259eje.502.1591037129067; Mon, 01 Jun 2020 11:45:29 -0700 (PDT) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com. [209.85.128.48]) by smtp.gmail.com with ESMTPSA id o13sm342658ejb.46.2020.06.01.11.45.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2020 11:45:28 -0700 (PDT) Received: by mail-wm1-f48.google.com with SMTP id j198so596258wmj.0 for ; Mon, 01 Jun 2020 11:45:27 -0700 (PDT) X-Received: by 2002:a7b:c622:: with SMTP id p2mr581952wmk.55.1591037127078; Mon, 01 Jun 2020 11:45:27 -0700 (PDT) MIME-Version: 1.0 References: <20200529130405.929429-1-maxime.chevallier@bootlin.com> In-Reply-To: <20200529130405.929429-1-maxime.chevallier@bootlin.com> From: Tomasz Figa Date: Mon, 1 Jun 2020 20:45:14 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/3] media: rockchip: Introduce driver for the camera interface on PX30 To: Maxime Chevallier , Helen Koike , Dafna Hirschfeld Cc: Mauro Carvalho Chehab , Robin Murphy , Rob Herring , Mark Rutland , Heiko Stuebner , Hans Verkuil , Linux Media Mailing List , linux-devicetree , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , Thomas Petazzoni , Miquel Raynal , Paul Kocialkowski Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Maxime, On Fri, May 29, 2020 at 3:04 PM Maxime Chevallier wrote: > > Hello everyone, > > Here's a V2 of the series adding very basic support for the camera interface on > the Rockchip PX30 SoC. > > Thanks to everyone that commented on the first series, your reviews were > very helpful :) > > This Camera Interface is also supported on other Rockchip SoC such as > the RK1808, RK3128, RK3288 and RK3288, but for now I've only been able to > test it on the PX30, using a PAL format. How does this hardware relate to the one handled by the rkisp1 driver that is available under staging/media/rkisp1? It was written with RK3399 in mind, but I have a loose recollection that the hardware in RK3288 was roughly the same. +Helen Koike +Dafna Hirschfeld working on the rkisp1 driver. Best regards, Tomasz > > This driver is mostly based on the driver found in Rockchip's BSP, that > has been trimmed down to support the set of features that I was able to test, > that is pretty much a very basic one-frame capture and video streaming > with GStreamer. > > This first draft only supports the Parallel interface, although the > controller has support for BT656 and CSI2. > > Finally, this controller has an iommu that could be used in this driver, > but as of today I've not been able to get it to work. > > Any review is welcome. > > Thanks, > > Maxime > > --- Changes since V1 --- > > - Took reviews from Rob, Hans, Robin and Heiko into account : > - Renamed the clocks in the binding > - Fixed the DT schema compiling > - Fixed a few typos > - Used the clk bulk API > - Used the reset array API > - Changed a few helpers for more suitable ones > - Rebased on 5.7-rc7 > > > > Maxime Chevallier (3): > media: dt-bindings: media: Document Rockchip CIF bindings > media: rockchip: Introduce driver for Rockhip's camera interface > arm64: dts: rockchip: Add the camera interface description of the PX30 > > .../bindings/media/rockchip-cif.yaml | 100 ++ > arch/arm64/boot/dts/rockchip/px30.dtsi | 12 + > drivers/media/platform/Kconfig | 13 + > drivers/media/platform/Makefile | 1 + > drivers/media/platform/rockchip/cif/Makefile | 3 + > drivers/media/platform/rockchip/cif/capture.c | 1170 +++++++++++++++++ > drivers/media/platform/rockchip/cif/dev.c | 358 +++++ > drivers/media/platform/rockchip/cif/dev.h | 213 +++ > drivers/media/platform/rockchip/cif/regs.h | 256 ++++ > 9 files changed, 2126 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/rockchip-cif.yaml > create mode 100644 drivers/media/platform/rockchip/cif/Makefile > create mode 100644 drivers/media/platform/rockchip/cif/capture.c > create mode 100644 drivers/media/platform/rockchip/cif/dev.c > create mode 100644 drivers/media/platform/rockchip/cif/dev.h > create mode 100644 drivers/media/platform/rockchip/cif/regs.h > > -- > 2.25.4 >