devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Phil Chang <phil.chang@mediatek.com>,
	DTML <devicetree@vger.kernel.org>, Alix Wu <alix.wu@mediatek.com>,
	YJ Chiang <yj.chiang@mediatek.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Joe Liu <joe.liu@mediatek.com>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Frank Rowand <frowand.list@gmail.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] [PATCH] of_reserved_mem: Increase the number of reserved regions
Date: Mon, 5 Oct 2020 23:12:17 +0800	[thread overview]
Message-ID: <CAAOTY_-5M77vVXuSJiWJK5KVUFXg8m6u054z-CiwVhc1fheDtg@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqJ4rTChMpn7F--fh1A6bOTZxR4rEM9bbA1rdetXmPDeVA@mail.gmail.com>

Hi, Rob:

Rob Herring <robh+dt@kernel.org> 於 2020年10月5日 週一 下午9:45寫道:
>
> On Sun, Oct 4, 2020 at 12:50 AM Phil Chang <phil.chang@mediatek.com> wrote:
> >
> > Certain SoCs need to support large amount of reserved memory
> > regions, especially to follow the GKI rules from Google.
> > In MTK new SoC requires more than 68 regions of reserved memory
> > for each IP's usage, such as load firmware to specific sapce,
>
> typo
>
> > so that need to reserve more regisions
>
> typo. Missing punctuation.
>
> >
> > Signed-off-by: Joe Liu <joe.liu@mediatek.com>
> > Signed-off-by: YJ Chiang <yj.chiang@mediatek.com>
> > Signed-off-by: Alix Wu <alix.wu@mediatek.com>
> > Signed-off-by: Phil Chang <phil.chang@mediatek.com>
> > ---
> >  drivers/of/of_reserved_mem.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> > index 46b9371c8a33..595f0741dcef 100644
> > --- a/drivers/of/of_reserved_mem.c
> > +++ b/drivers/of/of_reserved_mem.c
> > @@ -22,7 +22,7 @@
> >  #include <linux/slab.h>
> >  #include <linux/memblock.h>
> >
> > -#define MAX_RESERVED_REGIONS   64
> > +#define MAX_RESERVED_REGIONS   128
>
> At some point, this starts to feel like abuse of reserved regions.
> Please provide details on what the regions are.
>
> Also, this probably just needs to be dynamic. I think we're at that point.

How about using a config like DRM_FBDEV_OVERALLOC [1] ?

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/Kconfig?h=v5.9-rc8#n125

Regards,
Chun-Kuang.

>
> Rob
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

      reply	other threads:[~2020-10-05 15:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-04  5:50 Phil Chang
2020-10-04 13:05 ` Chun-Kuang Hu
2020-10-05 17:17   ` Phil Chang
2020-10-05 18:57     ` Rob Herring
2020-10-05 23:16       ` Chun-Kuang Hu
2020-10-05 13:44 ` Rob Herring
2020-10-05 15:12   ` Chun-Kuang Hu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAOTY_-5M77vVXuSJiWJK5KVUFXg8m6u054z-CiwVhc1fheDtg@mail.gmail.com \
    --to=chunkuang.hu@kernel.org \
    --cc=alix.wu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=joe.liu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=phil.chang@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=yj.chiang@mediatek.com \
    --subject='Re: [PATCH] [PATCH] of_reserved_mem: Increase the number of reserved regions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).