From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
To: Neal Liu <neal.liu@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
devicetree@vger.kernel.org,
wsd_upstream <wsd_upstream@mediatek.com>,
lkml <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver
Date: Fri, 31 Jul 2020 00:14:20 +0800 [thread overview]
Message-ID: <CAAOTY_9HXv+OsSRF7P9=cRy9AYZ0vwffgo3Kc8V=qQ6ce90uJw@mail.gmail.com> (raw)
In-Reply-To: <1596010690-13178-3-git-send-email-neal.liu@mediatek.com>
Hi, Neal:
Neal Liu <neal.liu@mediatek.com> 於 2020年7月29日 週三 下午4:29寫道:
>
> MediaTek bus fabric provides TrustZone security support and data
> protection to prevent slaves from being accessed by unexpected
> masters.
> The security violation is logged and sent to the processor for
> further analysis or countermeasures.
>
> Any occurrence of security violation would raise an interrupt, and
> it will be handled by mtk-devapc driver. The violation
> information is printed in order to find the murderer.
>
> Signed-off-by: Neal Liu <neal.liu@mediatek.com>
> ---
[snip]
> +
> +/*
> + * devapc_extract_vio_dbg - extract full violation information after doing
> + * shift mechanism.
> + */
> +static void devapc_extract_vio_dbg(struct mtk_devapc_context *ctx)
> +{
> + const struct mtk_devapc_vio_dbgs *vio_dbgs;
> + struct mtk_devapc_vio_info *vio_info;
> + void __iomem *vio_dbg0_reg;
> + void __iomem *vio_dbg1_reg;
> + u32 dbg0;
> +
> + vio_dbg0_reg = ctx->devapc_pd_base + ctx->offset->vio_dbg0;
> + vio_dbg1_reg = ctx->devapc_pd_base + ctx->offset->vio_dbg1;
> +
> + vio_dbgs = ctx->vio_dbgs;
> + vio_info = ctx->vio_info;
> +
> + /* Starts to extract violation information */
> + dbg0 = readl(vio_dbg0_reg);
> + vio_info->vio_addr = readl(vio_dbg1_reg);
> +
> + vio_info->master_id = (dbg0 & vio_dbgs->mstid.mask) >>
> + vio_dbgs->mstid.start;
> + vio_info->domain_id = (dbg0 & vio_dbgs->dmnid.mask) >>
> + vio_dbgs->dmnid.start;
> + vio_info->write = ((dbg0 & vio_dbgs->vio_w.mask) >>
> + vio_dbgs->vio_w.start) == 1;
> + vio_info->read = ((dbg0 & vio_dbgs->vio_r.mask) >>
> + vio_dbgs->vio_r.start) == 1;
> + vio_info->vio_addr_high = (dbg0 & vio_dbgs->addr_h.mask) >>
> + vio_dbgs->addr_h.start;
I would like to define the type of ctx->vio_info to be
struct mtk_devapc_vio_dbgs {
u32 mstid:16;
u32 dmnid:6;
u32 vio_w:1;
u32 vio_r:1;
u32 addr_h:4;
u32 resv:4;
};
so the code would like the simple way
ctx->vio_info = (struct mtk_devapc_vio_dbgs)readl(vio_dbg1_reg);
Regards,
Chun-Kuang.
> +
> + devapc_vio_info_print(ctx);
> +}
> +
next prev parent reply other threads:[~2020-07-30 16:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 8:18 [PATCH v4] Add MediaTek MT6779 devapc driver Neal Liu
2020-07-29 8:18 ` [PATCH v4 1/2] dt-bindings: devapc: add bindings for mtk-devapc Neal Liu
2020-07-29 8:18 ` [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver Neal Liu
2020-07-29 16:38 ` Chun-Kuang Hu
2020-07-31 2:44 ` Neal Liu
2020-07-31 15:03 ` Chun-Kuang Hu
2020-08-03 3:32 ` Neal Liu
2020-08-03 16:13 ` Chun-Kuang Hu
2020-08-04 2:18 ` Neal Liu
2020-08-04 15:27 ` Chun-Kuang Hu
2020-07-29 22:47 ` Chun-Kuang Hu
2020-07-31 2:47 ` Neal Liu
2020-07-30 16:14 ` Chun-Kuang Hu [this message]
2020-07-31 2:52 ` Neal Liu
2020-07-31 15:55 ` Chun-Kuang Hu
2020-08-03 3:41 ` Neal Liu
2020-08-01 0:12 ` Chun-Kuang Hu
2020-08-03 4:01 ` Neal Liu
2020-08-03 16:04 ` Chun-Kuang Hu
2020-08-04 2:08 ` Neal Liu
2020-08-04 15:55 ` Chun-Kuang Hu
2020-08-01 23:50 ` Chun-Kuang Hu
2020-08-03 4:05 ` Neal Liu
2020-08-03 15:38 ` Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAOTY_9HXv+OsSRF7P9=cRy9AYZ0vwffgo3Kc8V=qQ6ce90uJw@mail.gmail.com' \
--to=chunkuang.hu@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=neal.liu@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).