From: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Alexandre Courbot
<acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 3/5] dt-bindings: Add documentation for GM20B GPU
Date: Sun, 20 Mar 2016 15:55:49 +0900 [thread overview]
Message-ID: <CAAVeFuKQvjb20aEh9_MBnrzEUjKoVc8yQu3a4Ego6Qaqe70M6A@mail.gmail.com> (raw)
In-Reply-To: <20160318204748.GA20243@rob-hp-laptop>
On Sat, Mar 19, 2016 at 5:47 AM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Tue, Mar 15, 2016 at 11:58:42AM +0900, Alexandre Courbot wrote:
>> GM20B's definition is mostly similar to GK20A's, but requires an
>> additional clock.
>>
>> Signed-off-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> ---
>> .../devicetree/bindings/gpu/nvidia,gk20a.txt | 27 ++++++++++++++++++++--
>> 1 file changed, 25 insertions(+), 2 deletions(-)
>
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>
> One nit below.
>
>>
>> diff --git a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
>> index 1e3748337319..d9ad6b87fbbc 100644
>> --- a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
>> +++ b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
>> @@ -1,9 +1,10 @@
>> -NVIDIA GK20A Graphics Processing Unit
>> +NVIDIA Tegra Graphics Processing Units
>>
>> Required properties:
>> - compatible: "nvidia,<gpu>"
>> Currently recognized values:
>> - nvidia,gk20a
>> + - nvidia,gm20b
>> - reg: Physical base address and length of the controller's registers.
>> Must contain two entries:
>> - first entry for bar0
>> @@ -19,6 +20,9 @@ Required properties:
>> - clock-names: Must include the following entries:
>> - gpu
>> - pwr
>> +If the compatible string is "nvidia,gm20b", then the following clock
>> +is also required:
>> + - ref
>> - resets: Must contain an entry for each entry in reset-names.
>> See ../reset/reset.txt for details.
>> - reset-names: Must include the following entries:
>> @@ -27,7 +31,7 @@ Required properties:
>> Optional properties:
>> - iommus: A reference to the IOMMU. See ../iommu/iommu.txt for details.
>>
>> -Example:
>> +Example for GK20A:
>>
>> gpu@0,57000000 {
>> compatible = "nvidia,gk20a";
>> @@ -45,3 +49,22 @@ Example:
>> iommus = <&mc TEGRA_SWGROUP_GPU>;
>> status = "disabled";
>> };
>> +
>> +Example for GM20B:
>> +
>> + gpu@0,57000000 {
>
> Drop the comma and leading zero.
Even though this is how it appears in the actual DT?
next prev parent reply other threads:[~2016-03-20 6:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 2:58 [PATCH v2 0/5] arm64: tegra: fix DT definitions for GM20B GPU Alexandre Courbot
2016-03-15 2:58 ` [PATCH v2 2/5] dt-bindings: gk20a: Document iommus property Alexandre Courbot
2016-03-18 20:41 ` Rob Herring
2016-03-15 2:58 ` [PATCH v2 4/5] arm64: tegra210: Add reference clock to GM20B Alexandre Courbot
[not found] ` <1458010724-10945-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-15 2:58 ` [PATCH v2 1/5] dt-bindings: gk20a: Fix typo in compatible name Alexandre Courbot
[not found] ` <1458010724-10945-2-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-18 20:31 ` Rob Herring
2016-03-20 6:55 ` Alexandre Courbot
2016-03-15 2:58 ` [PATCH v2 3/5] dt-bindings: Add documentation for GM20B GPU Alexandre Courbot
[not found] ` <1458010724-10945-4-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-18 20:47 ` Rob Herring
2016-03-20 6:55 ` Alexandre Courbot [this message]
[not found] ` <CAAVeFuKQvjb20aEh9_MBnrzEUjKoVc8yQu3a4Ego6Qaqe70M6A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-22 1:41 ` Rob Herring
[not found] ` <CAL_Jsq+SEOC1s_j8u3hMyDj5i9ROyAAN_-qmbsLrNvR3v2cXwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-22 4:00 ` Alexandre Courbot
[not found] ` <56F0C375.1030907-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-22 12:44 ` Rob Herring
2016-03-15 2:58 ` [PATCH v2 5/5] arm64: tegra210: Add IOMMU node to GM20B Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAVeFuKQvjb20aEh9_MBnrzEUjKoVc8yQu3a4Ego6Qaqe70M6A@mail.gmail.com \
--to=gnurou-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).