From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8EC9C433E0 for ; Wed, 5 Aug 2020 09:38:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85C9D2067C for ; Wed, 5 Aug 2020 09:38:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=brainfault-org.20150623.gappssmtp.com header.i=@brainfault-org.20150623.gappssmtp.com header.b="pqRKHVVu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728482AbgHEJh4 (ORCPT ); Wed, 5 Aug 2020 05:37:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728475AbgHEJhr (ORCPT ); Wed, 5 Aug 2020 05:37:47 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA42FC061756 for ; Wed, 5 Aug 2020 02:37:25 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id c80so5202026wme.0 for ; Wed, 05 Aug 2020 02:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sa5qXdemmtPrCWAxdmJHhP03xcaLaJDyrq3fN/vAu4U=; b=pqRKHVVurNL9xDGPRzkBqZKrsvlm6ebrdoTbuCmUbHaR2igYkNqOTrIraIk2xK9bfX TichTCfgIeuOXRE8tgE+68RKy1i/mJ/3BMxiYvvhFbidZi3wX0AxO+u7zDclOKZHxTYQ div7bohh2QkW6VYS10xA6cLHdzbthzAO2RWe8vzWPV6vhyuM7aguyEblWQwyJZKvNA86 fA+/ZDxNUVrQM5nPu5QLKNhhPoJV10CnEeQjrTdpyxqMswPzD6UEHEr9K6bVPBaXVaKp V0VaYjFQ5LHtBdnQDQF1KGTFuOjztEngxG+sZe1Irj0/uB8n1qEfYxJ3T//RKOZXGXdi y2WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sa5qXdemmtPrCWAxdmJHhP03xcaLaJDyrq3fN/vAu4U=; b=J6u+p5KEvPSVxV++P/rQnneELr5OPQigqkVUZDImUTq4kRCmWIVf0UTA+2GBOfE+zQ Om6SeP36rzvNrtOF+D1a8543p7cxI67Q4TT6b+DuKQOFcwsmK5OhbbZ71OV5bYKbNX+4 bL/gWJn2dmKIq+sY0wH3RXvm4xpy2KfasvPg00EPxSFbu5YD6mqjPOXnlvXKtrvdToWe YJtk+gMttjx54T1vIOyJZIiWsFpKwj0qERk9/N8qXm89WybF+ytYaE3ijWtZpZqrY4oW f3j4ADKniSCApvPIPK00bPUlDIMmWl5/Lp1F1P58rs5vGkT2XYjWWoHFCO6PwMcJQN1M PPyA== X-Gm-Message-State: AOAM530BJvazGO7ZikCphBAQx42DIeb2vK7yHrcU1P2xfG2X94/0cqze QQ4fl1zwUuvM0F/D0OcReq1VWlzGdsDhEsC11joRiA== X-Google-Smtp-Source: ABdhPJyrfugmunkVBA6Tq7v4TZjnpR1y3YD1khUpx+jbC4LaW34FDjfZSGZdsHD8cnc/wODH4xvSTWE9kR1//gQ7KvY= X-Received: by 2002:a1c:6689:: with SMTP id a131mr2349662wmc.157.1596620244449; Wed, 05 Aug 2020 02:37:24 -0700 (PDT) MIME-Version: 1.0 References: <20200724071822.126758-1-anup.patel@wdc.com> In-Reply-To: From: Anup Patel Date: Wed, 5 Aug 2020 15:07:03 +0530 Message-ID: Subject: Re: [PATCH v6 0/4] Dedicated CLINT timer driver To: Palmer Dabbelt Cc: Anup Patel , Paul Walmsley , Albert Ou , Rob Herring , Daniel Lezcano , Thomas Gleixner , Damien Le Moal , Atish Patra , Alistair Francis , linux-riscv , "linux-kernel@vger.kernel.org List" , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Aug 5, 2020 at 7:17 AM Palmer Dabbelt wrote: > > On Fri, 24 Jul 2020 00:18:18 PDT (-0700), Anup Patel wrote: > > The current RISC-V timer driver is convoluted and implements two > > distinct timers: > > 1. S-mode timer: This is for Linux RISC-V S-mode with MMU. The > > clocksource is implemented using TIME CSR and clockevent device > > is implemented using SBI Timer calls. > > 2. M-mode timer: This is for Linux RISC-V M-mode without MMU. The > > clocksource is implemented using CLINT MMIO time register and > > clockevent device is implemented using CLINT MMIO timecmp registers. > > > > This patchset removes clint related code from RISC-V timer driver and > > arch/riscv directory. Instead, the series adds a dedicated MMIO based > > CLINT driver under drivers/clocksource directory which can be used by > > Linux RISC-V M-mode (i.e NoMMU Linux RISC-V). > > > > The patchset is based up Linux-5.8-rc6 and can be found at riscv_clint_v6 > > branch of: https://github.com/avpatel/linux.git > > > > This series is tested on: > > 1. QEMU RV64 virt machine using Linux RISC-V S-mode > > 2. QEMU RV32 virt machine using Linux RISC-V S-mode > > 3. QEMU RV64 virt machine using Linux RISC-V M-mode (i.e. NoMMU) > > > > Changes since v5: > > - Fixed order of compatible strings in PATCH4 > > - Added "additionalProperties: false" in PATCH4 > > - Fixed register space size for example DT node in PATCH4 > > > > Changes since v4: > > - Rebased series on Linux-5.8-rc6 > > - Updated Kconfig option as suggested by Daniel in PATCH2 > > - Removed per-CPU registered flag in PATCH2 > > - Addressed nit comments from Atish in PATCH2 > > > > Changes since v3: > > - Updated commit description of PATCH2 > > - Use clint_get_cycles64() in clint_rdtime() of PATCH2 > > - Call clockevents_config_and_register() only once for each CPU in > > clint_timer_starting_cpu of PATCH2 > > - Select CLINT timer driver from platform Kconfig in PATCH3 > > - Fixed 'make dt_binding_check' for PATCH4 > > > > Changes since v2: > > - Rebased series on Linux-5.8-rc5 > > - Squashed PATCH3 onto PATCH2 to preserve GIT bisectability > > - Moved PATCH4 before PATCH2 to preserve GIT bisectability > > - Replaced CLINT dt-bindings text document with YAML schema > > - Use SiFive CLINT compatible string as per SiFive IP block versioning > > > > Changes since v1: > > - Rebased series on Linux-5.8-rc2 > > - Added pr_warn() for case where ipi_ops not available in PATCH1 > > - Updated ipi_inject() prototype to use "struct cpumask *" in PATCH1 > > - Updated CLINT_TIMER kconfig option to depend on RISCV_M_MODE in PATCH4 > > - Added riscv,clint0 compatible string in DT bindings document > > > > Anup Patel (4): > > RISC-V: Add mechanism to provide custom IPI operations > > clocksource/drivers: Add CLINT timer driver > > RISC-V: Remove CLINT related code from timer and arch > > dt-bindings: timer: Add CLINT bindings > > > > .../bindings/timer/sifive,clint.yaml | 60 +++++ > > arch/riscv/Kconfig | 2 +- > > arch/riscv/Kconfig.socs | 2 + > > arch/riscv/configs/nommu_virt_defconfig | 7 +- > > arch/riscv/include/asm/clint.h | 39 --- > > arch/riscv/include/asm/smp.h | 19 ++ > > arch/riscv/include/asm/timex.h | 28 +-- > > arch/riscv/kernel/Makefile | 2 +- > > arch/riscv/kernel/clint.c | 44 ---- > > arch/riscv/kernel/sbi.c | 14 ++ > > arch/riscv/kernel/setup.c | 2 - > > arch/riscv/kernel/smp.c | 44 ++-- > > arch/riscv/kernel/smpboot.c | 4 +- > > drivers/clocksource/Kconfig | 12 +- > > drivers/clocksource/Makefile | 1 + > > drivers/clocksource/timer-clint.c | 226 ++++++++++++++++++ > > drivers/clocksource/timer-riscv.c | 17 +- > > include/linux/cpuhotplug.h | 1 + > > 18 files changed, 371 insertions(+), 153 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/timer/sifive,clint.yaml > > delete mode 100644 arch/riscv/include/asm/clint.h > > delete mode 100644 arch/riscv/kernel/clint.c > > create mode 100644 drivers/clocksource/timer-clint.c > > Thanks, this is way cleaner. Patchwork is still broken but IIRC we reached > consensus on these. I'm not going to include these in my first 5.9 PR, as I > want to get that out tomorrow to avoid more merge conflicts, but assuming > there's reviews from the other maintainers I'd like to take this for my second > 5.9 merge window PR. > > Assuming you've been collecting reviews and acks, do you mind posting another > version with them? If not I have some scripts to dig them out, so it's not a > big deal. Most of the Reviewed-by and Ack-by are already there, except yours and Rob Herring's Reviewed-by. I will post v7 based on Linux-5.9-rc1 Regards, Anup