From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D802C4338F for ; Mon, 26 Jul 2021 15:22:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 701AD60F6B for ; Mon, 26 Jul 2021 15:22:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234922AbhGZOmI (ORCPT ); Mon, 26 Jul 2021 10:42:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234739AbhGZOmH (ORCPT ); Mon, 26 Jul 2021 10:42:07 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7880C061764 for ; Mon, 26 Jul 2021 08:22:35 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id e2so11551894wrq.6 for ; Mon, 26 Jul 2021 08:22:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=avDShFOnRifoiKTiQKCeIkAP138nxzPrnp0tkIoBLys=; b=LG0MkcBw3Z8/VwJ4qdyP2VQUN3bST3lAmhEB7ChPfdR1gEwwIuYBgiN/RXIjg2IypI JZDI6pM94yYdb1m7jGnbk6OK7ppwXgVaqF/AuCaSXl/V69s/EC3aevtYsFPQ8DCWHhbJ BDHi2MYfoFNrbPwhrvKoLCDgNAXqXIZUQQiZMoNwUmOOPaUsa2liD2V59LICIMvMzkHV WC1XX9f/bx5A6PU0H7krRq+N/59uSo18rJuCA5QO1oaObAt2braN1ZHR3n/c80akk5vN elUrX0N53yel+hJ+nLwZZFsXE1M7kQiaLEs6O8SYeKxPpxIEv/qOSHM4+dKv7BXK9niZ 3c0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=avDShFOnRifoiKTiQKCeIkAP138nxzPrnp0tkIoBLys=; b=MqQvBUmFivHLYm4blSr/poR/pJV8nRIpCLMzBEzpFlBIwMWo3rnyJc4E9tsTKdMmH3 ObUHv7FHM96RVuwGWvy/u0RfQ/cqY4j0o//ndL3BNSOumyowryzmwPDXQWB5xhv4tzG/ kMRZO7BcLMoMvO8NsmWt1UbLVz921B9V4YWcJjsXnzflfJiqD6rRXDlb7JW84wGgzB4n JQgaCBmFCulbdvyLt2jqL0KtoaDD9eynN5NCHHI1FSC681ZzoSZ6B5qguKH8G21968ow Nc/iP6DRc6oNEy7/kRNdfar3foenOybG//29cpNasTFw+XOAoUlwNwprs/4lsxwfEbLb nZIA== X-Gm-Message-State: AOAM531Lr/+V1e2b7B+FD39cTe1d18jNDZebWQc/iOE9OchLV4sRGcbb Y+ZWlEJ8vadU8ICJwGVyhtpyGOahU4F07KUx3ABQog== X-Google-Smtp-Source: ABdhPJxS1dRI/OSfH5W9DS2t09aCkQ4v/mCbJyOLuy5wMIvH2nM9dj7G3bhhBdXNRi0ux2I+OSdKyT7lKWDbq822IjU= X-Received: by 2002:a5d:424d:: with SMTP id s13mr10302527wrr.356.1627312954415; Mon, 26 Jul 2021 08:22:34 -0700 (PDT) MIME-Version: 1.0 References: <20210618123851.1344518-1-anup.patel@wdc.com> <20210618123851.1344518-3-anup.patel@wdc.com> <87lf5tdw9z.wl-maz@kernel.org> In-Reply-To: <87lf5tdw9z.wl-maz@kernel.org> From: Anup Patel Date: Mon, 26 Jul 2021 20:52:23 +0530 Message-ID: Subject: Re: [RFC PATCH v2 02/11] RISC-V: Use common print prefix in smp.c To: Marc Zyngier Cc: Anup Patel , Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Daniel Lezcano , Rob Herring , Atish Patra , Alistair Francis , linux-riscv , "linux-kernel@vger.kernel.org List" , DTML , Bin Meng Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jul 26, 2021 at 7:14 PM Marc Zyngier wrote: > > On Fri, 18 Jun 2021 13:38:42 +0100, > Anup Patel wrote: > > > > We add "#define pr_fmt()" in smp.c to use "riscv:" as common > > print prefix for all pr_xyz() statements in this file. > > > > Signed-off-by: Anup Patel > > Reviewed-by: Bin Meng > > --- > > arch/riscv/kernel/smp.c | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c > > index 547dc508f7d1..eea0c9d11d9f 100644 > > --- a/arch/riscv/kernel/smp.c > > +++ b/arch/riscv/kernel/smp.c > > @@ -8,6 +8,7 @@ > > * Copyright (C) 2017 SiFive > > */ > > > > +#define pr_fmt(fmt) "riscv: " fmt > > #include > > #include > > #include > > @@ -114,7 +115,7 @@ static void send_ipi_mask(const struct cpumask *mask, enum ipi_message_type op) > > if (ipi_ops && ipi_ops->ipi_inject) > > ipi_ops->ipi_inject(mask); > > else > > - pr_warn("SMP: IPI inject method not available\n"); > > + pr_warn("IPI inject method not available\n"); > > } > > > > static void send_ipi_single(int cpu, enum ipi_message_type op) > > @@ -126,7 +127,7 @@ static void send_ipi_single(int cpu, enum ipi_message_type op) > > if (ipi_ops && ipi_ops->ipi_inject) > > ipi_ops->ipi_inject(cpumask_of(cpu)); > > else > > - pr_warn("SMP: IPI inject method not available\n"); > > + pr_warn("IPI inject method not available\n"); > > "SMP:" made a lot more sense. I assume that the user knows that they > are using a RISC-V machine. On the other hand, seeing a "SMP:" prefix > for a message indicates the provenance of the message. > > I honestly don't see the point in this change. The intention was to distinguish arch specific prints from generic kernel prints at boot-time because "SMP: " prefix was not making it obvious that these are arch specific prints. I am certainly fine dropping this patch as well. Regards, Anup > > M. > > -- > Without deviation from the norm, progress is not possible.