From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60F5AC433DB for ; Mon, 28 Dec 2020 12:10:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AA352074D for ; Mon, 28 Dec 2020 12:10:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727646AbgL1MKR (ORCPT ); Mon, 28 Dec 2020 07:10:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727630AbgL1MKR (ORCPT ); Mon, 28 Dec 2020 07:10:17 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A71CEC061798 for ; Mon, 28 Dec 2020 04:09:36 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id l11so23485238lfg.0 for ; Mon, 28 Dec 2020 04:09:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P02uQyjOYUJEP7Y3SPVduzao2ynhVahUnEgVQMCDEUw=; b=Od5um3vP9jYr7f0X0GDU04GIOfyvGhO90GKyuaz1+3pOo8qNmMQIEYUgp+tpzj4+pf kGaLwdQsab+YQkz7ZQSTGQW62/8C42qR05bduMbEHYhl6g6TW6iU7SD0Y/tRDiA+cJWJ inqk7YHlKkykDvbsHn2qZhqM1BYPhZgxj5Qe7o8YHgIUDyBA33rJ3YpGKEGPQ4kCWVTh 4l30bX4nHog00eyzD6EZs8I56GsEyVMSChehjs2K8cxmk+jpKsqSKNXDMXiB+8egZmUv Ry4drp3fKCLyonV/4mA0Wa6JfgjXBjSO802s18x5v9PSEwDdhQhJDJHfinYYiTYYwMU2 YY2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P02uQyjOYUJEP7Y3SPVduzao2ynhVahUnEgVQMCDEUw=; b=AeK7TrkNKCtTBaz15RsNkAROCOnZGfXhruLfeLVEjdMFs9KF0N6QFZzEKcLC99uz5+ MNgTS4kBUC2v59C3/Y33FTrWXE5illDoxucy1gAAgNByRK+SlMXhjermyQc2AvIGJY2Y ia4GZEKCbQuZDmtRUW5c8ubI5AmSxzAykmAZQ7TvCF3+WW0KFucLuANXqwPQd8EV7IEb bX0+udcGE4oH4WnLZBo1i3P8xo9r9zHS5+tBHJsPuPMfZM8vJ6Y+KeVLr7HN8BHfGbHn 5CvHHtjGVMXMXM3dFBcHCqq6qkOgTatzkOQwwRomttTXtcB5UUgKiUJ6XuVYDaNRoFK5 1Ifg== X-Gm-Message-State: AOAM532OQqr2ktv90ac0zdIvmnZqFyPaY5ikOZ17uQQ0S8rwsJkrBh59 8vnED+yIN/mgD27LDWkd0rzLE86sPuiqDMgFEEVCqg== X-Google-Smtp-Source: ABdhPJyN9dhlq72HmTDX0VxZ/iehtyRG2gwKNhJ3PwdzKCcNwhfAAjC9y6oMxlb5myDTrbmr1QZUrcqu2dY6wHbAMKA= X-Received: by 2002:a05:6512:4d9:: with SMTP id w25mr17789796lfq.199.1609157375154; Mon, 28 Dec 2020 04:09:35 -0800 (PST) MIME-Version: 1.0 References: <20201213135056.24446-1-damien.lemoal@wdc.com> <20201213135056.24446-20-damien.lemoal@wdc.com> In-Reply-To: <20201213135056.24446-20-damien.lemoal@wdc.com> From: Anup Patel Date: Mon, 28 Dec 2020 17:39:23 +0530 Message-ID: Subject: Re: [PATCH v10 19/23] riscv: Add SiPeed MAIX GO board device tree To: Damien Le Moal Cc: Palmer Dabbelt , linux-riscv , Rob Herring , devicetree@vger.kernel.org, Stephen Boyd , linux-clk@vger.kernel.org, Linus Walleij , linux-gpio@vger.kernel.org, Philipp Zabel , Sean Anderson Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Dec 13, 2020 at 7:22 PM Damien Le Moal wrote: > > Add a device tree for the SiPeed MAIX GO board. This device tree > enables buttons, LEDs, gpio, i2c and spi/mmc SD card devices. > > Signed-off-by: Damien Le Moal > --- > arch/riscv/boot/dts/canaan/k210_maix_go.dts | 237 ++++++++++++++++++++ > 1 file changed, 237 insertions(+) > create mode 100644 arch/riscv/boot/dts/canaan/k210_maix_go.dts > > diff --git a/arch/riscv/boot/dts/canaan/k210_maix_go.dts b/arch/riscv/boot/dts/canaan/k210_maix_go.dts > new file mode 100644 > index 000000000000..c3294dfaa3c6 > --- /dev/null > +++ b/arch/riscv/boot/dts/canaan/k210_maix_go.dts > @@ -0,0 +1,237 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2019-20 Sean Anderson > + * Copyright (C) 2020 Western Digital Corporation or its affiliates. > + */ > + > +/dts-v1/; > + > +#include "k210.dtsi" > + > +#include > +#include > + > +/ { > + model = "SiPeed MAIX GO"; > + compatible = "sipeed,maix-go", "canaan,kendryte-k210"; > + > + chosen { > + bootargs = "earlycon console=ttySIF0"; > + stdout-path = "serial0:115200n8"; > + }; > + > + gpio-leds { > + compatible = "gpio-leds"; > + > + green { > + gpios = <&gpio1_0 4 GPIO_ACTIVE_LOW>; > + }; > + > + red { > + gpios = <&gpio1_0 5 GPIO_ACTIVE_LOW>; > + }; > + > + blue { > + gpios = <&gpio1_0 6 GPIO_ACTIVE_LOW>; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + up { > + label = "UP"; > + linux,code = ; > + gpios = <&gpio1_0 7 GPIO_ACTIVE_LOW>; > + }; > + > + press { > + label = "PRESS"; > + linux,code = ; > + gpios = <&gpio0 0 GPIO_ACTIVE_LOW>; > + }; > + > + down { > + label = "DOWN"; > + linux,code = ; > + gpios = <&gpio0 1 GPIO_ACTIVE_LOW>; > + }; > + }; > + > + sound { > + compatible = "simple-audio-card"; > + simple-audio-card,format = "i2s"; > + status = "disabled"; > + > + simple-audio-card,cpu { > + sound-dai = <&i2s0 0>; > + }; > + > + simple-audio-card,codec { > + sound-dai = <&mic>; > + }; > + }; > + > + mic: mic { > + #sound-dai-cells = <0>; > + compatible = "memsensing,msm261s4030h0"; > + status = "disabled"; > + }; > +}; > + > +&fpioa { > + pinctrl-0 = <&jtag_pinctrl>; > + pinctrl-names = "default"; > + status = "okay"; > + > + jtag_pinctrl: jtag-pinmux { > + pinmux = , > + , > + , > + ; > + }; > + > + uarths_pinctrl: uarths-pinmux { > + pinmux = , > + ; > + }; > + > + gpio_pinctrl: gpio-pinmux { > + pinmux = , > + , > + , > + , > + , > + , > + , > + ; > + }; > + > + gpiohs_pinctrl: gpiohs-pinmux { > + pinmux = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + }; > + > + i2s0_pinctrl: i2s0-pinmux { > + pinmux = , > + , > + ; > + }; > + > + dvp_pinctrl: dvp-pinmux { > + pinmux = , > + , > + , > + , > + , > + , > + , > + ; > + }; > + > + spi0_pinctrl: spi0-pinmux { > + pinmux = , /* cs */ > + , /* rst */ > + , /* dc */ > + ; /* wr */ > + }; > + > + spi1_pinctrl: spi1-pinmux { > + pinmux = , > + , > + , > + ; /* cs */ > + }; > + > + i2c1_pinctrl: i2c1-pinmux { > + pinmux = , > + ; > + }; > +}; > + > +&uarths0 { > + pinctrl-0 = <&uarths_pinctrl>; > + pinctrl-names = "default"; > + status = "okay"; > +}; > + > +&gpio0 { > + pinctrl-0 = <&gpiohs_pinctrl>; > + pinctrl-names = "default"; > + status = "okay"; > +}; > + > +&gpio1 { > + pinctrl-0 = <&gpio_pinctrl>; > + pinctrl-names = "default"; > + status = "okay"; > +}; > + > +&i2s0 { > + #sound-dai-cells = <1>; > + pinctrl-0 = <&i2s0_pinctrl>; > + pinctrl-names = "default"; > +}; > + > +&i2c1 { > + pinctrl-0 = <&i2c1_pinctrl>; > + pinctrl-names = "default"; > + clock-frequency = <400000>; > + status = "okay"; > +}; > + > +&dvp0 { > + pinctrl-0 = <&dvp_pinctrl>; > + pinctrl-names = "default"; > +}; > + > +&spi0 { > + pinctrl-0 = <&spi0_pinctrl>; > + pinctrl-names = "default"; > + num-cs = <1>; > + cs-gpios = <&gpio0 20 GPIO_ACTIVE_HIGH>; > + > + panel@0 { > + compatible = "sitronix,st7789v"; > + reg = <0>; > + reset-gpios = <&gpio0 21 GPIO_ACTIVE_LOW>; > + dc-gpios = <&gpio0 22 GPIO_ACTIVE_HIGH>; > + spi-max-frequency = <15000000>; > + status = "disabled"; > + }; > +}; > + > +&spi1 { > + pinctrl-0 = <&spi1_pinctrl>; > + pinctrl-names = "default"; > + num-cs = <1>; > + cs-gpios = <&gpio0 13 GPIO_ACTIVE_LOW>; > + status = "okay"; > + > + slot@0 { > + compatible = "mmc-spi-slot"; > + reg = <0>; > + voltage-ranges = <3300 3300>; > + spi-max-frequency = <25000000>; > + broken-cd; > + }; > +}; > + > +&spi3 { > + spi-flash@0 { > + compatible = "jedec,spi-nor"; > + reg = <0>; > + spi-max-frequency = <50000000>; > + m25p,fast-read; > + broken-flash-reset; > + }; > +}; > -- > 2.29.2 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv Looks good to me. Reviewed-by: Anup Patel Regards, Anup