From: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Mathew McBride <matt@traverse.com.au>,
linux-rtc@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: rtc: add Epson RX-8025 and RX-8035
Date: Fri, 9 Jul 2021 16:19:49 +0900 [thread overview]
Message-ID: <CABMQnV+zxURp2K3aXjH3cobndoAXjTdb4xB4w+mMJmjnwyPyLg@mail.gmail.com> (raw)
In-Reply-To: <YOYiDlQM/xfgb0CH@piout.net>
Hi,
2021年7月8日(木) 6:52 Alexandre Belloni <alexandre.belloni@bootlin.com>:
>
> On 08/07/2021 06:46:31+0900, Nobuhiro Iwamatsu wrote:
> > Hi,
> >
> > 2021年7月7日(水) 16:17 Mathew McBride <matt@traverse.com.au>:
> > >
> > > These are supported by the rtc-rx8025 module. RX-8025
> > > also has support in ds1307 due to compatible time registers.
> > >
> > > Signed-off-by: Mathew McBride <matt@traverse.com.au>
> > > ---
> > > Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> > > index 7548d8714871..13925bb78ec7 100644
> > > --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> > > +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> > > @@ -32,6 +32,9 @@ properties:
> > > - dallas,ds3232
> > > # I2C-BUS INTERFACE REAL TIME CLOCK MODULE
> > > - epson,rx8010
> > > + # I2C-BUS INTERFACE REAL TIME CLOCK MODULE
> > > + - epson,rx8025
> > > + - epson,rx8035
> >
> > 'epson,rx8035' is unnsecessary.
> > This lists compatible string, so we don't list compatible that doesn't exist.
> >
>
> Well, the previous patch adds it.
>
I couldn't find anything to add "epson,rx8035" as device tree compatible in
previous patch(rtc: rx8025: implement RX-8035 support)....
I think that i2c_device_id was added and it is not device tree compatible.
Can you tell me if my understanding is wrong?
Best regards,
Nobuhiro
--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6
next prev parent reply other threads:[~2021-07-09 7:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 7:16 [PATCH 0/2] Implement EPSON RX-8035 support Mathew McBride
2021-07-07 7:16 ` [PATCH 1/2] rtc: rx8025: implement " Mathew McBride
2021-07-07 21:38 ` Nobuhiro Iwamatsu
2021-07-07 7:16 ` [PATCH 2/2] dt-bindings: rtc: add Epson RX-8025 and RX-8035 Mathew McBride
2021-07-07 21:46 ` Nobuhiro Iwamatsu
2021-07-07 21:52 ` Alexandre Belloni
2021-07-09 7:19 ` Nobuhiro Iwamatsu [this message]
2021-07-10 0:40 ` Alexandre Belloni
2021-07-12 0:02 ` Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABMQnV+zxURp2K3aXjH3cobndoAXjTdb4xB4w+mMJmjnwyPyLg@mail.gmail.com \
--to=iwamatsu@nigauri.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=matt@traverse.com.au \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).