From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82560C4727D for ; Tue, 6 Oct 2020 11:28:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DFE2208FE for ; Tue, 6 Oct 2020 11:28:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hrxbO60V" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726002AbgJFL2u (ORCPT ); Tue, 6 Oct 2020 07:28:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbgJFL2u (ORCPT ); Tue, 6 Oct 2020 07:28:50 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D991BC061755 for ; Tue, 6 Oct 2020 04:28:49 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id u21so17102514eja.2 for ; Tue, 06 Oct 2020 04:28:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=2vvG/38iYkkylR6w34R2r+nRTlYCoIkRe19OvI4lRc4=; b=hrxbO60V/hPLxrYeUYlJ3J5Az9QciMZAF76VueconZzmsK8KwfHn63EpQsgSuWQNBD HEeRandDuYIEDntAyi2W3TEUe1onKU40ANy2Nvd6M5eByGJD+Hlt+X5/wDoN2EvzYmnl ULtO83D48xTU0zhF8cUyznBG8x4zAzH8Jrl/CagEc1SAcvvSGMcDSc3flRy9ogN+EZh3 spXPPegV2jYKDBvrnes95T8amnfqDLtfR7yAjoiA8xuusFL42YsyRXXvBn8u6vs0L2zd 1BCU5gK8v8S2Oih4g/gvgb7VvvPcyCpv4crgfH/0Qp/USXcp6Ru0mgqX9qx7Q+WIF/dZ Jlkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2vvG/38iYkkylR6w34R2r+nRTlYCoIkRe19OvI4lRc4=; b=MUFwCAB+Aq4dJNk0ew8gcnEwTcw1nJ7BG4SnO58u0mE1NI+wjqFUipHQec4PAt/Izq bwO4XM2gnGKJ1XPUp5gVRwB5etlzfHoF5bCDlBvQPXTCCRK9yiCSnzXTgp0rSSIauGnW 3fsk/l5So/Ayhvtq3111rBijgRN5z7xV3I4G8TwKgzKPkxt+WcEARtk8v/CbAwvVHT8F N2F2X4OL73ZOOZSBF4icrPBBQzpDprPK2fV2nc7t4AUm1CHZkOlg3XUz38z2t5ilJlb7 k4NH8oVe3ai4fRXZKO1evDeDQRKI2VZi4iFn1JoPJebiCzBX50cvlcoi48W1n+MWensK Hizg== X-Gm-Message-State: AOAM530nURal2+Yr+t/Tz0i/E3xJZKiQKbOePTby1TF2hYKKkhOpnw/b 6bgNbv5yn2o4BnVjmICwMP9rnTnCDCQoKxkuMwY/jw== X-Google-Smtp-Source: ABdhPJy2UFpnkhb+kG7sAOgYlKcybXQMCAgxn5Tz4eI4BMBsyBiQeVnV8ev5MXadG7ItYBQUiw04I3DQJcbtEiS5LTM= X-Received: by 2002:a17:906:dc5:: with SMTP id p5mr4946452eji.116.1601983727497; Tue, 06 Oct 2020 04:28:47 -0700 (PDT) MIME-Version: 1.0 References: <20201005071403.17450-1-ricardo.canuelo@collabora.com> <20201005071403.17450-4-ricardo.canuelo@collabora.com> <20201006061317.rs63e3dh4grxij2v@rcn-XPS-13-9360> In-Reply-To: <20201006061317.rs63e3dh4grxij2v@rcn-XPS-13-9360> From: Guenter Roeck Date: Tue, 6 Oct 2020 04:28:36 -0700 Message-ID: Subject: Re: [PATCH 3/3] dt-bindings: mfd: google,cros-ec: add missing properties To: =?UTF-8?Q?Ricardo_Ca=C3=B1uelo?= Cc: Rob Herring , Collabora Kernel ML , Enric Balletbo i Serra , Benson Leung , Guenter Roeck , Simon Glass , Doug Anderson , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Oct 5, 2020 at 11:13 PM Ricardo Ca=C3=B1uelo wrote: > > Hi Rob, > > thanks for reviewing the patch. Find my comments below: > > On lun 05-10-2020 10:37:09, Rob Herring wrote: > > > + '#address-cells': > > > + enum: [1, 2] > > > + > > > + '#size-cells': > > > + enum: [0, 1] > > > > This doesn't really make sense. Either there's a size or there isn't. > > > > [...] > > > > > + "^regulator@[a-f0-9]+$": > > > + "^ec-codec@[a-f0-9]+$": > > > > What does the number space represent and is it the same for each of > > these? If not, then this is kind of broken. There's only 1 number > > space at a given level. > > I see what you mean. In the regulator, the unit-address means the identif= ier > for the voltage regulator and I guess it could also be defined as > simply "^regulator@[0-9]+$". In the codec, though, it's a physical base > address. > > The reg property in these has a different format, that's why I > defined #address-cells and #size-cells above to have a range of values > instead of fixed values. > > From your experience, what's the best course of action here? I can't > find a driver managing google,cros-ec-codec yet, although the binding > was submitted in January. > It seems like I am missing something. In the mainline kernel: sound/soc/codecs/cros_ec_codec.c: { .compatible =3D "google,cros-ec-codec" }, Can you explain what you mean with "can't find a driver managing google,cros-ec-codec yet" ? Thanks, Guenter