From: Jassi Brar <jassisinghbrar@gmail.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "<netdev@vger.kernel.org>" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Arnd Bergmann <arnd.bergmann@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jassi Brar <jaswinder.singh@linaro.org>
Subject: Re: [PATCHv2 2/3] net: socionext: Add Synquacer NetSec driver
Date: Wed, 13 Dec 2017 21:16:24 +0530 [thread overview]
Message-ID: <CABb+yY2VoKs_6CarHjf=_B9vQH06nh+D=RYbvRpvX_x=6RiM-A@mail.gmail.com> (raw)
In-Reply-To: <CAKv+Gu-6gb10VromMaTJkzpu1DovDO7B5-GWEQPs04qAG=2ksw@mail.gmail.com>
On Tue, Dec 12, 2017 at 10:54 PM, Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
> On 12 December 2017 at 17:15, <jassisinghbrar@gmail.com> wrote:
....
>> +
>> +static int netsec_netdev_load_microcode(struct netsec_priv *priv)
>> +{
>> + int err;
>> +
>> + err = netsec_netdev_load_ucode_region(
>> + priv, NETSEC_REG_DMAC_HM_CMD_BUF,
>> + le32_to_cpup(priv->eeprom_base + NETSEC_EEPROM_HM_ME_ADDRESS_H),
>> + le32_to_cpup(priv->eeprom_base + NETSEC_EEPROM_HM_ME_ADDRESS_L),
>> + le32_to_cpup(priv->eeprom_base + NETSEC_EEPROM_HM_ME_SIZE));
>
> ... here, and in other places below, you are still dereferencing
> eeprom_base as if it is a pointer, which is not allowed with in the
> __iomem address space. This should use readl() instead [which happens
> to incorporate the endian swap as well]
>
Ahh, how could it have been just two revisions!
thanks
next prev parent reply other threads:[~2017-12-13 15:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 17:14 [PATCHv2 0/3] Socionext Synquacer NETSEC driver jassisinghbrar
2017-12-12 17:15 ` [PATCHv2 1/3] dt-bindings: net: Add DT bindings for Socionext Netsec jassisinghbrar
[not found] ` <1513098921-21042-1-git-send-email-jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-12 17:29 ` Mark Rutland
2017-12-20 8:02 ` Jassi Brar
2017-12-26 23:01 ` Rob Herring
2017-12-12 20:37 ` Andrew Lunn
2017-12-20 8:06 ` Jassi Brar
[not found] ` <1513098873-20977-1-git-send-email-jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-12 17:15 ` [PATCHv2 2/3] net: socionext: Add Synquacer NetSec driver jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w
2017-12-12 17:24 ` Ard Biesheuvel
[not found] ` <CAKv+Gu-6gb10VromMaTJkzpu1DovDO7B5-GWEQPs04qAG=2ksw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-12 20:44 ` Andrew Lunn
2017-12-12 20:48 ` Andrew Lunn
[not found] ` <20171212204811.GD1523-g2DYL2Zd6BY@public.gmane.org>
2017-12-13 15:46 ` Jassi Brar
2017-12-13 15:46 ` Jassi Brar [this message]
2017-12-12 17:16 ` [PATCHv2 3/3] MAINTAINERS: Add entry for Socionext ethernet driver jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABb+yY2VoKs_6CarHjf=_B9vQH06nh+D=RYbvRpvX_x=6RiM-A@mail.gmail.com' \
--to=jassisinghbrar@gmail.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd.bergmann@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jaswinder.singh@linaro.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).