From: Shane Francis <bigbeeshane@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
heiko@sntech.de, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: clock: update rk3588 clock definitions
Date: Sun, 26 Mar 2023 17:57:00 +0100 [thread overview]
Message-ID: <CABnpCuCKYBb_JBqBgMfjEvzUjkzQ6RgKbz9Ny78L+tPKs55wwQ@mail.gmail.com> (raw)
In-Reply-To: <1b9c8e19-10f2-824d-9b50-51e7a9287bb1@linaro.org>
Hi Krzysztof
So mention this in the commit msg.
On Sun, Mar 26, 2023 at 3:51 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 26/03/2023 14:02, Shane Francis wrote:
> >> Please wrap commit message according to > > Linux coding style /
> > submission
> >
> > Will do, I haven't submitted patches for a while totally forgot the
> > wrapping guidelines
> >
> >> Unfortunately the reason is not good enough > for ABI break. Replace
> >> vendor boot uboots with open-source one or > just correct them (it's still
> >> U-Boot so even for vendor one you have the source).
> >
> > Replacing uboot is fine for this case, however I can foresee that can cause
> > issues further down the line.
> >
> >
> > 1. No uboot source from the vendor, we all know no everyone respects code
> > licencing
> >
> > 2. Secure environments (like android tables), this chipset will likely end
> > up in android tablets that have the secure boot chain enable. These will be
> > unable to replace uboot even if source is available.
>
> So mention this in the commit msg.
>
> >
> > As this SoC is new to the Linux kernel (not even useable for much it's
> > current state) would it not be better to aling on this so vendor and
> > mainline DTS "agree" now rather than possibly have to address is in the
> > future ?
>
> Then commit msg should also mention it.
>
>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-03-26 16:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 0:15 [PATCH 1/2] arm64: dts: Add basic NanoPi R6S (RK3588S) Support Shane Francis
2023-03-26 0:15 ` [PATCH 2/2] dt-bindings: clock: update rk3588 clock definitions Shane Francis
2023-03-26 0:53 ` Heiko Stübner
2023-03-26 12:30 ` Shane Francis
2023-03-26 12:50 ` Peter Geis
2023-03-26 9:37 ` Krzysztof Kozlowski
2023-03-26 12:15 ` Shane Francis
[not found] ` <CABnpCuCzdbWTTp1Gc6wWPsB80J5GYw1QzKtZzzyEYU456E=1JA@mail.gmail.com>
2023-03-26 14:51 ` Krzysztof Kozlowski
2023-03-26 16:57 ` Shane Francis [this message]
2023-03-26 16:59 ` Shane Francis
2023-03-26 17:23 ` Krzysztof Kozlowski
2023-03-26 17:51 ` Shane Francis
2023-03-26 20:02 ` Krzysztof Kozlowski
2023-03-26 21:42 ` Mark Kettenis
2023-03-26 23:40 ` Shane Francis
2023-03-27 9:07 ` Heiko Stübner
2023-03-27 9:22 ` Shane Francis
2023-03-26 9:38 ` [PATCH 1/2] arm64: dts: Add basic NanoPi R6S (RK3588S) Support Krzysztof Kozlowski
2023-03-26 12:31 ` Shane Francis
2023-03-26 18:40 ` [PATCH v2 1/3] " Shane Francis
2023-03-26 18:40 ` [PATCH v2 2/3] dt-bindings: clock: update rk3588 clock definitions Shane Francis
2023-03-26 20:04 ` Krzysztof Kozlowski
2023-03-26 23:31 ` Shane Francis
2023-03-26 18:40 ` [PATCH v2 3/3] arm64: dts: Add FriendlyElec NanoPi R6S device binding Shane Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABnpCuCKYBb_JBqBgMfjEvzUjkzQ6RgKbz9Ny78L+tPKs55wwQ@mail.gmail.com \
--to=bigbeeshane@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).