From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66B39CCA47F for ; Fri, 24 Jun 2022 10:33:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230032AbiFXKdD (ORCPT ); Fri, 24 Jun 2022 06:33:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229970AbiFXKdC (ORCPT ); Fri, 24 Jun 2022 06:33:02 -0400 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F310C6277; Fri, 24 Jun 2022 03:33:00 -0700 (PDT) Received: by mail-il1-x136.google.com with SMTP id o4so1195388ilm.9; Fri, 24 Jun 2022 03:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=U226G+gJXjVu8Couc5Qv56p1SRGwVv16nFZEn3RxVtU=; b=WZpsM51CgSRUFkewgWRiMqQCwdfKsPxTQTY1/FdwFAv5v1w7p4JLgRHq9illM8ReYx z2I4w1oylu873NcQ0QfYk817rCiBPB0mGufQXo76zV/Icu9IEwOjioYXN0WrZaKX6cL9 07Rb+d983LgBkl7ZA2fWK1F/kNdQF9BiZL9Ob4HxWbn3065/DVrpR2hnCisuhiIvh29F a1SdXgqZZPfRMBvTu2ZBrFXqF+/UDBm+1z8lmHXxgxBO4vl/CMvHhqBbS1k+4Bl/Ubp3 3Gnny6BLEYiAhqOwP9WZrt/sWfajs0WI0/NMdBj55eW9CetTpTBVfPJIFkRQKlBHknZx L3Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=U226G+gJXjVu8Couc5Qv56p1SRGwVv16nFZEn3RxVtU=; b=NshXzbaHHDUb4/GW9hDCkuuVfreEfA657/7/DSr4RAWAnJdNNxItmBotumPNwUk0vG GTsAAYiDRoznYyc21jSN9fZsvZlMRaI8hFMbDwpZe1UdlvlHBvQmt84YCJAq2uKHbkKm PSoqL/WBZqIk+R3b9dw5QCkiEyN2MZBcYHz+O8qn/G0xgS8jVM0X8RjZl6/XUum0VO0U VoPx/pxI3BdZ2E5SQa7ahUmKv7nA0O8+6gquEEPFWgX+vy+gpW2+xtJdvNJ1a7fb1fca 73XXuDZ9SqJIYCP/H8b/6c44L0Z9d59FwjKt0u9T7v6TySF3wbbl3jFlXzthX09UhQA+ oGHw== X-Gm-Message-State: AJIora+VG60lyNBVeaMeIJqK9HJGCeYVCz+VbAT07ptFt1CoIkJmGS56 eELgQi+Qvo6NlH/Q+dgoALMuxIpX6evtDFq2+AM= X-Google-Smtp-Source: AGRyM1vwKPbWsq2euM9m6UqA1rwAUWYo4r1L6FV6jbw4QbMXoRJS9w4dpuFfMGm93LZs8AZ6tCdsbCCLj6aHRPRFCko= X-Received: by 2002:a05:6e02:1bc6:b0:2d3:dba7:f626 with SMTP id x6-20020a056e021bc600b002d3dba7f626mr8034868ilv.299.1656066780324; Fri, 24 Jun 2022 03:33:00 -0700 (PDT) MIME-Version: 1.0 References: <20220623115631.22209-1-peterwu.pub@gmail.com> <20220623115631.22209-10-peterwu.pub@gmail.com> In-Reply-To: From: ChiaEn Wu Date: Fri, 24 Jun 2022 18:32:49 +0800 Message-ID: Subject: Re: [PATCH v3 09/14] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support To: Andy Shevchenko Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Andy, Thanks for your helpful comments! Andy Shevchenko =E6=96=BC 2022=E5=B9=B46=E6=9C= =8824=E6=97=A5 =E9=80=B1=E4=BA=94 =E5=87=8C=E6=99=A82:19=E5=AF=AB=E9=81=93= =EF=BC=9A > > On Thu, Jun 23, 2022 at 2:00 PM ChiaEn Wu wrote: > > > > From: ChiYuan Huang > > > > Add mt6370 DisplayBias and VibLDO support. > > ... > > > +#include > > +#include > > +#include > > +#include > > +#include > > > +#include > > Any users of this? (See below) > > > +#include > > +#include > > +#include > > +#include > > ... > > > +#define MT6370_LDO_MINUV 1600000 > > +#define MT6370_LDO_STPUV 200000 > > +#define MT6370_LDO_N_VOLT 13 > > +#define MT6370_DBVBOOST_MINUV 4000000 > > +#define MT6370_DBVBOOST_STPUV 50000 > > +#define MT6370_DBVBOOST_N_VOLT 45 > > +#define MT6370_DBVOUT_MINUV 4000000 > > +#define MT6370_DBVOUT_STPUV 50000 > > +#define MT6370_DBVOUT_N_VOLT 41 > > If UV is a unit suffix, make it _UV. > > ... > > > + .of_match =3D of_match_ptr("dsvbst"), > > Would it even be called / used if CONFIG_OF=3Dn? We got a notification from Mark telling us that this patch has been applied to git. ( https://lore.kernel.org/linux-arm-kernel/165599931844.321775.808555909233= 7130067.b4-ty@kernel.org/ ) So, should we need to make any other changes in the next submission? > > ... > > > + .regulators_node =3D of_match_ptr("regulators"), > > Ditto. > > ... > > > + for (i =3D 0; i < ARRAY_SIZE(mt6370_irqs); i++) { > > + irq =3D platform_get_irq_byname(pdev, mt6370_irqs[i].na= me); > > + > > + rdev =3D priv->rdev[mt6370_irqs[i].rid]; > > + > > + ret =3D devm_request_threaded_irq(priv->dev, irq, NULL, > > + mt6370_irqs[i].handler,= 0, > > + mt6370_irqs[i].name, rd= ev); > > + if (ret) { > > > + dev_err(priv->dev, > > + "Failed to register (%d) interrupt\n", = i); > > + return ret; > > return dev_err_probe(...); ? > > > + } > > + } > > ... > > > + for (i =3D 0; i < MT6370_MAX_IDX; i++) { > > + rdev =3D devm_regulator_register(priv->dev, > > + mt6370_regulator_descs += i, > > + &cfg); > > + if (IS_ERR(rdev)) { > > > + dev_err(priv->dev, > > + "Failed to register (%d) regulator\n", = i); > > + return PTR_ERR(rdev); > > return dev_err_probe(...); ? > > > + } > > + > > + priv->rdev[i] =3D rdev; > > + } > > ... > > > + if (!priv->regmap) { > > + dev_err(&pdev->dev, "Failed to init regmap\n"); > > + return -ENODEV; > > + } > > return dev_err_probe(...); > > -- > With Best Regards, > Andy Shevchenko Best regards, ChiaEn Wu