From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Stanley Subject: Re: [PATCH 2/2] ARM: dts: aspeed: tiogapass: Add Riser card Date: Tue, 23 Jul 2019 22:33:24 +0000 Message-ID: References: <20190722192451.1947348-1-vijaykhemka@fb.com> <20190722192451.1947348-3-vijaykhemka@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Vijay Khemka Cc: Jean Delvare , Guenter Roeck , Rob Herring , Mark Rutland , Andrew Jeffery , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "openbmc @ lists . ozlabs . org" , Sai Dasari List-Id: devicetree@vger.kernel.org On Tue, 23 Jul 2019 at 17:22, Vijay Khemka wrote: > > Team, > This patch also needs review. I separated first patch with v2 and that wa= s acked. Please review this as well. Do you have a coworker who has access to the schematics and can review the device tree? They would make a great reviewer. If no reviewer steps forward I will merge it next time I'm merging patches. Cheers, Joel > > Regards > -Vijay > > =EF=BB=BFOn 7/22/19, 12:41 PM, "Vijay Khemka" wrote: > > Added i2c mux for riser card and multiple ava card and its sensor > components for Facebook Tiogapass platform > > Signed-off-by: Vijay Khemka > --- > .../dts/aspeed-bmc-facebook-tiogapass.dts | 230 ++++++++++++++++= ++ > 1 file changed, 230 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/ar= ch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > index b7783833a58c..8d0bcb3cd419 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > @@ -12,6 +12,27 @@ > aliases { > serial0 =3D &uart1; > serial4 =3D &uart5; > + > + /* > + * Hardcode the bus number of i2c switches' channels to > + * avoid breaking the legacy applications. > + */ > + i2c16 =3D &imux16; > + i2c17 =3D &imux17; > + i2c18 =3D &imux18; > + i2c19 =3D &imux19; > + i2c20 =3D &imux20; > + i2c21 =3D &imux21; > + i2c22 =3D &imux22; > + i2c23 =3D &imux23; > + i2c24 =3D &imux24; > + i2c25 =3D &imux25; > + i2c26 =3D &imux26; > + i2c27 =3D &imux27; > + i2c28 =3D &imux28; > + i2c29 =3D &imux29; > + i2c30 =3D &imux30; > + i2c31 =3D &imux31; > }; > chosen { > stdout-path =3D &uart5; > @@ -124,6 +145,215 @@ > &i2c1 { > status =3D "okay"; > //X24 Riser > + i2c-switch@71 { > + compatible =3D "nxp,pca9544"; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <0x71>; > + > + imux16: i2c@0 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <0>; > + > + ina219@45 { > + compatible =3D "ti,ina219"; > + reg =3D <0x45>; > + }; > + > + tmp75@48 { > + compatible =3D "ti,tmp75"; > + reg =3D <0x48>; > + }; > + > + tmp421@49 { > + compatible =3D "ti,tmp75"; > + reg =3D <0x49>; > + }; > + > + eeprom@50 { > + compatible =3D "atmel,24c64"; > + reg =3D <0x50>; > + pagesize =3D <32>; > + }; > + > + i2c-switch@73 { > + compatible =3D "nxp,pca9546"; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <0x73>; > + > + imux20: i2c@0 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <0>; > + }; > + > + imux21: i2c@1 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <1>; > + }; > + > + imux22: i2c@2 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <2>; > + }; > + > + imux23: i2c@3 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <3>; > + }; > + > + }; > + > + }; > + > + imux17: i2c@1 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <1>; > + > + ina219@45 { > + compatible =3D "ti,ina219"; > + reg =3D <0x45>; > + }; > + > + tmp421@48 { > + compatible =3D "ti,tmp75"; > + reg =3D <0x48>; > + }; > + > + tmp421@49 { > + compatible =3D "ti,tmp75"; > + reg =3D <0x49>; > + }; > + > + eeprom@50 { > + compatible =3D "atmel,24c64"; > + reg =3D <0x50>; > + pagesize =3D <32>; > + }; > + > + i2c-switch@73 { > + compatible =3D "nxp,pca9546"; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <0x73>; > + > + imux24: i2c@0 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <0>; > + }; > + > + imux25: i2c@1 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <1>; > + }; > + > + imux26: i2c@2 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <2>; > + }; > + > + imux27: i2c@3 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <3>; > + }; > + > + }; > + > + }; > + > + imux18: i2c@2 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <2>; > + > + ina219@45 { > + compatible =3D "ti,ina219"; > + reg =3D <0x45>; > + }; > + > + tmp421@48 { > + compatible =3D "ti,tmp75"; > + reg =3D <0x48>; > + }; > + > + tmp421@49 { > + compatible =3D "ti,tmp75"; > + reg =3D <0x49>; > + }; > + > + eeprom@50 { > + compatible =3D "atmel,24c64"; > + reg =3D <0x50>; > + pagesize =3D <32>; > + }; > + > + i2c-switch@73 { > + compatible =3D "nxp,pca9546"; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <0x73>; > + > + imux28: i2c@0 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <0>; > + }; > + > + imux29: i2c@1 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <1>; > + }; > + > + imux30: i2c@2 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <2>; > + }; > + > + imux31: i2c@3 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <3>; > + }; > + > + }; > + > + }; > + > + imux19: i2c@3 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <3>; > + > + i2c-switch@40 { > + compatible =3D "ti,ina219"; > + reg =3D <0x40>; > + }; > + > + i2c-switch@41 { > + compatible =3D "ti,ina219"; > + reg =3D <0x41>; > + }; > + > + i2c-switch@45 { > + compatible =3D "ti,ina219"; > + reg =3D <0x45>; > + }; > + > + }; > + > + }; > }; > > &i2c2 { > -- > 2.17.1 > > >