From: Joel Stanley <joel@jms.id.au>
To: Andrei Kartashev <a.kartashev@yadro.com>
Cc: Andrew Geissler <geissonator@gmail.com>,
Andrew Jeffery <andrew@aj.id.au>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] ARM: dts: aspeed: add device tree for YADRO VEGMAN BMC
Date: Mon, 6 Dec 2021 22:39:41 +0000 [thread overview]
Message-ID: <CACPK8Xcpg+V7BB6vq8oqqu=g7FRoTLLmz7-4G5Cp=hn0ziEuyw@mail.gmail.com> (raw)
In-Reply-To: <368313b889cbadc267b053cd808b080e9f6470a0.camel@yadro.com>
On Sat, 20 Nov 2021 at 15:51, Andrei Kartashev <a.kartashev@yadro.com> wrote:
>
> >
> > Can we utilize
> > https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md
> > to get some consistent naming across the GPIO’s on OpenBMC machines?
> >
>
> Some names here are standard for Intel daemons like x86-power-control,
> host-error-monitor, pfr-manager, IntrusionSensor and so on. Other lines
> just called same as in schematics to make it easy for our engineers to
> understand what does it refer to. BTW, most of the lines there not used
> by software and appeared just because dts files are supposed to be
> hardware description and thus we describe all we have in schematics.
>
> We can rename all this according to guide you mention, but are you
> sure, there is any sense to do so?
> Keep in mind, currently there are lot of dts files which also don't
> follow convention, so I believe, it is unnecessary work.
I have a strong preference for using the naming document. It provides
consistency, which makes it easier to review. I'm encouraging that for
any new dts.
If you think it makes the descriptions less useful for your platform
then that's a reasonable reason to not follow the convention.
Cheers,
Joel
next prev parent reply other threads:[~2021-12-06 22:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 12:00 [PATCH v2 0/2] ARM: dts: device tree for YADRO VEGMAN BMC Andrei Kartashev
2021-11-19 12:00 ` [PATCH v2 1/2] dt-bindings: vendor-prefixes: add YADRO Andrei Kartashev
2021-11-30 0:10 ` Rob Herring
2021-11-19 12:00 ` [PATCH v2 2/2] ARM: dts: aspeed: add device tree for YADRO VEGMAN BMC Andrei Kartashev
2021-11-19 20:30 ` Andrew Geissler
2021-11-20 15:51 ` Andrei Kartashev
2021-12-06 22:39 ` Joel Stanley [this message]
2021-12-07 8:11 ` Milton Miller II
2021-12-07 8:37 ` Andrei Kartashev
2021-12-06 13:15 ` [PATCH v2 0/2] ARM: dts: " Andrei Kartashev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPK8Xcpg+V7BB6vq8oqqu=g7FRoTLLmz7-4G5Cp=hn0ziEuyw@mail.gmail.com' \
--to=joel@jms.id.au \
--cc=a.kartashev@yadro.com \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=geissonator@gmail.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).