Re: [PATCH v6 1/2] dt-bindings: pinctrl: Add bindings for Awinic AW9523/AW9523B

From: Linus Walleij <linus.walleij@linaro.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: David Bauer <mail@david-bauer.net>,
	lgirdwood@gmail.com, broonie@kernel.org,
	 linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@somainline.org>
Subject: Re: [PATCH v6 1/2] dt-bindings: pinctrl: Add bindings for Awinic AW9523/AW9523B
Date: Tue, 5 Mar 2024 23:25:09 +0100	[thread overview]
Message-ID: <CACRpkdY2jfszTNvUHxc8-AXFwZKQaaOkcTwZrAiKi2rU5tTn6g@mail.gmail.com> (raw)
In-Reply-To: <CAL_Jsq+sHy=mr0paWvxOL8yT9TwuaJdfapX0sFkOJFtjCqoT1w@mail.gmail.com>

On Tue, Mar 5, 2024 at 6:28 PM Rob Herring <robh+dt@kernel.org> wrote:

> Linus, did you just apply this 3 year old bit-rotted patch? Linux-next
> now warns:

Not "just", I did run checks on it first i.e.:
$ make DT_SCHEMA_FILES=Documentation/devicetree/bindings/pinctrl/awinic,aw9523-pinctrl.yaml
dt_binding_check
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/dtc/dtc.o
  HOSTCC  scripts/dtc/flattree.o
  HOSTCC  scripts/dtc/fstree.o
  HOSTCC  scripts/dtc/data.o
  HOSTCC  scripts/dtc/livetree.o
  HOSTCC  scripts/dtc/treesource.o
  HOSTCC  scripts/dtc/srcpos.o
  HOSTCC  scripts/dtc/checks.o
  HOSTCC  scripts/dtc/util.o
  LEX     scripts/dtc/dtc-lexer.lex.c
  YACC    scripts/dtc/dtc-parser.tab.[ch]
  HOSTCC  scripts/dtc/dtc-lexer.lex.o
  HOSTCC  scripts/dtc/dtc-parser.tab.o
  HOSTLD  scripts/dtc/dtc
  LINT    Documentation/devicetree/bindings
usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [-f
{parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v]
[FILE_OR_DIR ...]
yamllint: error: one of the arguments FILE_OR_DIR - is required
  CHKDT   Documentation/devicetree/bindings/processed-schema.json
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json

So that's at least something but apparently not enough, hm the yamllint moaning
should be a hint should it not... it's on v6.8-rc1.

> ./Documentation/devicetree/bindings/pinctrl/awinic,aw9523-pinctrl.yaml:49:2:
> [error] missing starting space in comment (comments)
> ./Documentation/devicetree/bindings/pinctrl/awinic,aw9523-pinctrl.yaml:56:11:
> [error] string value is redundantly quoted with any quotes
> (quoted-strings)

They were so simple that I just fixed them up in-tree.

> Also, David's S-o-b is missing if you picked up this one.

I mailed David about it.

Yours,
Linus Walleij