From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5850BC433E0 for ; Wed, 10 Jun 2020 09:44:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FA032078D for ; Wed, 10 Jun 2020 09:44:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AMgNG3Lb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727913AbgFJJoU (ORCPT ); Wed, 10 Jun 2020 05:44:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727007AbgFJJoU (ORCPT ); Wed, 10 Jun 2020 05:44:20 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B403BC03E96F for ; Wed, 10 Jun 2020 02:44:18 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id y11so1634103ljm.9 for ; Wed, 10 Jun 2020 02:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=svyjfmEJc3+r5Bull8lSuu/qgDN2rTAndZ5rJi9Ba2o=; b=AMgNG3LbXSbZD6eBl2/IEceHF5cilPgFw2K3RxPXAl8WAyTiHclajD38G1Tc2Q7IIL JSAl5vPSokAFzuD6dghWzOBP8VQeaIBnEhmG7l6DbIj5XLzYlaKFxl68kpyO7qxTJuch Oknbf4oKQ2BxCbsKbeM4DVYh+BL5fS+J3SitSurgrSviegmUdN1RTWASwgL5E7dK3Eea ftChCFiQWkpFaq8mqhE2kLdcsDJoZmen1UBhmI1jCJ/cSLyTijZ0xSpCTHcX9e5qpBOV KK4npBNbzohL21ccWphgOTo20/ZK6StWglohLHKmhPuVh27p5gBk18RwPFlLeJWaHDQQ dH/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=svyjfmEJc3+r5Bull8lSuu/qgDN2rTAndZ5rJi9Ba2o=; b=mILCV4p1kQ73/HEU/iNp3iz2bFYch4M8grEw9w8/ZtIYesCEatFK+VzEwGFKcZ3Tzt Gl+OI2EmCo+OEjxYhQL3f07eGQ0zfoqwPxsJdDAk2W39kitBcIOX0ouKhE2ai05HoQp3 RM+8nSkoXqcM411pFxwvvxIHxzoAtHuUQfI/8ym2jZNEEDM0W7cPxxBXd6oFpHjbbpR4 y2R6BuGOx/hONiETn7rok52eulCNmOh441JtJBpqtdS3BAYhRvY3sSbakT41QMfgnv9f IeTMrddMJmEkXjJU99ENbHgNVlz7VjhAQPJS2RpTRWTcPtqR+8LVS4bILLb7fPKZw3q0 /KQg== X-Gm-Message-State: AOAM530WpFpuS11tRaqOzvO2vbnvUUmWxyEsBFuwltUzLpySWUCfSeCB Ap3FlAONYYYzQVwNFcwszUVL1AUFSNPk5M7KPhCmFw== X-Google-Smtp-Source: ABdhPJxUjW4GtVDMwGhimJkXUwNvX7Tr9JwCOPxfrbQrulwUS0MDRdszf4lJ44i0EOIMa/Nnos4vHOhpiJdziWPCCqs= X-Received: by 2002:a2e:350a:: with SMTP id z10mr1266313ljz.104.1591782257094; Wed, 10 Jun 2020 02:44:17 -0700 (PDT) MIME-Version: 1.0 References: <20200605224403.181015-1-sebastian.reichel@collabora.com> <20200605224403.181015-3-sebastian.reichel@collabora.com> In-Reply-To: <20200605224403.181015-3-sebastian.reichel@collabora.com> From: Linus Walleij Date: Wed, 10 Jun 2020 11:44:05 +0200 Message-ID: Subject: Re: [PATCHv2 2/6] power: supply: gpio-charger: Make gpios optional To: Sebastian Reichel Cc: Sebastian Reichel , Rob Herring , Emil Velikov , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Linux PM list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , kernel@collabora.com, Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Jun 6, 2020 at 12:44 AM Sebastian Reichel wrote: > While strongly recommended, not all devices have a gpio to > detect if the charger is connected. This moves the 'gpios' > from required to optional section. > > This also modifies error handling for the GPIO a bit: We > no longer fallback to pdata, if a GPIO is specified using > GPIO descriptor tables. This is a bit cleaner and does > not have any real impact: There are only two mainline pdata > users (arm/mach-sa1100/collie.c, arm/mach-pxa/tosa.c) and > none of them specify the GPIO via gpiod descriptor tables. > Once both have been converted the driver's support for > specifying GPIOs numbers in pdata will be dropped. > > Signed-off-by: Sebastian Reichel Reviewed-by: Linus Walleij Yours, Linus Walleij