From: Linus Walleij <linus.walleij@linaro.org>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Johan Hovold <johan@kernel.org>,
Michael Welling <mwelling@ieee.org>,
Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/4] tools: gpio: Add necessary include paths
Date: Tue, 23 Feb 2016 14:26:09 +0100 [thread overview]
Message-ID: <CACRpkdYxDeKDLN8bsA0q3F_q-WiSDd1JTEsw8YYwUXSecMmsoA@mail.gmail.com> (raw)
In-Reply-To: <1456214089-13954-2-git-send-email-mpa@pengutronix.de>
On Tue, Feb 23, 2016 at 8:54 AM, Markus Pargmann <mpa@pengutronix.de> wrote:
> Add include paths to the Makefile so that linux/gpio.h can be found even
> on systems without this header.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
(...)
> -CFLAGS += -Wall -g -D_GNU_SOURCE
> +CFLAGS += -Wall -g -D_GNU_SOURCE -I ../include -I ../../include/uapi
This is probably not how userspace compilation is supposed
to work. The way I understand it, userspace programs from tools/*
should be compiled like this:
make headers_install ARCH=foo INSTALL_HDR_PATH=<bar>
cd tools/gpio
make CFLAGS="$CFLAGS -I<bar>"
The reason being that UAPI files can differ after install depending
on arch.
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-02-23 13:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 7:54 [PATCH 1/4] tools: gpio: Small updates for output format Markus Pargmann
2016-02-23 7:54 ` [PATCH 2/4] tools: gpio: Add necessary include paths Markus Pargmann
2016-02-23 13:26 ` Linus Walleij [this message]
2016-02-24 6:39 ` Markus Pargmann
2016-02-23 7:54 ` [PATCH 3/4] gpio: dt-bindings: Declare gpio-hog optional for GPIO subnodes Markus Pargmann
2016-02-23 13:37 ` Linus Walleij
2016-02-23 23:25 ` Rob Herring
2016-02-24 7:01 ` Markus Pargmann
2016-03-02 15:41 ` Rob Herring
2016-03-09 4:07 ` Linus Walleij
2016-03-09 3:53 ` Linus Walleij
2016-03-09 4:27 ` Rob Herring
2016-03-09 5:56 ` Linus Walleij
2016-02-23 7:54 ` [PATCH 4/4] gpio: Add parsing of DT GPIO line-names Markus Pargmann
2016-02-23 13:36 ` Linus Walleij
2016-02-24 7:03 ` Markus Pargmann
2016-03-15 8:41 ` Linus Walleij
2016-02-23 13:21 ` [PATCH 1/4] tools: gpio: Small updates for output format Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYxDeKDLN8bsA0q3F_q-WiSDd1JTEsw8YYwUXSecMmsoA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=acourbot@nvidia.com \
--cc=bamvor.zhangjian@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=johan@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=mwelling@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).