From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v3 0/4] gpio: driver for the RPi3 GPIO expander Date: Tue, 6 Feb 2018 14:42:48 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Baruch Siach Cc: Dave Stevenson , Eric Anholt , Stefan Wahren , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michael Zoran , linux-rpi-kernel , Linux ARM , Rob Herring , Frank Rowand List-Id: devicetree@vger.kernel.org On Tue, Jan 16, 2018 at 1:45 PM, Baruch Siach wrote: > The Raspberry Pi 3 has a GPIO expander that controls, among others, the > activity LED, and the camera connector GPIOs. The GPIO expander on an I2C bus > that is not directly controlled from the ARM core. The VC4 firmware controls > the I2C bus, and allows the ARM core to set/get GPIO settings over its mailbox > interface. > > This series adds support for the RPi3 expander. > > The driver is ported from the downstream kernel at > https://github.com/raspberrypi/linux/, branch rpi-4.9.y. > > Changes in v3: > > * Kconfig tweaks > * Check rpi_exp_gpio_get_polarity() return value > * Redundant header removal > * Redundant platform_set_drvdata() call removal > * Small coding style changes All is looking pretty good. I see Rob had some last minute comments, but please rebase and repost post v4.16-rc1 so we can get this merged, we need to get this upstream. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html