From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 References: <1562576868-8124-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1562576868-8124-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> In-Reply-To: <1562576868-8124-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> From: Linus Walleij Date: Mon, 29 Jul 2019 01:02:14 +0200 Message-ID: Subject: Re: [PATCH RFC 2/7] pinctrl: sh-pfc: remove incomplete flag "cfg->type" Content-Type: text/plain; charset="UTF-8" To: Yoshihiro Shimoda Cc: Geert Uytterhoeven , "thierry.reding@gmail.com" , Rob Herring , Mark Rutland , "open list:GPIO SUBSYSTEM" , linux-pwm@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas List-ID: On Mon, Jul 8, 2019 at 11:08 AM Yoshihiro Shimoda wrote: > The old commit c58d9c1b26e3 ("sh-pfc: Implement generic pinconf > support") broke the cfg->type flag to PINMUX_TYPE_FUNCTION because > sh_pfc_pinconf_set() didn't call sh_pfc_reconfig_pin(). > Now if we fix the cfg->type condition, it gets worse because: > - Some drivers might be deferred so that .set_mux() will be called > multiple times. > - In such the case, the sh-pfc driver returns -EBUSY even if > the group is the same, and then that driver fails to probe. > > Since the pinctrl subsystem already has such conditions according > to @set_mux and @gpio_request_enable, this patch just remove > the incomplete flag from sh-pfc/pinctrl.c. > > Signed-off-by: Yoshihiro Shimoda This looks like it should have a Fixes: tag as well. Geert will decide what to do with this. Can all the pinctrl patches be applied independently of the other changes so Geert can apply and send me those patches in his pull requests? Yours, Linus Walleij