From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B16D0C4320E for ; Wed, 11 Aug 2021 09:11:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C15460F55 for ; Wed, 11 Aug 2021 09:11:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236584AbhHKJLx (ORCPT ); Wed, 11 Aug 2021 05:11:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236369AbhHKJLx (ORCPT ); Wed, 11 Aug 2021 05:11:53 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3147C061765 for ; Wed, 11 Aug 2021 02:11:29 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id m18so3453094ljo.1 for ; Wed, 11 Aug 2021 02:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=45L965AHZgo82l4aN2SrSPr1cis24KkD7elj4CXl2IE=; b=tHkB54ySsHx551ghZG3oiWj9E5OW/jA0gsGikYmUj5abrUVPS1pVfN3YxmEs2Txlur ZUKxCfCNrdIg4aTp9DKXjGgZMeKIi7GQEmtRY7jd6QCzL89NhZceOeCtuySmIX8VXHB0 +fwB+P1mzXXtfPraNDkgH0mZOQmFtC97CavMsU6Y7KYupLPgkK2B5BYh77cPr/720/ks CK6XjfVWlCWsRwnBexZGmArWthojlDpRrGh4UTWPSanKqLH2ldait5j3KFIvWCI5ji6d 67JYZJ2Xm+uVc0Cv6VHJn5x7tGKGvldtq2Kcfk0d1vuVQbKOsUwkjr5fuAm0fDlrX5yC TbXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=45L965AHZgo82l4aN2SrSPr1cis24KkD7elj4CXl2IE=; b=P15LF9/2TdlD8fxYimWGDl4hoBesjqFVaa9pkWCRExQ7OSOXGjxVTkNUt64L5+LEt2 7Oj+rPrCUdhUSoKRdpGA/PO+uoQ1MsKvyIjIr5sJ7xvV5cmtdixtCzR0QRXBWrf4+ZMZ CwnAE5IKL/kxXvfCWhNr15H2+JbOnLrzQ3Wu4BWeJU9XlW7Jf9fjT+R7CK67rD1YzJnk 0yMhkOZqIs7YfCxSAK9pZdh+8Z+aJ7vOTeO1+/fFc8UsfzkRioPkq0jcQkuooe8E5C2V CnPt767A3OJNbwIMp/Mf6u0NwCJKBOzBen/yeV3xpd+rH6w9wx3BcJQV1fwh3SxzyLqo AjWQ== X-Gm-Message-State: AOAM5304cczA4J4mvrgSkYSuMMKpgID+AtuOCdXj17snySOnFvNsJPXc tGmTAPZheovS4BqscWmLamne88NtklGs8elM5Od13Q== X-Google-Smtp-Source: ABdhPJzRqUz/cks6mC/kThItyPh6HXSuFGyiXatmiGVouPLRVCOkyePXj7L3M7v54DYVWz6HfqDUb6kTsZt1fLEjXvo= X-Received: by 2002:a2e:9e46:: with SMTP id g6mr2650552ljk.326.1628673088252; Wed, 11 Aug 2021 02:11:28 -0700 (PDT) MIME-Version: 1.0 References: <20210625235532.19575-1-dipenp@nvidia.com> <20210625235532.19575-10-dipenp@nvidia.com> <20210731061617.GA12414@sol> In-Reply-To: <20210731061617.GA12414@sol> From: Linus Walleij Date: Wed, 11 Aug 2021 11:11:17 +0200 Message-ID: Subject: Re: [RFC 09/11] tools: gpio: Add new hardware clock type To: Kent Gibson Cc: Dipen Patel , "thierry.reding@gmail.com" , Jon Hunter , linux-kernel , linux-tegra , "open list:GPIO SUBSYSTEM" , Bartosz Golaszewski , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Doc Mailing List , Rob Herring Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Jul 31, 2021 at 8:16 AM Kent Gibson wrote: > On Thu, Jul 29, 2021 at 08:17:22PM -0700, Dipen Patel wrote: > > > > On 6/27/21 4:36 AM, Linus Walleij wrote: > > > On Sat, Jun 26, 2021 at 1:48 AM Dipen Patel wrote: > > > > > >> gpiolib-cdev is extended to support hardware clock type, this > > >> patch reflects that fact. > > >> > > >> Signed-off-by: Dipen Patel > > > (...) > > >> case 'w': > > >> config.flags |= GPIO_V2_LINE_FLAG_EVENT_CLOCK_REALTIME; > > >> break; > > >> + case 't': > > >> + config.flags |= GPIO_V2_LINE_FLAG_EVENT_CLOCK_HARDWARE; > > >> + break; > > > After the checking of the command line options we need a small sanity > > > check so we don't try to enable both realtime and hardware clock > > > at the same time, we will only be able to request one of them. > > > > This will any way fail at gpiolib-cdev layer. Do we want to add it here > > > > as well? > > > > I can't speak for Linus, but I'm fine with it as is as it allows the tool > to be used to exercise the sanity check in the kernel. Fair enough, that sounds useful. Go ahead with this as-is. Yours, Linus Walleij