From: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Yong Deng <yong.deng-+3dxTMOEIRNWk0Htik3J/w@public.gmane.org>
Cc: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Mauro Carvalho Chehab
<mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Hans Verkuil
<hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>,
Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Stanimir Varbanov
<stanimir.varbanov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Hugues Fruchet <hugues.fruchet-qxv4g6HH51o@public.gmane.org>,
Yannick Fertre <yannick.fertre-qxv4g6HH51o@public.gmane.org>,
Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Benjamin Gaignard
<benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Ramesh Shanmugasundaram
<ramesh.shanmugasundaram-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>,
Sakari Ailus
<sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Rick Chang <rick.chang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH v6 2/2] media: V3s: Add support for Allwinner CSI.
Date: Sat, 27 Jan 2018 17:14:26 +0100 [thread overview]
Message-ID: <CACRpkdan52UB7HOyH1gnHWg4CDke_VQxAdq8cBgwUroibE59Ow@mail.gmail.com> (raw)
In-Reply-To: <1516695531-23349-1-git-send-email-yong.deng-+3dxTMOEIRNWk0Htik3J/w@public.gmane.org>
On Tue, Jan 23, 2018 at 9:18 AM, Yong Deng <yong.deng-+3dxTMOEIRNWk0Htik3J/w@public.gmane.org> wrote:
> Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2
> interface and CSI1 is used for parallel interface. This is not
> documented in datasheet but by test and guess.
>
> This patch implement a v4l2 framework driver for it.
>
> Currently, the driver only support the parallel interface. MIPI-CSI2,
> ISP's support are not included in this patch.
>
> Tested-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> Signed-off-by: Yong Deng <yong.deng-+3dxTMOEIRNWk0Htik3J/w@public.gmane.org>
This is cool stuff :)
> +void sun6i_csi_update_buf_addr(struct sun6i_csi *csi, dma_addr_t addr)
> +{
> + struct sun6i_csi_dev *sdev = sun6i_csi_to_dev(csi);
> + /* transform physical address to bus address */
> + dma_addr_t bus_addr = addr - PHYS_OFFSET;
I am sorry if this is an unjustified drive-by comment. Maybe you
have already investigate other ways to do this.
Accessing PHYS_OFFSET directly seems unintuitive
and not good practice.
But normally an dma_addr_t only comes from some
function inside <linux/dma-mapping.h> such as:
dma_alloc_coherent() for a contigous buffer which is coherent
in physical memory, or from some buffer <= 64KB that
is switching ownership between device and CPU explicitly
with dma_map* or so. Did you check with
Documentation/DMA-API.txt?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-27 16:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 8:18 [PATCH v6 2/2] media: V3s: Add support for Allwinner CSI Yong Deng
2018-01-26 0:04 ` kbuild test robot
[not found] ` <201801260759.RyNhDZz4%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-01-26 1:46 ` Yong
2018-01-26 3:00 ` Yong
2018-01-26 8:10 ` Maxime Ripard
[not found] ` <20180126081000.hy7g57zp5dv6ug2g-ZC1Zs529Oq4@public.gmane.org>
2018-01-28 2:19 ` [linux-sunxi] " Yong
[not found] ` <20180128101903.fbaec083c787bda30aeb05ef-+3dxTMOEIRNWk0Htik3J/w@public.gmane.org>
2018-01-29 8:16 ` Maxime Ripard
[not found] ` <20180126110041.f89848325b9ecfb07df387ca-+3dxTMOEIRNWk0Htik3J/w@public.gmane.org>
2018-01-31 3:08 ` Liviu Dudau
2018-01-31 3:24 ` [linux-sunxi] " Chen-Yu Tsai
[not found] ` <20180131030807.GA19945-hOhETlTuV5niMG9XS5x8Mg@public.gmane.org>
2018-01-31 7:42 ` Maxime Ripard
[not found] ` <20180131074212.7hvb3nqkt22h2chg-ZC1Zs529Oq4@public.gmane.org>
2018-01-31 14:47 ` Liviu Dudau
2018-02-01 8:32 ` [linux-sunxi] " Maxime Ripard
2018-02-01 9:20 ` Arnd Bergmann
[not found] ` <CAK8P3a01DqmVJKt6J2i_okVoeELJCUW0voW0r52EzBY7iF74xQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-01 11:34 ` Liviu Dudau
[not found] ` <20180201113442.GC19945-hOhETlTuV5niMG9XS5x8Mg@public.gmane.org>
2018-02-01 15:54 ` Maxime Ripard
2018-01-27 15:51 ` kbuild test robot
[not found] ` <1516695531-23349-1-git-send-email-yong.deng-+3dxTMOEIRNWk0Htik3J/w@public.gmane.org>
2018-01-27 16:14 ` Linus Walleij [this message]
[not found] ` <CACRpkdan52UB7HOyH1gnHWg4CDke_VQxAdq8cBgwUroibE59Ow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-28 2:39 ` Yong
2018-01-29 8:25 ` Maxime Ripard
2018-01-29 8:28 ` [linux-sunxi] " icenowy
[not found] ` <20180129082533.6edmqgbauo6q5dgz-ZC1Zs529Oq4@public.gmane.org>
2018-01-29 9:25 ` Linus Walleij
[not found] ` <CACRpkdYAGwUjr2C-w5U+WuG48pZAOUcnxFjznLbdF6Lmy1uZuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-29 14:34 ` Arnd Bergmann
2018-01-30 7:54 ` Maxime Ripard
[not found] ` <20180130075441.rqxzkwero6sdfak6-ZC1Zs529Oq4@public.gmane.org>
2018-01-30 9:24 ` Arnd Bergmann
2018-01-30 9:59 ` Thierry Reding
2018-01-30 10:01 ` Thierry Reding
2018-01-31 7:29 ` Maxime Ripard
[not found] ` <20180131072910.ajp3jc5dmetsjtf2-ZC1Zs529Oq4@public.gmane.org>
2018-01-31 9:37 ` Arnd Bergmann
[not found] ` <CAK8P3a0X2bpLjKE6xKehG1junZoG1N_DjepOBQ+SZetKf6sgfA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-01 15:29 ` Maxime Ripard
2018-02-01 15:36 ` Arnd Bergmann
2018-02-01 16:31 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdan52UB7HOyH1gnHWg4CDke_VQxAdq8cBgwUroibE59Ow@mail.gmail.com \
--to=linus.walleij-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
--cc=hugues.fruchet-qxv4g6HH51o@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=ramesh.shanmugasundaram-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org \
--cc=rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=rick.chang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=stanimir.varbanov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
--cc=yannick.fertre-qxv4g6HH51o@public.gmane.org \
--cc=yong.deng-+3dxTMOEIRNWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).