From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DFE2C4320A for ; Mon, 26 Jul 2021 07:15:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 036A060C51 for ; Mon, 26 Jul 2021 07:15:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232213AbhGZGep (ORCPT ); Mon, 26 Jul 2021 02:34:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232091AbhGZGel (ORCPT ); Mon, 26 Jul 2021 02:34:41 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A11DDC061764 for ; Mon, 26 Jul 2021 00:15:10 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id r23so7023930lji.3 for ; Mon, 26 Jul 2021 00:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cOfpNk8cBwygjzCjyHz8QRiXxo98sz2BqAuXNRnjjWg=; b=lEFUh/WH6uiITinRF/Iqnt5mx0rDbjrYjOAX+EqORbulhwCdiFCiM14vzgxuTeXiC4 U+EmK0jTo5sdIvsyHjZA1IYkt3ySBDTyc5497lw0rHm4iBT4Hsp2JUGlUblQcD/rRVCc vjTLrw7tTOB22lnDgqVA3cgwhX5qOFXWku54RtGwwhfWA4zNCmq0ObobAB8J6IuE/Euj bw7GRhZPw4K+O83v4hHeCZNltTeKX8KimIWvHSpXglmT8oFVayW9ZMwSYWOAcSFjrmIM W6z4HnsYn48XBImAeDcOHqZdfp1d0E1Hu9UwP1NbHvyREsmKlQThD4Dgo5njIWEvrmE5 zczA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cOfpNk8cBwygjzCjyHz8QRiXxo98sz2BqAuXNRnjjWg=; b=gZhIaumtSsg2kvbU+L03Xj3KFNMC40Z1HDXjJeZpXFjHnN/DBD8xB+Di71+YRHOBob h8kPjtR3e+hWauWdCV9LrkSRRShA/UKgTFnl6IkeREfWkCJOPf9y+ZRi6a4ruzWuDy23 69cBe6nWBVyfb92SbxuF/2ad2hPcZJT7KrHG+hJ9UAxm6tjRNvdBpeBs/1FvDoc2Zym1 bzPJTjKB3tCYSSfasXpf6Vt87+zyirFWHjV7+lkMcyHskmBkso55Fs3SqRnQF9V7rQsM qp9kjW0Q9dB7cHU0Nq/DFd9dpkf2gMqNGnAmtEODo2VBHVo705wAEcs7xFZiPegEhVGD Fzjg== X-Gm-Message-State: AOAM532IrwDTOhgbs1pjP0rLApM9grG6y4rWoI+Y8O4Apg9UwiSxQ228 KrKzoTxEeRROFSbGrlLo9xf8T0UY65FUl2t2fRBt/w== X-Google-Smtp-Source: ABdhPJyUe92qyD4ubvU/cbw2RdqOOoO//w6eh4gn88UzLyuYn5bk8b3ggPXevchReZQ2PP7O1b8K+LWJqxxjari5FZU= X-Received: by 2002:a2e:950:: with SMTP id 77mr11173508ljj.438.1627283708901; Mon, 26 Jul 2021 00:15:08 -0700 (PDT) MIME-Version: 1.0 References: <20210201165307.51443-1-iskren.chernev@gmail.com> In-Reply-To: <20210201165307.51443-1-iskren.chernev@gmail.com> From: Linus Walleij Date: Mon, 26 Jul 2021 09:14:57 +0200 Message-ID: Subject: Re: [PATCH v3 1/2] dt-bindings: panel: Add Samsung S6E3FA2 panel To: Iskren Chernev Cc: Rob Herring , Sam Ravnborg , Thierry Reding , Daniel Vetter , David Airlie , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:DRM PANEL DRIVERS" , linux-kernel , phone-devel@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS , Hans de Goede , Andy Shevchenko ," <~postmarketos/upstreaming@lists.sr.ht> Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Iskren, thanks for your patch! On Mon, Feb 1, 2021 at 5:56 PM Iskren Chernev wrote: > +required: > + - compatible > + - reset-gpios > + - iovdd-supply > + - vddr-supply > + - port I do not think port should be required because the DSI framework allows panels to be put as children right inside the DSI controller node without any port linking the two. Other than that it looks good! Yours, Linus Walleij