From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH V2 3/5] gpio: of: Return error if gpio hog configuration failed Date: Wed, 13 Apr 2016 14:43:08 +0200 Message-ID: References: <1457703804-3016-1-git-send-email-ldewangan@nvidia.com> <1457703804-3016-4-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1457703804-3016-4-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan Cc: Rob Herring , =?UTF-8?Q?Pawe=C5=82_Moll?= , Mark Rutland , Markus Pargmann , Stephen Warren , Thierry Reding , Benoit Parrot , Alexandre Courbot , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Fri, Mar 11, 2016 at 2:43 PM, Laxman Dewangan wrote: > If GPIO hog configuration failed while adding OF based > gpiochip() then return the error instead of ignoring it. > > This helps of properly handling the gpio driver dependency. > > When adding the gpio hog nodes for NVIDIA's Tegra210 platforms, > the gpio_hogd() fails with EPROBE_DEFER because pinctrl is not > ready at this time and gpio_request() for Tegra GPIO driver > returns error. The error was not causing the Tegra GPIO driver > to fail as the error was getting ignored. > > Signed-off-by: Laxman Dewangan > Cc: Benoit Parrot > Cc: Alexandre Courbot > Reviewed-by: Thierry Reding Rebased and applied this patch FWIW. This is a fair and square bug fix so need to go in no matter what happens with the hog patches. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html