From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v2 06/11] pinctrl: mediatek: add pinctrl support for MT6779 SoC Date: Fri, 23 Aug 2019 10:59:08 +0200 Message-ID: References: <1566206502-4347-1-git-send-email-mars.cheng@mediatek.com> <1566206502-4347-7-git-send-email-mars.cheng@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Sean Wang Cc: Mars Cheng , Matthias Brugger , Rob Herring , Marc Zyngier , Stephen Boyd , CC Hwang , Loda Chou , lkml , "moderated list:ARM/Mediatek SoC support" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , wsd_upstream@mediatek.com, mtk01761 , linux-clk , Andy Teng List-Id: devicetree@vger.kernel.org On Thu, Aug 22, 2019 at 8:12 PM Sean Wang wrote: > On Mon, Aug 19, 2019 at 2:22 AM Mars Cheng wrote: > > > > This adds MT6779 pinctrl driver based on MediaTek pinctrl-paris core. > > > > Signed-off-by: Mars Cheng > > Signed-off-by: Andy Teng > > Acked-by: Sean Wang Please look at the DT bindings as well when you have time, and especially the "virtual GPIO" patch, I don't understand that at all. I suspect the "virtual GPIO" is maybe more about something that should be done by setting up the valid_mask in the gpio_chip or something. Yours, Linus Walleij