From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C61C4338F for ; Fri, 23 Jul 2021 21:04:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A311660F38 for ; Fri, 23 Jul 2021 21:04:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231684AbhGWUYV (ORCPT ); Fri, 23 Jul 2021 16:24:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231350AbhGWUYV (ORCPT ); Fri, 23 Jul 2021 16:24:21 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0390DC061757 for ; Fri, 23 Jul 2021 14:04:54 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id h11so3189792ljo.12 for ; Fri, 23 Jul 2021 14:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+du+0LHLfACLmN4y/oi02W5K+tfyhYdkNu9bdamCZoA=; b=PU8ExjLpqbQ7v0/Tet2GfCUlvlxrEFfeIpx99CC6Xk5+aELtn+8O2bULpwHlEZGAvn NnHZbXmI78vEHdBxHtZdyoo4dhMLlT2nPyNgRDVcWyxKJotHDsvBsAI/8Q/F8l4YOnBQ AyrT7aqeEglidsG7hJLMiRgyvgQ3JRMk5SYfTEVV7ThBCZJm5KFsOk5f+lvBLw0btP4d 42l2xOo19oJRKfeJBplz2KKkTKwgw9DGVyLxFvfQXjpTCqIQwObnvEaazH8ZHwd4Oykv zukRN0buICPccVlmtRqHaOmhc4TWJsks2Iy/oXmqVOytYVEv4MmzD+t8N/9ISPqhEy9e 2cog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+du+0LHLfACLmN4y/oi02W5K+tfyhYdkNu9bdamCZoA=; b=BAf0rwrT5YqubZNO6quiMD9GoK2qJNpf9Nx3nDSe+uHr7BAb3iGxNkZ/yED7pB3ThG eBPZk1XFeGnp7k8Ew+de+ZZM1JTtiWLIbZgPUHKyCVdmmYx8VBYLF5yUmperikH2E2yv 0JWkUzxrr16/0iVbmKTSkAvFigaYxerubOXhVL+QfvIRFIyw85RPeUKikE0F09aRnMNZ kIDTW3Fmvz7lsSRpNf8ZZep7yWT/057MlaBb8VvoKFvuRJQ8HWd0n2PsbNoq7grhIImU pyhuPgmJqmK1wsXZ+IfE6Rd148THV/lM5fpE8Vh24E9o9m14s5E1KlWmPBfa2mhZXg76 AeoA== X-Gm-Message-State: AOAM5324n5EgZ2ji1o7mhTLQhgT2TE9yQrEU20WETN5jrPuGrUEgmQdt jVm+B/mv2rdjQrENutdFF8dgXTHu+yzrap7p0qHeiQ== X-Google-Smtp-Source: ABdhPJxQWYsOWFLVby006xkxrHiuFL3EnCGftMH8g5GForQjSavZnil4OEtYwmjZFYh8qrp4mdkJspxPgo3NmEIWfGc= X-Received: by 2002:a2e:9d15:: with SMTP id t21mr4501765lji.200.1627074292231; Fri, 23 Jul 2021 14:04:52 -0700 (PDT) MIME-Version: 1.0 References: <20210701002037.912625-1-drew@beagleboard.org> <20210701002037.912625-3-drew@beagleboard.org> <8c59105d32a9936f8806501ecd20e044@walle.cc> In-Reply-To: <8c59105d32a9936f8806501ecd20e044@walle.cc> From: Linus Walleij Date: Fri, 23 Jul 2021 23:04:41 +0200 Message-ID: Subject: Re: [RFC PATH 2/2] gpio: starfive-jh7100: Add StarFive JH7100 GPIO driver To: Michael Walle Cc: Drew Fustini , Rob Herring , Bartosz Golaszewski , Paul Walmsley , Palmer Dabbelt , Michael Zhu , Geert Uytterhoeven , Fu Wei , linux-kernel , "open list:GPIO SUBSYSTEM" , linux-riscv , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Emil Renner Berthing , Huan Feng Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jul 1, 2021 at 8:39 AM Michael Walle wrote: > Am 2021-07-01 02:20, schrieb Drew Fustini: > > Add GPIO driver for the StarFive JH7100 SoC [1] used on the > > BeagleV Starlight JH7100 board [2]. > > > > [1] https://github.com/starfive-tech/beaglev_doc/ > > [2] https://github.com/beagleboard/beaglev-starlight > > > > Signed-off-by: Emil Renner Berthing > > Signed-off-by: Huan Feng > > Signed-off-by: Drew Fustini > > Could this driver use GPIO_REGMAP and REGMAP_IRQ? See > drivers/gpio/gpio-sl28cpld.c for an example. To me it looks just memory-mapped? Good old gpio-mmio.c (select GPIO_GENERIC) should suffice I think. Drew please look at drivers/gpio/gpio-ftgpio010.c for an example of GPIO_GENERIC calling bgpio_init() in probe(). Yours, Linus Walleij