From: Linus Walleij <linus.walleij@linaro.org>
To: Daniel Palmer <daniel@0x0f.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] gpio: msc313: MStar MSC313 GPIO driver
Date: Thu, 5 Nov 2020 10:21:27 +0100 [thread overview]
Message-ID: <CACRpkdbx+T3uX9taZNjsURHGc6qVLvGGC2boEC4=NaOi4_uZTQ@mail.gmail.com> (raw)
In-Reply-To: <CAFr9PXnX7QyM0VUmosFYueSe4ewA7uT2VZMfxFPaFt6-jUhoSw@mail.gmail.com>
On Wed, Oct 21, 2020 at 1:07 PM Daniel Palmer <daniel@0x0f.com> wrote:
> Sorry to pester you again...
Don't worry. I'm more worried that my replies are slow.
> Before I do that I have a question that maybe you could help me with:
> Andy noted a few times that I have this driver as a built in driver
> and not a module.
> The gpio-ixp4xx.c driver is also a built in driver. Is there a reason
> why it's ok there but not this driver?
Not that I know of. There is a lot of push for modularization right
now because Android (and other distributions) likes it, so if your
SoC could be used by Android or Fedora or Debian etc it is
generally a good idea to modularize.
These distributions use the generic ARM (etc) kernel and try
to load as many drivers as possible as modules.
It is not always possible because some GPIOs might be needed
very early, such as on-chip GPIO. So you better make sure
that the platform can get to userspace also without this driver
compiled in, otherwise it *MUST* be bool so people don't get
ammunition to shoot themselves in the foot and configure a
non-bootable kernel just because they could modularize this
driver.
If your SoC is only used by OpenWrt (like ixp4xx) then it is fine
to just use bool because that distribution is always built with an
image for a specific hardware, whereas distributions are generic.
So it actually depends a bit on the usecase of the SoC.
Yours,
Linus Walleij
next prev parent reply other threads:[~2020-11-05 9:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 2:48 [PATCH 0/5] Add GPIO support for MStar/SigmaStar ARMv7 Daniel Palmer
2020-10-11 2:48 ` [PATCH 1/5] dt-bindings: gpio: Binding for MStar MSC313 GPIO controller Daniel Palmer
2020-10-12 16:10 ` Rob Herring
2020-10-16 16:36 ` Linus Walleij
2020-10-19 16:13 ` Krzysztof Kozlowski
2020-11-05 9:13 ` Linus Walleij
2020-10-11 2:48 ` [PATCH 2/5] dt-bindings: gpio: Add a binding header for the MSC313 GPIO driver Daniel Palmer
2020-10-12 16:11 ` Rob Herring
2020-10-14 9:45 ` Daniel Palmer
2020-10-14 12:17 ` Rob Herring
2020-10-11 2:48 ` [PATCH 3/5] gpio: msc313: MStar " Daniel Palmer
2020-10-16 16:56 ` Linus Walleij
2020-10-17 1:57 ` Daniel Palmer
2020-10-21 11:07 ` Daniel Palmer
2020-11-05 9:21 ` Linus Walleij [this message]
2020-11-05 9:31 ` Willy Tarreau
2020-11-05 9:42 ` Linus Walleij
2020-11-05 15:39 ` Daniel Palmer
2020-10-11 2:48 ` [PATCH 4/5] ARM: mstar: Add gpio controller to MStar base dtsi Daniel Palmer
2020-10-11 2:48 ` [PATCH 5/5] ARM: mstar: Fill in GPIO controller properties for infinity Daniel Palmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbx+T3uX9taZNjsURHGc6qVLvGGC2boEC4=NaOi4_uZTQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).