From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ADE5C35257 for ; Fri, 2 Oct 2020 22:20:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22AC6207EA for ; Fri, 2 Oct 2020 22:20:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="m5FbwErQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725497AbgJBWUw (ORCPT ); Fri, 2 Oct 2020 18:20:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725283AbgJBWUw (ORCPT ); Fri, 2 Oct 2020 18:20:52 -0400 Received: from mail-ua1-x941.google.com (mail-ua1-x941.google.com [IPv6:2607:f8b0:4864:20::941]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62F09C0613E2 for ; Fri, 2 Oct 2020 15:20:52 -0700 (PDT) Received: by mail-ua1-x941.google.com with SMTP id v5so785503uau.10 for ; Fri, 02 Oct 2020 15:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YO3BKY1t3RoujCw4IEgcApM9xQo/s9/vmUvLTebAFNM=; b=m5FbwErQrFIkbcAHJy1GVJKbl6vRV+J+dt+nYMjgxQRPRNTF+zT52nUaMxENOqrjhP wfGGITQx1Bwxme2YbRfw2q+zmy+r4MYafc0n8+L6LrKWj277oua4N5WISIphdRHMinkc mWNUIQnXPSk5zYx76rd8L+TV2t4MuZSqWGziw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YO3BKY1t3RoujCw4IEgcApM9xQo/s9/vmUvLTebAFNM=; b=XRdtEMlzSsmm6kGX9jXwnbDLFMTpBY7mXHpMc3d5/FTT3P75QOZPQgey0NWYGnxNed 3JF41bjTrZ9q58avmlbZCZZmjUCnDnIOL/m31MNLzbeZIq1wNizK/VXCBfyAi3PDYPmL tot0cG3B1VV6RmZiVVhSknPP8c+pXAal3EAt2BqH3bUtUtzddCdfQ9kUuCshnzgw7xqa +FLCOJGyJcSaKTthtoSGwgk/kKKYwVhWdrsdoI2Nu1nICcPMPiNkjM7eQRNkrR/WxZNw aqHpAFciOOuiJtxaoq1gq1dvO5Ut25OFOz+Sv758xxD/CboEgu8CRYBHB18FvnzYTJoW aBZg== X-Gm-Message-State: AOAM53160GWTr8irvLbHZ56IITq4xYJ+GLE431CgOPxpK/oud14biYPk e6hi+9apEpUjvCf33ZjPNamyOdtRWwRfxg== X-Google-Smtp-Source: ABdhPJythHzBeLDYZb2jqUHNUHN6Uacj+1uZQ/MthmIvc3tQ4d2C5LjkrOHfACDt6QrtwHvGSXBplQ== X-Received: by 2002:ab0:7143:: with SMTP id k3mr571717uao.93.1601677251104; Fri, 02 Oct 2020 15:20:51 -0700 (PDT) Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com. [209.85.221.181]) by smtp.gmail.com with ESMTPSA id w6sm477083uan.4.2020.10.02.15.20.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Oct 2020 15:20:50 -0700 (PDT) Received: by mail-vk1-f181.google.com with SMTP id c63so581205vkb.7 for ; Fri, 02 Oct 2020 15:20:50 -0700 (PDT) X-Received: by 2002:a1f:d986:: with SMTP id q128mr2544346vkg.7.1601677249682; Fri, 02 Oct 2020 15:20:49 -0700 (PDT) MIME-Version: 1.0 References: <20200929205807.2360405-1-evgreen@chromium.org> <20200929135741.1.I8b447ca96abfbef5f298d77350e6c9d1d18d00f6@changeid> In-Reply-To: <20200929135741.1.I8b447ca96abfbef5f298d77350e6c9d1d18d00f6@changeid> From: Doug Anderson Date: Fri, 2 Oct 2020 15:20:38 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: nvmem: Add qcom,sc7180-qfprom compatible string To: Evan Green Cc: Rob Herring , Bjorn Andersson , Srinivas Kandagatla , Stephen Boyd , Andy Gross , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On Tue, Sep 29, 2020 at 1:58 PM Evan Green wrote: > > Add an SoC-specific compatible string so that data can be attached > to it in the driver. > > Signed-off-by: Evan Green > --- > > Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > index 59aca6d22ff9b..b16c8e6a8c23d 100644 > --- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > @@ -14,7 +14,9 @@ allOf: > > properties: > compatible: > - const: qcom,qfprom > + enum: > + - qcom,qfprom > + - qcom,sc7180-qfprom You don't want either/or. You want both. At the time Srinivas didn't see the point of having the SoC-specific compatible string here, but now that we have a reason for it maybe he'll be convinced? IMO you essentially want: items: - enum: - qcom,apq8064-qfprom - qcom,apq8084-qfprom - qcom,msm8974-qfprom - qcom,msm8916-qfprom - qcom,msm8996-qfprom - qcom,msm8998-qfprom - qcom,qcs404-qfprom - qcom,sc7180-qfprom - qcom,sdm845-qfprom - const: qcom,qfprom For some context: -Doug > > reg: > # If the QFPROM is read-only OS image then only the corrected region > -- > 2.26.2 >