From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB004C433E0 for ; Wed, 6 Jan 2021 01:43:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 801C52082D for ; Wed, 6 Jan 2021 01:43:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725789AbhAFBnS (ORCPT ); Tue, 5 Jan 2021 20:43:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbhAFBnR (ORCPT ); Tue, 5 Jan 2021 20:43:17 -0500 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2871AC061574 for ; Tue, 5 Jan 2021 17:42:37 -0800 (PST) Received: by mail-ot1-x32a.google.com with SMTP id b24so1703558otj.0 for ; Tue, 05 Jan 2021 17:42:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8190Rw9nFurXvpyVpr5H2heqLA3Td/3zauNq8uzsNzM=; b=MKfJ7zGxTH1maYa7wKycTAhSCe7iU3Dy08HvTas4FA/zUjsnZ6Hjc05jcStbPpGZ/B g7TV1HRXxJ+RX79sAOjh9NV09M2ekhu2NPTSuTTHO9ncVhG+jBvzCjpGxG+wKMSgiOtu ZdPYyd4Chi2Xa6auJVV/rnzWGMTaQgVoK9zy0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8190Rw9nFurXvpyVpr5H2heqLA3Td/3zauNq8uzsNzM=; b=P8rTxanOX/DAR204BaLoxglmjBuYbPP4xniZYm0KLMZZwbSHLs4q6ItbfBi8XfiuNP aUUjNBKlD4/C8Zxll2ENbqspggFMRfN/khNIfwjSj7NaQ40DaynnLIBD37PX/t/N5hWI w7qScQ9OgQS71K9jMU4ZA6kbkJbPeL4qUVU3vU50fqf3OH5Il1qytM0n3Vx99cscSYyi CzuNwceZdJeUYryyL8xs3EaExxf+QsoFLsVukB3uzdofPSvt64/2+pJ8WVHXraUdTaJ0 fRSGYoP7wdPa4lyL4bw/a+ZEzSIBmgvXIGnkHG6GwqRbXg+mwhep/uCu2hucxey0eABc BiHQ== X-Gm-Message-State: AOAM530PGsAhaAJtNXssj/BpH4kvvpaUvh8QleBk50uiQHx+nmwAp3+g tVdoEj2bFM6J4pTSINwPWFJnQMQbmb2f6A== X-Google-Smtp-Source: ABdhPJxiXewKUzwz7zuH1UVTiNXY9LvpaLgnAnOknEd74j9uTEZXOJalOTGNaDzCVGbYtN4TziZ/2Q== X-Received: by 2002:a9d:5d02:: with SMTP id b2mr1668655oti.148.1609897356405; Tue, 05 Jan 2021 17:42:36 -0800 (PST) Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com. [209.85.210.49]) by smtp.gmail.com with ESMTPSA id h26sm236002ots.9.2021.01.05.17.42.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jan 2021 17:42:36 -0800 (PST) Received: by mail-ot1-f49.google.com with SMTP id j12so1641127ota.7 for ; Tue, 05 Jan 2021 17:42:36 -0800 (PST) X-Received: by 2002:ab0:2e99:: with SMTP id f25mr1914472uaa.104.1609896944481; Tue, 05 Jan 2021 17:35:44 -0800 (PST) MIME-Version: 1.0 References: <20201211222448.2115188-1-dianders@chromium.org> In-Reply-To: <20201211222448.2115188-1-dianders@chromium.org> From: Doug Anderson Date: Tue, 5 Jan 2021 17:35:33 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p To: Jiri Kosina , Benjamin Tissoires , Greg Kroah-Hartman , Dmitry Torokhov Cc: Hans de Goede , "open list:HID CORE LAYER" , Kai-Heng Feng , Rob Herring , Stephen Boyd , Andrea Borgia , Anson Huang , Bjorn Andersson , Catalin Marinas , Daniel Playfair Cal , Geert Uytterhoeven , =?UTF-8?Q?Guido_G=C3=BCnther?= , Jiri Kosina , Li Yang , Masahiro Yamada , Max Krummenacher , Michael Walle , Pavel Balan , Shawn Guo , Vinod Koul , Will Deacon , Xiaofei Tan , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Benjamin, On Fri, Dec 11, 2020 at 2:24 PM Douglas Anderson wrote: > > The goal of this series is to support the Goodix GT7375P touchscreen. > This touchscreen is special because it has power sequencing > requirements that necessitate driving a reset GPIO. > > To do this, we totally rejigger the way i2c-hid is organized so that > it's easier to jam the Goodix support in there. > > This series was: > - Tested on a device that uses normal i2c-hid. > - Tested on a device that has a Goodix i2c-hid device. > - Tested on an ACPI device, but an earlier version of the series. > > I believe the plan is for Benjamin to land the whole series. Will > said this about the arm64 defconfig change (and provided his Ack): > > ...there are a few things I really care about > > in defconfig (e.g. things like page size!), generally speaking we don't > > need to Ack everything that changes in there. > > > > That said, might be worth checking whether arm-soc have any defconfig > > changes queued in -next so you don't end up with conflicts. > > Changes in v8: > - Mark suspend/resume as static as per patches robot. > > Changes in v7: > - Rebase atop commit afdd34c5fa40 ("HID: i2c-hid: show the error ...") > > Changes in v6: > - ACPI probe function should have been "static" > - Don't export suspend/resume, just export dev_pm_ops from core. > - Fixed crash in ACPI module (missing init of "client") > - No need for regulator include in the core. > - Removed i2c_device_id table from ACPI module. > - Suspend/resume are no longer exported from the core. > > Changes in v5: > - Add shutdown_tail op and use it in ACPI. > - Added mention of i2c-hid in the yaml itself as per Rob. > - Adjusted subject as per Rob. > - i2chid_subclass_data => i2chid_ops. > - power_up_device => power_up (same with power_down). > - subclass => ops. > > Changes in v4: > - ("arm64: defconfig: Update config names for i2c-hid rejigger") new for v4. > - Fully rejigger so ACPI and OF are full subclasses. > - Totally redid based on the new subclass system. > > Changes in v3: > - Fixed compatible in example. > - Removed Benjamin as a maintainer. > - Rework to use subclassing. > - Updated description. > > Changes in v2: > - ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P") new in v2. > - Get timings based on the compatible string. > - Use a separate compatible string for this new touchscreen. > > Douglas Anderson (4): > HID: i2c-hid: Reorganize so ACPI and OF are separate modules > arm64: defconfig: Update config names for i2c-hid rejigger > dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix > GT7375P > HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core I think this series is ready to land. The "defconfig" has a trivial conflict with commit 74b87103b3d0 ("arm64: defconfig: Enable HID multitouch") against linuxnext, but it's so simple that hopefully folks will be OK with that when it lands. Please let me know if there's anything else you need me to do. :-) -Doug