From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5F16C43603 for ; Thu, 12 Dec 2019 17:00:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8244524676 for ; Thu, 12 Dec 2019 17:00:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="PEe8To71" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729907AbfLLRAL (ORCPT ); Thu, 12 Dec 2019 12:00:11 -0500 Received: from mail-il1-f193.google.com ([209.85.166.193]:40062 "EHLO mail-il1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729260AbfLLRAL (ORCPT ); Thu, 12 Dec 2019 12:00:11 -0500 Received: by mail-il1-f193.google.com with SMTP id b15so2623840ila.7 for ; Thu, 12 Dec 2019 09:00:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VFbGuOmt8927R+vYeTAQfCaDgF/GDKY3t3T6KS+4jUA=; b=PEe8To71VSS0ZUGmCNvztFYyKJaky6xNL19ZnUI4w8FyeyUpZeT18qnwk/v43/LI9H 4OMWHz3NG2O5QKX4qcDah8HVgYA3ZVKIvn8anspz21uipN5+K+4FXdIKgIhy2Fle8eEx /p/Jl28uAvIyZZ+ZkYBoy8Tg0jFkYiLByPpCw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VFbGuOmt8927R+vYeTAQfCaDgF/GDKY3t3T6KS+4jUA=; b=BZTh1T0cKygGLzBXEzINhBDg2jD4AlKETZom8R5v/Pe+FJpOoLL2C4OL+4j7L4wijg /8yQhcsCOv6uZLls3ezn6g1dqlR09E7Egy9znSGxAXADF/q5L+HgfLab1hIRx8CbKll6 uNBIim6wHdt9HfcyhmXyRFeMBwN/X6zPeF+5bY0/khRKSWkx0RX1dJsxZ6ZFj2YgHo35 bzeB7ukkUt6CLwk9Ibkhiv/LPbCHR/WpvkOYAl7I51dNxfm9tb1y4Y1XOk4ofeNFNAiN 5txV0y5iiqcVBY+VpIbldXSTMIvtucY0Q3TlAhClCO71cpu5ksfyTSYJxT8JNJUPobuE OsgQ== X-Gm-Message-State: APjAAAX0L2uCPEqVKoN8vvsk5x5PXLfrrAwW0ah6AMOrkdfD8li3pCUl fLLIVMLRL48Uxx5xOGIOO9/v/BNQxrA= X-Google-Smtp-Source: APXvYqwJEoCCYhzuLa/oMvKTGztvarGE++Tzt7uceBJJyq5PNMNTWJcLfNOfKjHLBLgxEySOYBgeJQ== X-Received: by 2002:a92:ce92:: with SMTP id r18mr8727276ilo.135.1576170009964; Thu, 12 Dec 2019 09:00:09 -0800 (PST) Received: from mail-il1-f177.google.com (mail-il1-f177.google.com. [209.85.166.177]) by smtp.gmail.com with ESMTPSA id k20sm283707iog.18.2019.12.12.09.00.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Dec 2019 09:00:08 -0800 (PST) Received: by mail-il1-f177.google.com with SMTP id a6so153500ili.9 for ; Thu, 12 Dec 2019 09:00:08 -0800 (PST) X-Received: by 2002:a92:1547:: with SMTP id v68mr8798475ilk.58.1576170007669; Thu, 12 Dec 2019 09:00:07 -0800 (PST) MIME-Version: 1.0 References: <1574934847-30372-1-git-send-email-rkambl@codeaurora.org> <1574934847-30372-2-git-send-email-rkambl@codeaurora.org> In-Reply-To: From: Doug Anderson Date: Thu, 12 Dec 2019 08:59:55 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/1] arm64: dts: qcom: sc7180: Add device node support for TSENS in SC7180 To: Amit Kucheria Cc: Rajeshwari , Andy Gross , Bjorn Andersson , Rob Herring , Mark Rutland , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , sivaa@codeaurora.org, sanm@codeaurora.org Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On Thu, Dec 12, 2019 at 8:56 AM Amit Kucheria wrote: > > On Thu, Dec 12, 2019 at 9:39 PM Doug Anderson wrote: > > > > Hi, > > > > On Thu, Dec 12, 2019 at 3:00 AM Amit Kucheria > > wrote: > > > > > > Hi Rajeshwari, > > > > > > On Thu, Nov 28, 2019 at 3:25 PM Rajeshwari wrote: > > > > > > > > Add TSENS node and user thermal zone for TSENS sensors in SC7180. > > > > > > > > Signed-off-by: Rajeshwari > > > > --- > > > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 527 +++++++++++++++++++++++++++++++++++ > > > > 1 file changed, 527 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > > index 666e9b9..6656ffc 100644 > > > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > > @@ -911,6 +911,26 @@ > > > > status = "disabled"; > > > > }; > > > > > > > > + tsens0: thermal-sensor@c263000 { > > > > + compatible = "qcom,sc7180-tsens","qcom,tsens-v2"; > > > > + reg = <0 0x0c263000 0 0x1ff>, /* TM */ > > > > + <0 0x0c222000 0 0x1ff>; /* SROT */ > > > > + #qcom,sensors = <15>; > > > > + interrupts = ; > > > > + interrupt-names = "uplow"; > > > > + #thermal-sensor-cells = <1>; > > > > + }; > > > > + > > > > + tsens1: thermal-sensor@c265000 { > > > > + compatible = "qcom,sc7180-tsens","qcom,tsens-v2"; > > > > + reg = <0 0x0c265000 0 0x1ff>, /* TM */ > > > > + <0 0x0c223000 0 0x1ff>; /* SROT */ > > > > + #qcom,sensors = <10>; > > > > + interrupts = ; > > > > + interrupt-names = "uplow"; > > > > + #thermal-sensor-cells = <1>; > > > > + }; > > > > + > > > > spmi_bus: spmi@c440000 { > > > > compatible = "qcom,spmi-pmic-arb"; > > > > reg = <0 0x0c440000 0 0x1100>, > > > > @@ -1121,6 +1141,513 @@ > > > > }; > > > > }; > > > > > > > > + thermal-zones { > > > > + cpu0-thermal { > > > > + polling-delay-passive = <250>; > > > > + polling-delay = <1000>; > > > > + > > > > + thermal-sensors = <&tsens0 1>; > > > > + > > > > + trips { > > > > + cpu0_alert0: trip-point0 { > > > > + temperature = <90000>; > > > > + hysteresis = <2000>; > > > > + type = "passive"; > > > > + }; > > > > + > > > > + cpu0_alert1: trip-point1 { > > > > + temperature = <95000>; > > > > + hysteresis = <2000>; > > > > + type = "passive"; > > > > + }; > > > > + > > > > + cpu0_crit: cpu_crit { > > > > + temperature = <110000>; > > > > + hysteresis = <1000>; > > > > + type = "critical"; > > > > + }; > > > > > > Where are the cooling maps for all the cpu thermal zones? A passive > > > trip point w/o a cooling map is not of much use. If you are waiting > > > for cpufreq support to land before adding them, then remove the > > > passive trip points for now and add them along with the cooling maps > > > when you have cooling devices. > > > > I will note that cpufreq support has landed in the qcom tree:: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=86899d8235ea0d3d7c293404fb43a6fabff866e6 > > > > ...so I guess the right thing is to send a patch adding the cooling > > maps for the cpu thermal zones? > > Great, then the cooling maps should be added to this patch itself. Well, except that this patch itself has also landed: https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=82bdc93972bf293c3407cb7fdac163aadfbb2c12 ...so I think my advice is still correct: the right thing is to send a patch adding the cooling maps for the cpu thermal zones -Doug