From: Doug Anderson <dianders@chromium.org>
To: Yakir Yang <ykk@rock-chips.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH v2 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel
Date: Fri, 10 Jun 2016 09:11:30 -0700 [thread overview]
Message-ID: <CAD=FV=Vmh-weKJLdDY=zfLRL9bMzDGvSV5gN=jaRV3d-b+jxiw@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=V2RF+Wr_6PfoV1EVr1djauZASC=vEsYCaXvRtjd523KQ@mail.gmail.com>
Hi,
On Wed, Jun 8, 2016 at 9:35 AM, Doug Anderson <dianders@chromium.org> wrote:
> Yakir,
>
> On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote:
>> The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected
>> using eDP interfaces.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
>> Changes in v2:
>> - Add detail timing of Sharp LQ123P1JX31 panel in v2
>>
>> drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>
> Looks good to me. Values in the table match the EDID I see from this
> panel and everything else looks to be in order.
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Tested-by: Doug Anderson <dianders@chromium.org>
Sorry for not noticing. :( ...but as others have pointed out for
your earlier patches, the size is incorrect. I found the correct size
and it should be:
.width = 259,
.height = 173,
-Doug
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-06-10 16:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 11:52 [PATCH v2 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding Yakir Yang
2016-06-08 11:52 ` [PATCH v2 2/6] drm/panel: simple: Add support for LG LP097QX1-SPA1 2048x1536 panel Yakir Yang
[not found] ` <1465386753-27730-1-git-send-email-ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-06-08 12:20 ` Emil Velikov
2016-06-10 13:26 ` Thierry Reding
2016-06-12 2:09 ` Yakir Yang
2016-06-08 11:52 ` [PATCH v2 3/6] dt-bindings: add Samsung LSN122DL01-C01 panel binding Yakir Yang
2016-06-08 11:52 ` [PATCH v2 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel Yakir Yang
[not found] ` <1465386762-27816-1-git-send-email-ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-06-10 0:04 ` Stéphane Marchesin
2016-06-12 2:05 ` Yakir Yang
2016-06-08 11:52 ` [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding Yakir Yang
2016-06-08 16:31 ` Doug Anderson
2016-06-10 13:42 ` Rob Herring
2016-06-10 16:40 ` Doug Anderson
2016-06-10 17:54 ` Rob Herring
2016-06-10 18:08 ` Doug Anderson
2016-06-12 2:14 ` Yakir Yang
2016-06-08 11:52 ` [PATCH v2 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel Yakir Yang
2016-06-08 16:35 ` Doug Anderson
2016-06-10 16:11 ` Doug Anderson [this message]
2016-06-12 2:12 ` Yakir Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Vmh-weKJLdDY=zfLRL9bMzDGvSV5gN=jaRV3d-b+jxiw@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).