devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RESEND][PATCH v2 3/3] dt-bindings: thermal: update sustainable-power with abstract scale
@ 2020-10-05 16:30 Lukasz Luba
  2020-10-05 17:43 ` Doug Anderson
  0 siblings, 1 reply; 2+ messages in thread
From: Lukasz Luba @ 2020-10-05 16:30 UTC (permalink / raw)
  To: linux-kernel, linux-pm, linux-doc, devicetree, robh+dt
  Cc: amitk, corbet, daniel.lezcano, lukasz.luba, Dietmar.Eggemann,
	qperret, dianders, mka, rnayak, rjw

Update the documentation for the binding 'sustainable-power' and allow
to provide values in an abstract scale. It is required when the cooling
devices use an abstract scale for their power values.

Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---

Hi Rob,
 
This is a fixed patch for DT binding, which now passes the
make dt_binding_check (I have changed tabs into spaces).
The former patch error that I have received is here [1]. 

Regards,
Lukasz

[1] https://lore.kernel.org/linux-pm/20201002114426.31277-1-lukasz.luba@arm.com/T/#md4b02a3ada592df67446566180643ba56788c159

 .../devicetree/bindings/thermal/thermal-zones.yaml  | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
index 3ec9cc87ec50..c445927749c3 100644
--- a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
+++ b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
@@ -99,10 +99,15 @@ patternProperties:
       sustainable-power:
         $ref: /schemas/types.yaml#/definitions/uint32
         description:
-          An estimate of the sustainable power (in mW) that this thermal zone
-          can dissipate at the desired control temperature. For reference, the
-          sustainable power of a 4-inch phone is typically 2000mW, while on a
-          10-inch tablet is around 4500mW.
+          An estimate of the sustainable power (in mW or in an abstract scale)
+          that this thermal zone can dissipate at the desired control
+          temperature. For reference, the sustainable power of a 4-inch phone
+          is typically 2000mW, while on a 10-inch tablet is around 4500mW.
+
+          It is possible to express the sustainable power in an abstract
+          scale. This is the case when the related cooling devices use also
+          abstract scale to express their power usage. The scale must be
+          consistent.
 
       trips:
         type: object
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RESEND][PATCH v2 3/3] dt-bindings: thermal: update sustainable-power with abstract scale
  2020-10-05 16:30 [RESEND][PATCH v2 3/3] dt-bindings: thermal: update sustainable-power with abstract scale Lukasz Luba
@ 2020-10-05 17:43 ` Doug Anderson
  0 siblings, 0 replies; 2+ messages in thread
From: Doug Anderson @ 2020-10-05 17:43 UTC (permalink / raw)
  To: Lukasz Luba
  Cc: LKML, Linux PM, linux-doc,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Rob Herring, amitk, Jonathan Corbet, Daniel Lezcano,
	Dietmar.Eggemann, Quentin Perret, Matthias Kaehlcke,
	Rajendra Nayak, Rafael J. Wysocki

Hi,

On Mon, Oct 5, 2020 at 9:30 AM Lukasz Luba <lukasz.luba@arm.com> wrote:
>
> Update the documentation for the binding 'sustainable-power' and allow
> to provide values in an abstract scale. It is required when the cooling
> devices use an abstract scale for their power values.
>
> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
> ---
>
> Hi Rob,
>
> This is a fixed patch for DT binding, which now passes the
> make dt_binding_check (I have changed tabs into spaces).
> The former patch error that I have received is here [1].
>
> Regards,
> Lukasz
>
> [1] https://lore.kernel.org/linux-pm/20201002114426.31277-1-lukasz.luba@arm.com/T/#md4b02a3ada592df67446566180643ba56788c159

...and because I suspect you might not look at any patches that fail
your auto-checker, I'd appreciate it if you could comment on the
discussion on the previous version of the patch.  Thanks!  :-)

-Doug

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-05 17:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05 16:30 [RESEND][PATCH v2 3/3] dt-bindings: thermal: update sustainable-power with abstract scale Lukasz Luba
2020-10-05 17:43 ` Doug Anderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).