From: Doug Anderson <dianders@google.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Asutosh Das <asutoshd@codeaurora.org>,
Sahitya Tummala <stummala@codeaurora.org>,
pragalla@codeaurora.org, nitirawa@codeaurora.org,
Ram Prakash Gupta <rampraka@codeaurora.org>,
Sayali Lokhande <sayalil@codeaurora.org>,
sartgarg@codeaurora.org, cang@codeaurora.org,
Linux MMC List <linux-mmc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Andy Gross <agross@kernel.org>,
Shaik Sajida Bhanu <sbhanu@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH V1] arm64: dts: qcom: sc7180: Use maximum drive strength values for eMMC
Date: Thu, 23 Sep 2021 13:19:37 -0700 [thread overview]
Message-ID: <CAD=FV=WFM2APGy-_wbcW_cX8_UNDyLQo3Q2QUgiyYM28Lj64wA@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=Wq-+Xzjc-o9p49pvf4A_q7L-THHp_wUQce47E+yMEgvA@mail.gmail.com>
Bjorn,
On Thu, Aug 19, 2021 at 6:44 AM Doug Anderson <dianders@google.com> wrote:
>
> Hi,
>
> On Tue, Aug 17, 2021 at 6:58 AM Doug Anderson <dianders@google.com> wrote:
> >
> > > pinconf-data {
> > > pins = "sdc1_data";
> > > bias-pull-up;
> > > - drive-strength = <10>;
> > > + drive-strength = <16>;
> >
> > I could be convinced that this is the right thing to do, but I want to
> > really make sure that it has had sufficient testing. Specifically as
> > this patch is written we'll be updating the drive strength for all
> > boards. Increasing the drive strength can sometimes introduce new
> > problems (reflections, noise, ...) so we have to be confident that
> > we're not breaking someone that used to work by increasing the drive
> > strength here. How much has this been tested?
>
> From further discussion internally, it sounds as if this should be
> fine and fixes more than just this one eMMC part. Thus:
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
We've been running with this patch in the Chrome OS kernel. If it
looks OK to you, it'd be great for it to land in your tree. Thanks!
-Doug
next prev parent reply other threads:[~2021-09-23 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 16:50 [PATCH V1] arm64: dts: qcom: sc7180: Use maximum drive strength values for eMMC Shaik Sajida Bhanu
2021-08-17 13:58 ` Doug Anderson
2021-08-19 13:44 ` Doug Anderson
2021-09-23 20:19 ` Doug Anderson [this message]
2021-09-23 20:30 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=WFM2APGy-_wbcW_cX8_UNDyLQo3Q2QUgiyYM28Lj64wA@mail.gmail.com' \
--to=dianders@google.com \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=asutoshd@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mka@chromium.org \
--cc=nitirawa@codeaurora.org \
--cc=pragalla@codeaurora.org \
--cc=rampraka@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sartgarg@codeaurora.org \
--cc=sayalil@codeaurora.org \
--cc=sbhanu@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).