From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFE27C433EF for ; Thu, 23 Sep 2021 22:45:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BEBCC60F6D for ; Thu, 23 Sep 2021 22:45:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243436AbhIWWrF (ORCPT ); Thu, 23 Sep 2021 18:47:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243431AbhIWWrE (ORCPT ); Thu, 23 Sep 2021 18:47:04 -0400 Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFCD4C061756 for ; Thu, 23 Sep 2021 15:45:31 -0700 (PDT) Received: by mail-qk1-x731.google.com with SMTP id q125so11289593qkd.12 for ; Thu, 23 Sep 2021 15:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dKp1hHRL8F+OQfFGWFADWVrKMY57aRNj7ogOQ5bGn2Y=; b=PGiSvpZ3mujpWebBaRFE1biL4E5ZSs320mbTYJm+7fNzUWjvYsqL7g6ZPS4AQTwwFR 2U5/M34k72YDoRewpiMvB5YvGXEekqhvcK4+KNsN5YHpR8+UoQlIOJs9AzWz+mI7ln/D oE80oyL4i2nXrwXC1nFBZliv0b4mcmtrcBowc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dKp1hHRL8F+OQfFGWFADWVrKMY57aRNj7ogOQ5bGn2Y=; b=CHvoQrDmatNbm0j8GqXQkrEVf1EZjHgYxJ5DP8Cnw8zblYooUDpB3D38CbUlPnoCiu m3utBAExtTeoGPr6aFta0i2THiUdwQRstM8CuSIXL6YYE1OC+hew4c4BkVDN3KogBPQ/ UBpxPkw+hQc6CAStmJyMgyCTM5cjugNj0Rcz0oS1CC+HKT8fSnRDvK580N9DFsG9HvGE KxObANJerN41JeOV+ukZxF+5i+LreG5hmCF4ptPA5LfzgsXZ7tVo356nopcA6/A9O4T3 WWrzhYUNqJ4QNCBMX2FQ0gv4qQ8eDY546X7Ukf5J3/O2wMUeEF0vXfOuUd24TByLB/kA DVGg== X-Gm-Message-State: AOAM532RwfUfYON/a79IZU3dE4Kh5pVMffru1Y1Rr5HEYMdap1iTsZTf p7+iyTFt/GOPDOA1Zm1UcUqivsrW+lN2ww== X-Google-Smtp-Source: ABdhPJx1SFjYr9cOllGv+b38Rp/az9TeUc/xmWoKt4N11K3ZIeeqInIs6nyUhrFpqgeqaPahvpHaQA== X-Received: by 2002:a05:620a:1aa6:: with SMTP id bl38mr7384902qkb.36.1632437130937; Thu, 23 Sep 2021 15:45:30 -0700 (PDT) Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com. [209.85.219.180]) by smtp.gmail.com with ESMTPSA id m21sm5036196qka.69.2021.09.23.15.45.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Sep 2021 15:45:29 -0700 (PDT) Received: by mail-yb1-f180.google.com with SMTP id b82so866696ybg.1 for ; Thu, 23 Sep 2021 15:45:29 -0700 (PDT) X-Received: by 2002:a25:ae97:: with SMTP id b23mr9195708ybj.50.1632437128929; Thu, 23 Sep 2021 15:45:28 -0700 (PDT) MIME-Version: 1.0 References: <1632399378-12229-1-git-send-email-rajpat@codeaurora.org> <1632399378-12229-2-git-send-email-rajpat@codeaurora.org> <1632436663.381520.3653405.nullmailer@robh.at.kernel.org> In-Reply-To: <1632436663.381520.3653405.nullmailer@robh.at.kernel.org> From: Doug Anderson Date: Thu, 23 Sep 2021 15:45:16 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V10 1/8] dt-bindings: spi: Add sc7280 support To: Rob Herring Cc: Rajesh Patil , Rob Herring , linux-arm-msm , Andy Gross , msavaliy@qti.qualcomm.com, Bjorn Andersson , Rajendra Nayak , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sai Prakash Ranjan , Stephen Boyd , satya priya , Matthias Kaehlcke Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On Thu, Sep 23, 2021 at 3:37 PM Rob Herring wrote: > > On Thu, 23 Sep 2021 17:46:11 +0530, Rajesh Patil wrote: > > Add compatible for sc7280 SoC. > > > > Signed-off-by: Rajesh Patil > > Reviewed-by: Doug Anderson > > Reviewed-by: Stephen Boyd > > --- > > Change in V10: > > - As per Stephen's comments, > > sorted compatible names in alphabet order > > > > Changes in V9: > > - No changes > > > > Changes in V8: > > - As per Doug's comments, added "qcom,sc7280-qspi" compatible > > > > Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1531702 > > > spi@88dc000: compatible:0: 'qcom,qspi-v1' is not one of ['qcom,sc7280-qspi', 'qcom,sdm845-qspi'] > arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dt.yaml > > spi@88dc000: compatible: ['qcom,qspi-v1'] is too short > arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dt.yaml > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dt.yaml Right. I mentioned this in earlier review feedback and Rajesh said he'd do a follow-up patch to add sc7180 to the list here and also add the proper compatible in the sc7180.dtsi file. That's not a new error and (IMO) shouldn't block this patch from moving forward, though it should be nearly trivial to do. -Doug