From: Doug Anderson <dianders@chromium.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Heiko Stuebner <heiko@sntech.de>,
devicetree@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: rockchip: A few fixes for veyron-{fievel,tiger}
Date: Tue, 30 Jul 2019 11:01:42 -0700 [thread overview]
Message-ID: <CAD=FV=Wub9Wkc5t4iQRjBK8R_d_oh4PoHPwLHb4T5+Meij7sSg@mail.gmail.com> (raw)
In-Reply-To: <20190730173444.56741-1-mka@chromium.org>
Hi,
On Tue, Jul 30, 2019 at 10:34 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> @@ -130,12 +138,13 @@
> regulator-max-microvolt = <1800000>;
> regulator-name = "vdd18_lcdt";
> regulator-state-mem {
> - regulator-on-in-suspend;
> + regulator-off-in-suspend;
> regulator-suspend-microvolt = <1800000>;
Please remove "regulator-suspend-microvolt = <1800000>;" which doesn't
make sense once you have "regulator-off-in-suspend".
> };
> };
>
> - /* This is not a pwren anymore, but the real power supply,
> + /*
> + * This is not a pwren anymore, but the real power supply,
> * vdd10_lcd for HDMI_AVDD_1V0
> */
> vdd10_lcd: LDO_REG7 {
> @@ -145,7 +154,7 @@
> regulator-max-microvolt = <1000000>;
> regulator-name = "vdd10_lcd";
> regulator-state-mem {
> - regulator-on-in-suspend;
> + regulator-off-in-suspend;
> regulator-suspend-microvolt = <1000000>;
Please remove "regulator-suspend-microvolt = <1000000>;" which doesn't
make sense once you have "regulator-off-in-suspend".
> };
>
> @@ -159,7 +168,7 @@
> regulator-max-microvolt = <3300000>;
> regulator-name = "vcc33_ccd";
> regulator-state-mem {
> - regulator-on-in-suspend;
> + regulator-off-in-suspend;
> regulator-suspend-microvolt = <3300000>;
Please remove "regulator-suspend-microvolt = <3300000>;" which doesn't
make sense once you have "regulator-off-in-suspend".
Other than those things, this patch looks good to me and feel free to
add my Reviewed-by. NOTE: when I tried applying this to my tree git
complained and I had to apply manually. Could you try sending this
patch atop Heiko's for-next tree? The yell I got:
error: sha1 information is lacking or useless
(arch/arm/boot/dts/rk3288-veyron-fievel.dts).
error: could not build fake ancestor
-Doug
next prev parent reply other threads:[~2019-07-30 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 17:34 [PATCH] ARM: dts: rockchip: A few fixes for veyron-{fievel,tiger} Matthias Kaehlcke
2019-07-30 18:01 ` Doug Anderson [this message]
2019-07-30 18:19 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Wub9Wkc5t4iQRjBK8R_d_oh4PoHPwLHb4T5+Meij7sSg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).