From: Doug Anderson <dianders@chromium.org>
To: Jonathan Corbet <corbet@lwn.net>,
andy.gross@linaro.org, david.brown@linaro.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Wolfram Sang <wsa@the-dreams.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Karthikeyan Ramasubramanian <kramasub@codeaurora.org>,
linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
Sagar Dharia <sdharia@codeaurora.org>,
Girish Mahadevan <girishm@codeaurora.org>,
evgreen@chromium.org
Subject: Re: [v2,3/7] soc: qcom: Add GENI based QUP Wrapper driver
Date: Fri, 26 Jan 2018 11:38:51 -0800 [thread overview]
Message-ID: <CAD=FV=XRvf+LYzrc8FX11dTG5KKbRyp5mTaP-39nC7SgjkZV_w@mail.gmail.com> (raw)
In-Reply-To: <1515805547-22816-4-git-send-email-kramasub@codeaurora.org>
Hi,
On Fri, Jan 12, 2018 at 5:05 PM, Karthikeyan Ramasubramanian
<kramasub@codeaurora.org> wrote:
> This driver manages the Generic Interface (GENI) firmware based Qualcomm
> Universal Peripheral (QUP) Wrapper. GENI based QUP is the next generation
> programmable module composed of multiple Serial Engines (SE) and supports
> a wide range of serial interfaces like UART, SPI, I2C, I3C, etc. This
> driver also enables managing the serial interface independent aspects of
> Serial Engines.
>
> Signed-off-by: Karthikeyan Ramasubramanian <kramasub@codeaurora.org>
> Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
> Signed-off-by: Girish Mahadevan <girishm@codeaurora.org>
> ---
> drivers/soc/qcom/Kconfig | 8 +
> drivers/soc/qcom/Makefile | 1 +
> drivers/soc/qcom/qcom-geni-se.c | 1016 +++++++++++++++++++++++++++++++++++++++
> include/linux/qcom-geni-se.h | 807 +++++++++++++++++++++++++++++++
> 4 files changed, 1832 insertions(+)
> create mode 100644 drivers/soc/qcom/qcom-geni-se.c
> create mode 100644 include/linux/qcom-geni-se.h
>
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index b81374b..b306d51 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -3,6 +3,14 @@
> #
> menu "Qualcomm SoC drivers"
>
> +config QCOM_GENI_SE
> + tristate "QCOM GENI Serial Engine Driver"
One tiny nit here: maybe it makes sense to add:
depends on ARCH_QCOM
...like all the other stuff in this file? Otherwise this ends up
polluting .config files for non-Qualcomm architectures.
-Doug
next prev parent reply other threads:[~2018-01-26 19:38 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 1:05 [PATCH v2 0/7] Introduce GENI SE Controller Driver Karthikeyan Ramasubramanian
2018-01-13 1:05 ` [PATCH v2 1/7] qcom-geni-se: Add QCOM GENI SE Driver summary Karthikeyan Ramasubramanian
2018-01-16 16:55 ` Bjorn Andersson
2018-01-29 21:52 ` Karthik Ramasubramanian
2018-01-13 1:05 ` [PATCH v2 2/7] dt-bindings: soc: qcom: Add device tree binding for GENI SE Karthikeyan Ramasubramanian
2018-01-17 6:25 ` Bjorn Andersson
2018-01-19 22:53 ` Rob Herring
2018-02-26 21:24 ` Karthik Ramasubramanian
2018-01-13 1:05 ` [PATCH v2 4/7] dt-bindings: i2c: Add device tree bindings for GENI I2C Controller Karthikeyan Ramasubramanian
[not found] ` <1515805547-22816-5-git-send-email-kramasub-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-01-17 6:31 ` Bjorn Andersson
2018-02-26 21:28 ` Karthik Ramasubramanian
2018-01-13 1:05 ` [PATCH v2 6/7] dt-bindings: serial: Add bindings for GENI based UART Controller Karthikeyan Ramasubramanian
2018-01-17 6:35 ` Bjorn Andersson
2018-02-27 13:25 ` Karthik Ramasubramanian
2018-01-13 1:05 ` [PATCH v2 7/7] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP Karthikeyan Ramasubramanian
2018-01-18 19:43 ` Bjorn Andersson
2018-01-19 7:12 ` Bjorn Andersson
2018-02-27 15:07 ` Karthik Ramasubramanian
2018-01-24 23:07 ` [v2, " Evan Green
2018-02-14 11:04 ` [PATCH v2 " Amit Kucheria
2018-02-23 18:06 ` [v2, " Guenter Roeck
2018-02-27 13:23 ` Karthik Ramasubramanian
2018-02-23 19:05 ` Doug Anderson
[not found] ` <1515805547-22816-1-git-send-email-kramasub-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-01-13 1:05 ` [PATCH v2 3/7] soc: qcom: Add GENI based QUP Wrapper driver Karthikeyan Ramasubramanian
2018-01-17 6:20 ` Bjorn Andersson
2018-01-18 9:13 ` Rajendra Nayak
2018-01-18 16:57 ` Bjorn Andersson
2018-01-19 22:57 ` Rob Herring
2018-01-31 19:02 ` Karthik Ramasubramanian
[not found] ` <1abb0679-1997-9b70-30bd-d3472cea7053-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-02-05 23:53 ` Bjorn Andersson
2018-01-31 18:58 ` Karthik Ramasubramanian
2018-02-05 23:50 ` Bjorn Andersson
[not found] ` <1515805547-22816-4-git-send-email-kramasub-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-01-24 23:06 ` [v2,3/7] " Evan Green
2018-01-26 19:38 ` Doug Anderson [this message]
2018-02-14 11:07 ` [PATCH v2 3/7] " Amit Kucheria
2018-02-16 20:44 ` Karthik Ramasubramanian
2018-01-13 1:05 ` [PATCH v2 5/7] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller Karthikeyan Ramasubramanian
[not found] ` <1515805547-22816-6-git-send-email-kramasub-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-01-18 5:23 ` Bjorn Andersson
2018-02-27 13:16 ` Karthik Ramasubramanian
2018-01-24 23:07 ` [v2, " Evan Green
2018-01-19 18:32 ` [PATCH v2 0/7] Introduce GENI SE Controller Driver Randy Dunlap
2018-01-31 18:59 ` Karthik Ramasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=XRvf+LYzrc8FX11dTG5KKbRyp5mTaP-39nC7SgjkZV_w@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=andy.gross@linaro.org \
--cc=corbet@lwn.net \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=girishm@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kramasub@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sdharia@codeaurora.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).