From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Anderson Subject: Re: [v2,3/7] soc: qcom: Add GENI based QUP Wrapper driver Date: Fri, 26 Jan 2018 11:38:51 -0800 Message-ID: References: <1515805547-22816-4-git-send-email-kramasub@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1515805547-22816-4-git-send-email-kramasub@codeaurora.org> Sender: linux-i2c-owner@vger.kernel.org To: Jonathan Corbet , andy.gross@linaro.org, david.brown@linaro.org, Rob Herring , Mark Rutland , Wolfram Sang , Greg Kroah-Hartman Cc: Karthikeyan Ramasubramanian , linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org, Jiri Slaby , Sagar Dharia , Girish Mahadevan , evgreen@chromium.org List-Id: devicetree@vger.kernel.org Hi, On Fri, Jan 12, 2018 at 5:05 PM, Karthikeyan Ramasubramanian wrote: > This driver manages the Generic Interface (GENI) firmware based Qualcomm > Universal Peripheral (QUP) Wrapper. GENI based QUP is the next generation > programmable module composed of multiple Serial Engines (SE) and supports > a wide range of serial interfaces like UART, SPI, I2C, I3C, etc. This > driver also enables managing the serial interface independent aspects of > Serial Engines. > > Signed-off-by: Karthikeyan Ramasubramanian > Signed-off-by: Sagar Dharia > Signed-off-by: Girish Mahadevan > --- > drivers/soc/qcom/Kconfig | 8 + > drivers/soc/qcom/Makefile | 1 + > drivers/soc/qcom/qcom-geni-se.c | 1016 +++++++++++++++++++++++++++++++++++++++ > include/linux/qcom-geni-se.h | 807 +++++++++++++++++++++++++++++++ > 4 files changed, 1832 insertions(+) > create mode 100644 drivers/soc/qcom/qcom-geni-se.c > create mode 100644 include/linux/qcom-geni-se.h > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > index b81374b..b306d51 100644 > --- a/drivers/soc/qcom/Kconfig > +++ b/drivers/soc/qcom/Kconfig > @@ -3,6 +3,14 @@ > # > menu "Qualcomm SoC drivers" > > +config QCOM_GENI_SE > + tristate "QCOM GENI Serial Engine Driver" One tiny nit here: maybe it makes sense to add: depends on ARCH_QCOM ...like all the other stuff in this file? Otherwise this ends up polluting .config files for non-Qualcomm architectures. -Doug