From: Doug Anderson <dianders@chromium.org>
To: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip
Date: Thu, 6 Oct 2022 12:53:32 -0700 [thread overview]
Message-ID: <CAD=FV=Xe0x6pQ+Uq5Vo7cqvS0+O8qpwUwO-e6fWhSyFvdF-_Fg@mail.gmail.com> (raw)
In-Reply-To: <20221006185333.v7.3.I52e4b4b20e2eb0ae20f2a9bb198aa6410f04cf16@changeid>
Hi,
On Thu, Oct 6, 2022 at 3:58 AM Sheng-Liang Pan
<sheng-liang.pan@quanta.corp-partner.google.com> wrote:
>
> Add an goodix touch screen chip GT7986U.
In theory you could beef up the commit message explaining that GT7986U
is expected to be fully compatible with a driver written for GT7375P,
but I wouldn't spin just for that.
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> ---
>
> Changes in v7:
> - goodix gt7986 dt bindings added in v7
>
> Documentation/devicetree/bindings/input/goodix,gt7375p.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> index fe1c5016f7f31..1c191bc5a1782 100644
> --- a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> +++ b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> @@ -16,8 +16,11 @@ description:
>
> properties:
> compatible:
> - items:
> + oneOf:
> - const: goodix,gt7375p
> + - items:
> + - const: goodix,gt7986u
> + - const: goodix,gt7375p
I haven't run this through schema validation, but from a visual
inspection it looks good to me.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2022-10-06 19:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 10:58 [PATCH v7 0/4] Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
2022-10-06 10:58 ` [PATCH v7 1/4] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker Sheng-Liang Pan
2022-10-06 10:58 ` [PATCH v7 2/4] arm64: dts: qcom: Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
2022-10-06 10:58 ` [PATCH v7 3/4] dt-bindings: input: touchscreen: Add goodix GT7986U touchscreen chip Sheng-Liang Pan
2022-10-06 19:53 ` Doug Anderson [this message]
2022-10-06 20:08 ` Rob Herring
2022-10-06 10:58 ` [PATCH v7 4/4] arm64: dts: qcom: Add touchscreen and touchpad support for evoker Sheng-Liang Pan
2022-10-06 19:54 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Xe0x6pQ+Uq5Vo7cqvS0+O8qpwUwO-e6fWhSyFvdF-_Fg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sheng-liang.pan@quanta.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).