From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01189C433F5 for ; Tue, 19 Oct 2021 21:12:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E19E960EFE for ; Tue, 19 Oct 2021 21:12:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229665AbhJSVOS (ORCPT ); Tue, 19 Oct 2021 17:14:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbhJSVOR (ORCPT ); Tue, 19 Oct 2021 17:14:17 -0400 Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9621FC061749 for ; Tue, 19 Oct 2021 14:12:04 -0700 (PDT) Received: by mail-il1-x133.google.com with SMTP id g2so19883415ild.1 for ; Tue, 19 Oct 2021 14:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=30BnP4r6CE0OkZvT19kcbgPK/6Ckj3KjznbN6qKawuk=; b=fpA7N/KYD+Fh+EqegyotiKveYMCDZtJ4zi3/phXmtjRDphoY5PgXliB8+bY62n45i3 JVOV/VITICl2sudKvC91/HihnhlM9h8FXhI0rMD4Qmh3tsLTyLPBNsuAf+vNtdsiQ/vd X8ZS+4C8t61x+oCuOd4J4MlzH+H1psJwjmzHE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=30BnP4r6CE0OkZvT19kcbgPK/6Ckj3KjznbN6qKawuk=; b=nikh/RSLIkLsd4Q6B0BZ94s7pC/yGax+fnVE93vflXic70/NZAXPirc7hjrDjg1yXs USh/80NBvT91CL3sUMz/Uml5vZxXUPQPB6Wx5bpmRiuv/HV05H/O/BTa29U5QuWw5sit fzXQeLa++16EWMVvmiMgEjAb+Zb6IfOha7HldDIKPEJ8AHsBQzISCp3cI09AaKOC3GWN PK+KxXgmGna9VnOJYQxu8wGA74OUKVBK157J3f4EDAZSY8CSudthxltdmSGX5OIKuZK7 JOJGVqBk28p0xUI2YxKtRFE8kDqNWwChtTKruFlwDy5sezMXVRon0uckB55NPxZQgKbT rKpg== X-Gm-Message-State: AOAM531+CmlmdNU5dBnOsfzghZFIme/SRaqNvzyO8+jIlA1nGOQUOVUA oTg2RjJZUuwJ1bhb2H3VnL2MshHbKG9pOg== X-Google-Smtp-Source: ABdhPJxctfymQsOxCyvt1z64+uLiNpes8dTTAskDDnTFLuxMYl/Ao7IxFMBM1o2O97+vCSQlMDuEHQ== X-Received: by 2002:a05:6e02:1486:: with SMTP id n6mr20400105ilk.195.1634677923581; Tue, 19 Oct 2021 14:12:03 -0700 (PDT) Received: from mail-io1-f43.google.com (mail-io1-f43.google.com. [209.85.166.43]) by smtp.gmail.com with ESMTPSA id x14sm87352ilv.26.2021.10.19.14.12.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Oct 2021 14:12:02 -0700 (PDT) Received: by mail-io1-f43.google.com with SMTP id b188so17141489iof.8 for ; Tue, 19 Oct 2021 14:12:01 -0700 (PDT) X-Received: by 2002:a05:6638:258e:: with SMTP id s14mr5926528jat.54.1634677921595; Tue, 19 Oct 2021 14:12:01 -0700 (PDT) MIME-Version: 1.0 References: <1632399378-12229-1-git-send-email-rajpat@codeaurora.org> <1632399378-12229-9-git-send-email-rajpat@codeaurora.org> In-Reply-To: From: Doug Anderson Date: Tue, 19 Oct 2021 14:11:49 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V10 8/8] arm64: dts: sc7280: Add aliases for I2C and SPI To: Bjorn Andersson Cc: Arnd Bergmann , Rajesh Patil , Andy Gross , Rob Herring , linux-arm-msm , Linux Kernel Mailing List , DTML , Rajendra Nayak , Sai Prakash Ranjan , msavaliy@qti.qualcomm.com, satya priya , Stephen Boyd , Matthias Kaehlcke Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On Tue, Oct 19, 2021 at 1:57 PM Bjorn Andersson wrote: > > On Tue 19 Oct 13:43 PDT 2021, Arnd Bergmann wrote: > > > On Thu, Sep 23, 2021 at 2:18 PM Rajesh Patil wrote: > > > > > > Add aliases for i2c and spi for sc7280 soc. > > > > > > Signed-off-by: Rajesh Patil > > > Reviewed-by: Stephen Boyd > > > > I saw this in the pull request, can this please be reverted? > > > > Yes, this can certainly be corrected. > > > Putting the aliases into the .dtsi file is really silly, as there are > > likely boards that > > don't connect every single one of those, and then will have to > > override and renumber > > them. > > > > Please only list the aliases that are actually connected on a particular > > board. Hrm. I know this gets into slightly controversial topics, but I'm a little curious what the downside of having these in the dtsi is. In the case where these i2c/spi/mmc devices _don't_ have "well defined" numbers in the hardware manual of the SoC then I can agree that it doesn't make sense to list these in the dtsi file. However, in the case of sc7280 these numbers are well defined at the SoC level for i2c and SPI. Said another way: if you have a board that's got peripherals connected on the pins labelled "i2c2" and "i2c6" on the SoC then it's a really nice thing if these show up on /dev/i2c-2 and /dev/i2c-6. ...so I'm not sure what board exactly would be overriding and re-numbering? Unless a board really has a strong use case where they need the device connected to the pins for "i2c2" to show up on "/dev/i2c-0"? -Doug