devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: fsl: DPAA FMan DMA operations are coherent
@ 2020-10-05 12:46 Madalin Bucur
  2020-10-05 15:07 ` Li Yang
  2020-10-30  7:39 ` Shawn Guo
  0 siblings, 2 replies; 5+ messages in thread
From: Madalin Bucur @ 2020-10-05 12:46 UTC (permalink / raw)
  To: shawnguo
  Cc: devicetree, leoyang.li, robh+dt, linux-arm-kernel, netdev,
	camelia.groza, Madalin Bucur

Although the DPAA 1 FMan operations are coherent, the device tree
node for the FMan does not indicate that, resulting in a needless
loss of performance. Adding the missing dma-coherent property.

Fixes: 1ffbecdd8321 ("arm64: dts: add DPAA FMan nodes")

Signed-off-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
Tested-by: Camelia Groza <camelia.groza@oss.nxp.com>
---
 arch/arm64/boot/dts/freescale/qoriq-fman3-0.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0.dtsi
index 8bc6caa9167d..4338db14c5da 100644
--- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0.dtsi
+++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0.dtsi
@@ -19,6 +19,7 @@ fman0: fman@1a00000 {
 	clock-names = "fmanclk";
 	fsl,qman-channel-range = <0x800 0x10>;
 	ptimer-handle = <&ptp_timer0>;
+	dma-coherent;
 
 	muram@0 {
 		compatible = "fsl,fman-muram";
-- 
2.1.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: fsl: DPAA FMan DMA operations are coherent
  2020-10-05 12:46 [PATCH] arm64: dts: fsl: DPAA FMan DMA operations are coherent Madalin Bucur
@ 2020-10-05 15:07 ` Li Yang
  2020-10-30  7:39 ` Shawn Guo
  1 sibling, 0 replies; 5+ messages in thread
From: Li Yang @ 2020-10-05 15:07 UTC (permalink / raw)
  To: madalin.bucur
  Cc: Shawn Guo,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Rob Herring,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, Netdev,
	camelia.groza

On Mon, Oct 5, 2020 at 7:47 AM Madalin Bucur <madalin.bucur@oss.nxp.com> wrote:
>
> Although the DPAA 1 FMan operations are coherent, the device tree
> node for the FMan does not indicate that, resulting in a needless
> loss of performance. Adding the missing dma-coherent property.
>
> Fixes: 1ffbecdd8321 ("arm64: dts: add DPAA FMan nodes")
>
> Signed-off-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
> Tested-by: Camelia Groza <camelia.groza@oss.nxp.com>

Acked-by: Li Yang <leoyang.li@nxp.com>

> ---
>  arch/arm64/boot/dts/freescale/qoriq-fman3-0.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/qoriq-fman3-0.dtsi b/arch/arm64/boot/dts/freescale/qoriq-fman3-0.dtsi
> index 8bc6caa9167d..4338db14c5da 100644
> --- a/arch/arm64/boot/dts/freescale/qoriq-fman3-0.dtsi
> +++ b/arch/arm64/boot/dts/freescale/qoriq-fman3-0.dtsi
> @@ -19,6 +19,7 @@ fman0: fman@1a00000 {
>         clock-names = "fmanclk";
>         fsl,qman-channel-range = <0x800 0x10>;
>         ptimer-handle = <&ptp_timer0>;
> +       dma-coherent;
>
>         muram@0 {
>                 compatible = "fsl,fman-muram";
> --
> 2.1.0
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: fsl: DPAA FMan DMA operations are coherent
  2020-10-05 12:46 [PATCH] arm64: dts: fsl: DPAA FMan DMA operations are coherent Madalin Bucur
  2020-10-05 15:07 ` Li Yang
@ 2020-10-30  7:39 ` Shawn Guo
  2020-11-11 15:33   ` Madalin Bucur
  1 sibling, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2020-10-30  7:39 UTC (permalink / raw)
  To: Madalin Bucur
  Cc: devicetree, leoyang.li, robh+dt, linux-arm-kernel, netdev, camelia.groza

On Mon, Oct 05, 2020 at 03:46:39PM +0300, Madalin Bucur wrote:
> Although the DPAA 1 FMan operations are coherent, the device tree
> node for the FMan does not indicate that, resulting in a needless
> loss of performance. Adding the missing dma-coherent property.
> 
> Fixes: 1ffbecdd8321 ("arm64: dts: add DPAA FMan nodes")
> 
> Signed-off-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
> Tested-by: Camelia Groza <camelia.groza@oss.nxp.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] arm64: dts: fsl: DPAA FMan DMA operations are coherent
  2020-10-30  7:39 ` Shawn Guo
@ 2020-11-11 15:33   ` Madalin Bucur
  2020-11-16  7:06     ` Shawn Guo
  0 siblings, 1 reply; 5+ messages in thread
From: Madalin Bucur @ 2020-11-11 15:33 UTC (permalink / raw)
  To: Shawn Guo, Madalin Bucur (OSS)
  Cc: devicetree, Camelia Alexandra Groza (OSS),
	netdev, Leo Li, robh+dt, linux-arm-kernel

> -----Original Message-----
> From: linux-arm-kernel <linux-arm-kernel-bounces@lists.infradead.org> On
> Behalf Of Shawn Guo
> To: Madalin Bucur (OSS) <madalin.bucur@oss.nxp.com>
> Subject: Re: [PATCH] arm64: dts: fsl: DPAA FMan DMA operations are
> coherent
> 
> On Mon, Oct 05, 2020 at 03:46:39PM +0300, Madalin Bucur wrote:
> > Although the DPAA 1 FMan operations are coherent, the device tree
> > node for the FMan does not indicate that, resulting in a needless
> > loss of performance. Adding the missing dma-coherent property.
> >
> > Fixes: 1ffbecdd8321 ("arm64: dts: add DPAA FMan nodes")
> >
> > Signed-off-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
> > Tested-by: Camelia Groza <camelia.groza@oss.nxp.com>
> 
> Applied, thanks.

Hi, Shawn,

will this fix for the device trees be picked up in the stable trees as well?
Do I need to do something about it?

Thanks
Madalin

PS: will this make it into v5.10 or v5.11?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: fsl: DPAA FMan DMA operations are coherent
  2020-11-11 15:33   ` Madalin Bucur
@ 2020-11-16  7:06     ` Shawn Guo
  0 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2020-11-16  7:06 UTC (permalink / raw)
  To: Madalin Bucur
  Cc: Madalin Bucur (OSS), devicetree, Camelia Alexandra Groza (OSS),
	netdev, Leo Li, robh+dt, linux-arm-kernel

On Wed, Nov 11, 2020 at 03:33:19PM +0000, Madalin Bucur wrote:
> > -----Original Message-----
> > From: linux-arm-kernel <linux-arm-kernel-bounces@lists.infradead.org> On
> > Behalf Of Shawn Guo
> > To: Madalin Bucur (OSS) <madalin.bucur@oss.nxp.com>
> > Subject: Re: [PATCH] arm64: dts: fsl: DPAA FMan DMA operations are
> > coherent
> > 
> > On Mon, Oct 05, 2020 at 03:46:39PM +0300, Madalin Bucur wrote:
> > > Although the DPAA 1 FMan operations are coherent, the device tree
> > > node for the FMan does not indicate that, resulting in a needless
> > > loss of performance. Adding the missing dma-coherent property.
> > >
> > > Fixes: 1ffbecdd8321 ("arm64: dts: add DPAA FMan nodes")
> > >
> > > Signed-off-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
> > > Tested-by: Camelia Groza <camelia.groza@oss.nxp.com>
> > 
> > Applied, thanks.
> 
> Hi, Shawn,
> 
> will this fix for the device trees be picked up in the stable trees as well?
> Do I need to do something about it?

When it's landed in Linus' tree, stable kernel will pick it up due to
the Fixes: tag there.  So you do not need to do anything about it.

> 
> Thanks
> Madalin
> 
> PS: will this make it into v5.10 or v5.11?

I'm sending it to arm-soc folks as a material for v5.10-rc.  So if
everything goes well, it will get into v5.10.

Shawn

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-11-16  7:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05 12:46 [PATCH] arm64: dts: fsl: DPAA FMan DMA operations are coherent Madalin Bucur
2020-10-05 15:07 ` Li Yang
2020-10-30  7:39 ` Shawn Guo
2020-11-11 15:33   ` Madalin Bucur
2020-11-16  7:06     ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).