devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ChiYuan Huang <u0084500@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
	cy_huang <cy_huang@richtek.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] regulator: rtmv20: Add DT-binding document for Richtek RTMV20
Date: Wed, 30 Sep 2020 18:02:56 +0800	[thread overview]
Message-ID: <CADiBU3_My=dpV1ef82PSs5wme8q1-fgPxoTLiQbJRcYd6KZw_A@mail.gmail.com> (raw)
In-Reply-To: <20200930094224.GA4974@sirena.org.uk>

Mark Brown <broonie@kernel.org> 於 2020年9月30日 週三 下午5:43寫道：
>
> On Wed, Sep 30, 2020 at 10:23:49AM +0800, ChiYuan Huang wrote:
>
> >    Due to that already merged into your regulator for-next git, may I
> > send the patch to fix Rob's comment?
>
> Of course, yes please.

OK, Thx.
>
> > And I also found one line need to be added into rtmv20 probe phase.
> > Please check below.
> >         /*
> >          * keep in shutdown mode to minimize the current consumption
> >          * and also mark regcache as dirty
> >          */
> > +      regcache_cache_only(priv->regmap, true);
> >         regcache_mark_dirty(priv->regmap);
> >         gpiod_set_value(priv->enable_gpio, 0);
> >
> > Can I directly merge into one that includes Rob's comment and the
> > above line to be added?
>
> Please make it a separate patch.
I'll send the separate patch by next.

  reply	other threads:[~2020-09-30 10:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28  7:19 [PATCH v2 1/2] regulator: rtmv20: Adds support for Richtek RTMV20 load switch regulator cy_huang
2020-09-28  7:19 ` [PATCH v2 2/2] regulator: rtmv20: Add DT-binding document for Richtek RTMV20 cy_huang
2020-09-29 15:06   ` Rob Herring
2020-09-30  2:23     ` ChiYuan Huang
2020-09-30  9:42       ` Mark Brown
2020-09-30 10:02         ` ChiYuan Huang [this message]
2020-09-28 19:35 ` [PATCH v2 1/2] regulator: rtmv20: Adds support for Richtek RTMV20 load switch regulator Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADiBU3_My=dpV1ef82PSs5wme8q1-fgPxoTLiQbJRcYd6KZw_A@mail.gmail.com' \
    --to=u0084500@gmail.com \
    --cc=broonie@kernel.org \
    --cc=cy_huang@richtek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).